From edb729421f26d9709140e24da559929d2843169a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 16 Jun 2020 15:44:40 +0200 Subject: [PATCH] Bug 25751: Add ORDERED in dropdown list of suggestion's statuses The status "ORDERED" is missing from the pull down list of status values when editing a suggestion, so the first option is selected "No status". This leads to data loss when editing a suggestion in the status "ORDERED". Worse: the status can't be reset to "ORDERED" and so no AVAILABLE notice can be sent to the patron. Test plan: - Create a suggestion, accept it, create a new order from this suggestion. - Verify status is "ORDERED" - Edit the suggestion => Without this patch the dropdown list does not have "Ordered", and if you save you lost the status => With this patch applied the dropdown list has "Ordered" preselected. You can save and preserve the status. Signed-off-by: Holly Cooper Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit eeb7ac6fc0d14c9e731b7759c78f37cadcfa575f) Signed-off-by: Lucas Gass (cherry picked from commit c320dfa3beef2bce10e87572ee9dd7f6849a694f) Signed-off-by: Aleisha Amohia --- .../prog/en/modules/suggestion/suggestion.tt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 3204d51ed7..88c943be50 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -319,6 +319,12 @@ [% END %] + [% IF ( statusselected_ORDERED ) %] + + [% ELSE %] + + [% END %] + [% FOREACH s IN SuggestionStatuses %] [% IF s.authorised_value == suggestion.STATUS %] @@ -575,6 +581,12 @@ [% END %] + [% IF ( statusselected_ORDERED ) %] + + [% ELSE %] + + [% END %] + [% IF ( statusselected_REJECTED ) %] [% ELSE %] @@ -702,6 +714,12 @@ [% END %] + [% IF ( statusselected_ORDERED ) %] + + [% ELSE %] + + [% END %] + [% FOREACH s IN SuggestionStatuses %] [% IF s.authorised_value == selected_status %] -- 2.39.5