]> git.koha-community.org Git - koha.git/commit
Bug 18697: Final polishing
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 31 May 2017 14:19:35 +0000 (16:19 +0200)
committerKatrin Fischer <katrin.fischer.83@web.de>
Thu, 29 Jun 2017 20:38:49 +0000 (22:38 +0200)
commit43ff7d25e5916a00b6ab2c51a2951d06ed9f1759
treef168b44f2dcd23951835da88b6fb2ff7046a456a
parent94704e9a5acf520607e66fd383f2c4f023c63f23
Bug 18697: Final polishing

GetFictiveIssueNumber:
Returns undef instead of 0 for irregular frequencies. Also added to POD.
Removed unused variable $wkno.
Adding a return makes the if(unit) unneeded.
Replaced (a+b)/b by 1+a/b.

_delta_units:
Added a comment about its parameters.

GetFictiveIssueNumber.t:
Adjusted the tests for irregular frequencies accordingly.

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4e9701c36a6743eff72b8127de2cc79ff463013b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 1f530d55ec7f8b857e40c31bf977bc1ce17ffa8e)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/Serials.pm
t/db_dependent/Serials/GetFictiveIssueNumber.t