]> git.koha-community.org Git - koha.git/commit
Bug 25567: Prevent patron category type's categorycode to be created with ""
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 21 May 2020 13:30:35 +0000 (15:30 +0200)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Thu, 11 Jun 2020 22:12:15 +0000 (22:12 +0000)
commita3d5e03d26e1bc54a8a14765e670c4e77e98bdf6
tree3f3cb6e565cde75c0ce1bede4cd26b31d53cadb0
parentec82606a3ad0371cac8427a01cb058a9df36dbc2
Bug 25567: Prevent patron category type's categorycode to be created with ""

It must be NULL/undef, the default from the DB.

The method Koha::Patron::Attribute::Type->categorycode is not covered by tests!

To recreate:
Create a new patron attribute type, don't select a patron's category (and not repeatable or unique)
Go to the batch patron modification tool, enter a cardnumber, next.
=> boom!
Apply the patch, edit the patron attribute, save
Go to the batch patron modification tool, enter a cardnumber, next.
=> success!

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 7ce6f7895610913f35fb1531faa1a40cefcd5f88)
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
admin/patron-attr-types.pl