]> git.koha-community.org Git - koha.git/commit
Bug 12748 - Fixes duplicate serials with an "expected" status bug
authorremi <remi.mayrand-provencher@inLibro.com>
Tue, 11 Aug 2015 15:10:45 +0000 (11:10 -0400)
committerFrédéric Demians <f.demians@tamil.fr>
Fri, 24 Jun 2016 05:19:13 +0000 (07:19 +0200)
commit695dc4c370d4d170b41447c583c8bfe91b0609e2
treea5d6174375d9a92932fbe1d5f583119723216706
parent4d2f605b37a5a4ac9087e7d26cffe22d75455d10
Bug 12748 - Fixes duplicate serials with an "expected" status bug

Added a new sub to Serials.pm to be able to get serials with their statuses.
Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything.

Also modified Serials.t to be able to test those changes.

Test Plan
1) Apply patch
2) Run ./t/db_dependent/Serials.t
3) Validate that there are no errors
4) Go on "Serial collection information" page for a serial of your choice
5) Click on "Generate next"
6) Change the status of the original serial from "late" to "expected"
7) Change the newly generated serial from "expected" to "delete"
8) Validate that there are no new serials created by instruction 7 and that the serial was deleted
9) Run ./t/db_dependent/Serials.t

With QA Fixes

- Use the constant instead of the code (1 vs EXPECTED)
- Avoid interpolation in query
- use selectall_arrayref instead of fetchall_arrayref

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 10fd9f5ec0d5faa7b54b0bfaf5a7b8fccd665f0a)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
C4/Serials.pm
t/db_dependent/Serials.t [changed mode: 0644->0755]