]> git.koha-community.org Git - koha.git/commit
Bug 20145: Do not insert 0000-00-00 in patron tests (and more)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Feb 2018 18:15:39 +0000 (15:15 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 27 Mar 2018 08:43:21 +0000 (10:43 +0200)
commitda33f365debdd09c8f9b8af2ca904d2f72d3c062
tree84be0b10686f3ec0e5ffd686021bf600f50205be
parent5eb8bcb4eafa9fb717f24a34c245025f81d1a85b
Bug 20145: Do not insert 0000-00-00 in patron tests (and more)

We should call Koha::Patron->is_expired in CanBookBeIssued instead of
doing the same calculation.

Tests have been adapted to pass with new SQL modes.

We should not need to update the values in DB, we already have
  Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023)

Test plan:
  prove t/db_dependent/Circulation/dateexpiry.t
  prove t/db_dependent/Koha/Patrons.t
must return green

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Conflicts:
C4/Circulation.pm
t/db_dependent/Koha/Patrons.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 9f075a4fdb2649493820ffed20a352add02c05ea)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Circulation.pm
C4/Utils/DataTables/Members.pm
Koha/Patron.pm
t/db_dependent/Circulation/dateexpiry.t
t/db_dependent/Koha/Patrons.t