From ac00e73077164db595432b723ee6f938e009dc7d Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 8 Jun 2016 15:32:31 +0100
Subject: [PATCH] Bug 16492: Add a FIXME to explain the possible problem with
 no_set_userenv
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 4f3067184d7dd3666d404a2165d72755cb0b227d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
---
 C4/Auth.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/C4/Auth.pm b/C4/Auth.pm
index a5cf72ccfb..985bd393f3 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -1737,6 +1737,11 @@ sub get_session {
     return $session;
 }
 
+
+# FIXME no_set_userenv may be replaced with force_branchcode_for_userenv
+# (or something similar)
+# Currently it's only passed from C4::SIP::ILS::Patron::check_password, but
+# not having a userenv defined could cause a crash.
 sub checkpw {
     my ( $dbh, $userid, $password, $query, $type, $no_set_userenv ) = @_;
     $type = 'opac' unless $type;
-- 
2.39.5