From cb0967ae7dd5cc94b906887371982736d54323b4 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 9 Oct 2020 16:13:00 +0100 Subject: [PATCH] Bug 26648: Prevent explosion in notices on missing item The item accessor in Koha::Old::Checkouts could explode given a checkout where the item had been deleted. To test 1/ Edit the issueslip notice to output some item details from the borrowers old checkouts [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% old_checkout.item.price %] [% END %] [% END %] 2/ Delete the item associated with an old checkout for a test patron 3/ Print the issueslip for the patron 4/ Note a server side error is triggered 5/ Apply the patch 6/ Print the slip again and note the price details for old checkouts are now displayed 7/ Signoff Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 971ad5538c3026e126081376520ccb3b13c12d1c) Signed-off-by: Lucas Gass --- Koha/Old/Checkout.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Koha/Old/Checkout.pm b/Koha/Old/Checkout.pm index e4cd9989f1..d8c02cd9da 100644 --- a/Koha/Old/Checkout.pm +++ b/Koha/Old/Checkout.pm @@ -42,6 +42,7 @@ Return the checked out item sub item { my ( $self ) = @_; my $item_rs = $self->_result->item; + return unless $item_rs; return Koha::Item->_new_from_dbic( $item_rs ); } -- 2.39.5