From eeb7ac6fc0d14c9e731b7759c78f37cadcfa575f Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 16 Jun 2020 15:44:40 +0200
Subject: [PATCH] Bug 25751: Add ORDERED in dropdown list of suggestion's
 statuses

The status "ORDERED" is missing from the pull down list of
status values when editing a suggestion, so the first
option is selected "No status".

This leads to data loss when editing a suggestion in the
status "ORDERED". Worse: the status can't be reset to
"ORDERED" and so no AVAILABLE notice can be sent to the patron.

Test plan:
- Create a suggestion, accept it, create a new order from this suggestion.
- Verify status is "ORDERED"
- Edit the suggestion
=> Without this patch the dropdown list does not have
   "Ordered", and if you save you lost the status
=> With this patch applied the dropdown list has "Ordered"
   preselected. You can save and preserve the status.

Signed-off-by: Holly Cooper <hc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/suggestion/suggestion.tt   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index c293a57ba3..02321e8615 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -343,6 +343,12 @@
                             <option value="REJECTED">Rejected</option>
                         [% END %]
 
+                        [% IF ( statusselected_ORDERED ) %]
+                            <option value="ORDERED" selected="selected">Ordered</option>
+                        [% ELSE %]
+                            <option value="ORDERED">Ordered</option>
+                        [% END %]
+
                         [% FOREACH s IN SuggestionStatuses %]
                             [% IF s.authorised_value == suggestion.STATUS %]
                                 <option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option>
@@ -681,6 +687,12 @@
                                <option value="REJECTED">Rejected</option>
                            [% END %]
 
+                           [% IF ( statusselected_ORDERED ) %]
+                               <option value="ORDERED" selected="selected">Ordered</option>
+                           [% ELSE %]
+                               <option value="ORDERED">Ordered</option>
+                           [% END %]
+
                            [% FOREACH s IN SuggestionStatuses %]
                                <option value="[% s.authorised_value | html %]">[% s.lib | html %]</option>
                            [% END %]
@@ -841,6 +853,12 @@
                                   <option value="REJECTED">Rejected</option>
                               [% END %]
 
+                               [% IF ( statusselected_ORDERED ) %]
+                                   <option value="ORDERED" selected="selected">Ordered</option>
+                               [% ELSE %]
+                                   <option value="ORDERED">Ordered</option>
+                               [% END %]
+
                               [% FOREACH s IN SuggestionStatuses %]
                                   [% IF s.authorised_value == selected_status %]
                                       <option value="[% s.authorised_value | html %]" selected="selected">[% s.lib | html %]</option>
-- 
2.39.5