From ffbaee5afa37d285af62da22940602e11bd0be03 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Mon, 6 Jun 2022 21:02:25 +0000 Subject: [PATCH] Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 972330bc9e13e40564885bcf0ef1723abcc51772) Signed-off-by: Lucas Gass --- admin/columns_settings.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 15f53114ee..85677e5864 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -665,7 +665,9 @@ modules: - columnname: location - - columnname: library + columnname: home_library + - + columnname: holding_library - columnname: staff_note - -- 2.39.5