From fff658823169af9bbefc8f17a75e04fef237c37a Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Mon, 20 Feb 2023 10:26:29 +0200 Subject: [PATCH] Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b5f8c526577714e964b7a081b30b0b482f7f3cc5) Signed-off-by: Matt Blenkinsop --- members/printslip.pl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/members/printslip.pl b/members/printslip.pl index 368d84cc7f..7971f83c67 100755 --- a/members/printslip.pl +++ b/members/printslip.pl @@ -71,9 +71,7 @@ if ( $print eq 'checkinslip' ) { my $checkinslip_branch = $session->param('branch') ? $session->param('branch') : $branch; # get today's checkins - my @issue_ids = $patron->old_checkouts->search( { branchcode => $checkinslip_branch } ) - ->filter_by_todays_checkins->get_column('issue_id'); - + my @issue_ids = $patron->old_checkouts->filter_by_todays_checkins->get_column('issue_id'); my %loops = ( old_issues => \@issue_ids, ); -- 2.39.5