]> git.koha-community.org Git - koha.git/commit
Bug 27308: Skip blank lines when inserting new
authorNick Clemens <nick@bywatersolutions.com>
Thu, 24 Dec 2020 13:35:28 +0000 (13:35 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Mon, 1 Feb 2021 17:39:13 +0000 (18:39 +0100)
commit6736f5254cca279e5b0b4538d76df27a4fcb2c3d
tree53c9949d6af2283ab3a4d4f1bba7a731d652dedb
parent8e02e6010ac56a3eaed28a08f60f5f451bd4db4f
Bug 27308: Skip blank lines when inserting new

The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record.

To test:
1 - Create a macro like
    new 690=‡aLOCAL SUBJECT
2 - Insert a blank line into your record somewhere before where the 690 should be inserted
3 - Run the macro
4 - Line is inserted before the blank line
5 - Apply patch
6 - Reload (ensure cache is cleared and JS files are reloaded)
7 - Remove the previously created field, but leave the blank
8 - Run the macro
9 - Field is created at correct position

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 27308: (QA follow-up) Remove commented line

I don't think we need to keep the original line as a comment.. this
patch simply cleans it up.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 3b0f86b53173d30da5dbb42710a7c9bf9edaa3bb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit d27b1018a96667c6fce8fc746e968e9a206858a0)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 79618eb5a654dc3c01119372e8e7fbc0fd3c7340)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-editor.js