From 681ac15c08b54e894b85d59548fa09e17399ce48 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Mon, 8 Feb 2021 16:11:04 +0200 Subject: [PATCH] Bug 27655: Add barcode "columnname" to "column_settings.yml" Preferences of the "Holds to pull" table missing the "Barcode" column. This patch appends that column name to the "column_settings.yml" in correct order. This also led to checked out columns in this settings page that were not those which were hidden when the table displayed (i.e. columns were shifted). To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open the collapsed "Circulation" list, go to the "Holds" page and find preferences of the "Holds to pull" table there. 3) Check that the "Barcodes" column is missing from it. 4) Mark the last few columns for not to be displayed (for example, three) and save the preferences. Remember the column names you checked out. 5) Open the circulations section, then open "Holds to pull" report when you have there some elements displayed, you should notice that hidden columns shifted by one, as well if you press "gear" icon to quickly enable/disable the columns, you will see those unchecked in list last three will be not those you marked out. 6) Apply the patch. 7) Reload the "table settings" page, check that the "Barcodes" column is present. 8) Check that on the "Circulation -> Holds to Pull" page all columns hidden accordingly and properly (as explained in step 5. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 175a1eddd1efdf70a60b5fb0fb8dc52a9211c65f) Signed-off-by: Fridolin Somers (cherry picked from commit a0fb677b554acd0ec6972c7da5bd3752ae7b049b) Signed-off-by: Andrew Fuerste-Henry --- admin/columns_settings.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 9923463df9..6d7e7d5916 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -1081,6 +1081,8 @@ modules: columnname: title - columnname: libraries + - + columnname: barcodes - columnname: call_numbers - -- 2.39.5