]> git.koha-community.org Git - koha.git/commit
Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules
authorVictor Grousset/tuxayo <victor@tuxayo.net>
Thu, 23 Jan 2020 14:55:18 +0000 (15:55 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 18 Mar 2020 21:47:56 +0000 (21:47 +0000)
commit43798cc1f42338f247fdc0b77b017a511e839e60
tree3c67788797c1285b5b0cb46272a908efe3bbceb3
parent9e46c1c89af1176c3996e69e0a2a841803e0206c
Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules

== Test plan ==
- work with SCSS (just recompile it if you never did)
  - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS
- now you have a node_modules directory
- prove -r t/00-valid-xml.t
- it should fail on files in node_modules
- apply this patch
- prove -r t/00-valid-xml.t
- it should work
- sabotage a legitimate XML file, like etc/SIPconfig.xml
- prove -r t/00-valid-xml.t
- it should fail, good the test is still useful
- undo the sabotage

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 088a610682f1a1be3fd05b64c5080faa0ff7cfd7)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
t/00-valid-xml.t