]> git.koha-community.org Git - koha.git/commit
Bug 20783: Use iframe to embed Youtube videos
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 12 May 2020 10:54:50 +0000 (12:54 +0200)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 18 Oct 2020 15:31:50 +0000 (17:31 +0200)
commit5f71151488a554ca02a1c25c209bcbdf995159b5
tree7bad8b0c1f788bbc415fcd4eb3468c12990bd923
parent1870cbd31d5ccaf6501e0a7d3a7898c6ced6758a
Bug 20783: Use iframe to embed Youtube videos

WWW::YouTube::Download is broken and not reliable.
Other alternative was to use HTML::Video::Embed but not updated since
years.

The best alternative seems to follow youtube advise and use an iframe
https://developers.google.com/youtube/iframe_api_reference

Test plan:
Put youtube video in 856$u (using different url formats, youtu.be,
youtube.com/embed, etc.)
Enable HTML5MediaEnabled and HTML5MediaYouTube and confirm that the
youtube videos are correctly embeded.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
(cherry picked from commit 524fe12e4419654d98af485d7dbbc9eedac28141)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/HTML5Media.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt