From 2dda5cd17fdcc0368a96c10b556d203f8d91d97a Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 11 Jun 2020 11:37:26 +0100 Subject: [PATCH] Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit f88d56f689e514b47930d617049358fdf9b68608) Signed-off-by: Lucas Gass (cherry picked from commit cc75932f3eca746e8e2c08125306a94952b8a87d) Signed-off-by: Aleisha Amohia (cherry picked from commit 3bb05edced373175227d4c2fb704db75519ae78c) Signed-off-by: Victor Grousset/tuxayo --- .../opac-tmpl/bootstrap/css/src/opac.scss | 6 ++++- .../bootstrap/en/includes/opac-facets.inc | 26 +++++++++---------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 160db0860e..a894b1d558 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -2176,7 +2176,7 @@ input { margin: 0; } - h4 { + h2 { font-size: 90%; margin: 0 0 .6em 0; text-align: center; @@ -2191,6 +2191,10 @@ input { } } + h3 { + font-size: 80%; + } + li { font-size: 90%; font-weight: bold; diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc index d92bf4a105..ab01a7ed81 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc @@ -3,9 +3,9 @@ [% USE Languages %] [% IF ( opacfacets && facets_loop && total ) %]
-

Refine your search

+

Refine your search

    -
  • Availability
    +

  • Availability

    • [% IF ( available ) %] @@ -21,19 +21,19 @@ [% FOREACH facets_loo IN facets_loop %] [% IF facets_loo.facets.size > 0 %]
    • - [% IF facets_loo.type_label_Authors %]
      Authors
      [% END %] - [% IF facets_loo.type_label_Titles %]
      Titles
      [% END %] - [% IF facets_loo.type_label_Topics %]
      Topics
      [% END %] - [% IF facets_loo.type_label_Places %]
      Places
      [% END %] - [% IF facets_loo.type_label_Series %]
      Series
      [% END %] - [% IF facets_loo.type_label_ItemTypes %]
      Item types
      [% END %] - [% IF facets_loo.type_label_CollectionCodes %]
      Collections
      [% END %] - [% IF facets_loo.type_label_Language %]
      Languages
      [% END %] + [% IF facets_loo.type_label_Authors %]

      Authors

      [% END %] + [% IF facets_loo.type_label_Titles %]

      Titles

      [% END %] + [% IF facets_loo.type_label_Topics %]

      Topics

      [% END %] + [% IF facets_loo.type_label_Places %]

      Places

      [% END %] + [% IF facets_loo.type_label_Series %]

      Series

      [% END %] + [% IF facets_loo.type_label_ItemTypes %]

      Item types

      [% END %] + [% IF facets_loo.type_label_CollectionCodes %]

      Collections

      [% END %] + [% IF facets_loo.type_label_Language %]

      Languages

      [% END %] [% UNLESS singleBranchMode %] - [% IF ( facets_loo.type_label_HomeLibrary ) %]
      Home libraries
      [% END %] - [% IF ( facets_loo.type_label_HoldingLibrary ) %]
      Holding libraries
      [% END %] + [% IF ( facets_loo.type_label_HomeLibrary ) %]

      Home libraries

      [% END %] + [% IF ( facets_loo.type_label_HoldingLibrary ) %]

      Holding libraries

      [% END %] [% END %] - [% IF facets_loo.type_label_Location %]
      Locations
      [% END %] + [% IF facets_loo.type_label_Location %]

      Locations

      [% END %]
        [% SET url = "/cgi-bin/koha/opac-search.pl?" _ query_cgi _ limit_cgi %] [% IF ( sort_by ) %] -- 2.39.5