From 57403b87cdb1b68b30afe784e5c1e52cd12ec27d Mon Sep 17 00:00:00 2001
From: Owen <oleonard@myacpl.org>
Date: Thu, 28 Oct 2021 15:45:21 +0000
Subject: [PATCH] Bug 29328: Add missing list parameter to reports parameter
 menu

This patch adds an option to insert "list" as a runtime parameter in SQL
reports (As added by Bug 27380).

To test, apply the patch and go to Reports -> Create from SQL.

- Click the "Insert runtime parameter" button and select
  "List."
- Customize the parameter label if you wish and click "Insert
  parameter."
- The parameter should be inserted like this:

  <<List of values|list>>

- Use it to create a valid SQL report, for example:

  SELECT * FROM borrowers WHERE categorycode IN  <<List of values|list>>
  LIMIT 10

- Confirm that upon running the report you are shown a textarea. Enter
  two or more values in the textarea, each on a separate line.
- Confirm that the report runs correctly. The SQL above would show you
  this when you click "Show SQL code":

  SELECT * FROM borrowers WHERE categorycode IN  ('A','S')  LIMIT 10

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../prog/en/modules/reports/guided_reports_start.tt         | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index 0cde4b3843..d4e320d12a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -1512,6 +1512,11 @@
                     $("#paramLabel").val( _("Patron category") );
                     $("#param_category").val("categorycode");
                     break;
+                case "insertList":
+                    modalTitle.text( _("Insert list parameter") );
+                    $("#paramLabel").val( _("List of values") );
+                    $("#param_category").val("list");
+                    break;
                 case "insertText":
                     modalTitle.text( _("Insert text parameter") );
                     $("#paramLabel").val( _("Text") );
@@ -2236,6 +2241,7 @@
             <li><a href="#" class="insertParam" id="insertDate">Date</a></li>
             <li><a href="#" class="insertParam" id="insertItemtypes">Item types</a></li>
             <li><a href="#" class="insertParam" id="insertBranches">Libraries</a></li>
+            <li><a href="#" class="insertParam" id="insertList">List</a></li>
             <li><a href="#" class="insertParam" id="insertCategorycode">Patron categories</a></li>
             <li><a href="#" class="insertParam" id="insertText">Text field</a></li>
         </ul>
-- 
2.39.5