From ff292199a5f43584adc4726c10df979db4ef8a03 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Fri, 1 Dec 2023 15:08:48 +0200 Subject: [PATCH] Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer (cherry picked from commit ca27b5adb03eae30e425f096ef635a8fe4ce3b3f) Signed-off-by: Fridolin Somers --- admin/smart-rules.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl index b1c7868184..fd20484c9f 100755 --- a/admin/smart-rules.pl +++ b/admin/smart-rules.pl @@ -327,6 +327,9 @@ elsif ( $op eq 'add' ) { auto_renew => $auto_renew, no_auto_renewal_after => $no_auto_renewal_after, no_auto_renewal_after_hard_limit => $no_auto_renewal_after_hard_limit, + reservesallowed => $reservesallowed, + holds_per_record => $holds_per_record, + holds_per_day => $holds_per_day, onshelfholds => $onshelfholds, opacitemholds => $opacitemholds, overduefinescap => $overduefinescap, -- 2.39.5