Bug 34032: Set new expirationdate if waiting status is reverted
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Wed, 21 Jun 2023 11:36:08 +0000 (14:36 +0300)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 29 Apr 2024 07:35:37 +0000 (09:35 +0200)
commit03efe5ba76c80b9ed64de58d292155053a80c012
treefa176c2857c3587e11ab958b1fbee78e216e14d5
parent875809d66d4e6bde5385d88aad9f05f472a67b6b
Bug 34032: Set new expirationdate if waiting status is reverted

When one reverts holds waiting status holds expiration
date is not set even if DefaultHoldExpirationdate
syspref is enabled. This patch adds new param
hold_reverted to be used when RevertWaitingStatus is
used to determine if expiration date should be set again.

To test:
1) Make sure you have DefaultHoldExpirationdate syspref enabled.
2) Find hold with status "Waiting".
3) Revert waiting status.
=> Note that hold has no expiration date set.
4) Apply this patch.
5) Repeat steps 2 and 3.
=> Expiration date should now be set based on reserve
date.

Also prove t/db_dependent/Hold.t.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Esther <esther@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4/Reserves.pm
Koha/Hold.pm
t/db_dependent/Hold.t