Bug 29754: (QA follow-up) Minor tests tweaks
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 7 Feb 2022 11:58:43 +0000 (08:58 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 21 Feb 2022 16:52:54 +0000 (16:52 +0000)
commit190c925997f75c013627317045dbd9030ca9075a
tree1d1a393cc22737e945288ecac3ce8d7429d9bc64
parentc5084b48f038b5c189614c65ab0741d10f1a2f4a
Bug 29754: (QA follow-up) Minor tests tweaks

This patch does two things:

- Wraps the new SIP tests in a single transaction. We do that to avoid
  sub-test interference, specially when test files get big. The provided
  tests are correct and don't require previous tests data.
- Migrated from the introduced 'diag' calls to 'note', as I just learned
  they are the same, but 'note' is only displayed when in verbose mode.
  Which is great to avoid unnecessary noise in Jenkins.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0f0bfcad7c1cfd2ce9baff8ed3cd6208bfe52b04)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
t/db_dependent/Koha/Patron.t
t/db_dependent/SIP/Patron.t