Bug 21270: "Not finding what you're looking for" displaying uselessly
authorBlou <philippe.blouin@inlibro.com>
Fri, 24 Aug 2018 15:46:54 +0000 (11:46 -0400)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 13 Dec 2019 15:30:17 +0000 (15:30 +0000)
commit1cce77631aea7b3e24aeed8daa649001d4b56b10
tree919745b6f6e52b40e37aedc6283399f388aa347b
parent219c2de66adea29ff26b9a580c039a1d59fd8864
Bug 21270: "Not finding what you're looking for" displaying uselessly

When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled.

Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user.

Just taunting them...

TEST:
0) Set IllModule to true, AnonSuggestions to false.
1) Without login, just to an OPAC search.  At the bottom will be a nice string laughing at your failed search
2) Apply the patch.
3) Problem at 1) is fixed.
4) Login to validate that ILL link now appear.
5) Modify combination of IllModule and AnonSuggestions to validate links appearing.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt