]> git.koha-community.org Git - koha.git/commit
Bug 20854: (QA follow-up) Improve readability
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 16 Mar 2021 19:50:34 +0000 (16:50 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 24 May 2021 15:44:22 +0000 (15:44 +0000)
commit1fdfc367fb52392d1d97888cc35c2a3eabd0c294
tree38e89474e27ce2c9836565dfe55bc30ccd832d7f
parent2cccd4bfeee3c9e2987fe25c5320da99a8dc78cc
Bug 20854: (QA follow-up) Improve readability

The logout_cas method does too little tasks. In this case, I consider we
should not split it into a separate method. As the CAS implementation
lacked tests, it made sense to do it like this, so it is testable. But
now we have higher-level tests for logout_cas, we can bake the behavior
inside of it, and it is testable.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7c3c066714ce568e507348f1e3a9a6b7db0c4815)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 9b3538678ee758632a5d945e3c8d3e5870465a67)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
C4/Auth_with_cas.pm