Bug 27071: (follow-up) Get rid of loop
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 22 Feb 2021 12:27:12 +0000 (09:27 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 1 Mar 2021 08:56:19 +0000 (09:56 +0100)
commit3495a7e9af70706e3ebba60e3fac7aa3845d1d78
tree38afa6fdbe4e85fb1cabb455a048b549e227cf08
parent3e8e15cc64a8b09fc9575af4b9fcbae437293715
Bug 27071: (follow-up) Get rid of loop

This patch gets rid of a loop on the librarary's groups siblings, and
acknowledges ->get_hold_libraries returns a proper Koha::Libraries
iterator that can be chained with a new query on the passed branchcode.
This way we only fetch  a count from the DB and no loop needs to take
place on the code.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Libraries.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Library.pm