]> git.koha-community.org Git - koha.git/commit
Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 28 May 2018 14:24:43 +0000 (11:24 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 5 Jun 2018 09:23:21 +0000 (10:23 +0100)
commit359cbe9c5cae9165b22aa21e294695b932216694
treed55f6f6c1945d2eabcbd628966b68fea7be62fd7
parent721f05371e2877e83e5f2adb6b523c5086333f4b
Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem

On bug 19943:
 -        elsif ($biblioitem->{'notforloan'} == 1){
 +        elsif ($biblioitem->notforloan == 1){

The biblioitems table does not contain a notforloan column, this comes
from the item type.

This bug only appears when item type is defined at biblio level
(item-level_itypes=0)

Test plan:
Set item-level_itypes = biblio
Check an item out

Without this patch it explodes with
"The method notforloan is not covered by tests!"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I reproduced the error condition and verified the tests failed without
this patch. After this patch is applied, tests pass and checkout
succeeds.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Circulation.pm