]> git.koha-community.org Git - koha.git/commit
Bug 26604: "Generate next" button gives error on serials-collection.pl
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 2 Oct 2020 16:11:48 +0000 (12:11 -0400)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 17 Nov 2020 03:45:07 +0000 (16:45 +1300)
commit35cafa56f424a81ae98113d4f1db376987787849
treef2de3aacb882486369e66bf8378e499912360f00
parent3d1d81014db886e35a18ee546c9a9e2dfb011ce9
Bug 26604: "Generate next" button gives error on serials-collection.pl

In serials-collection.pl, the line

$frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});

causes the error

Can't use string ("13") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Serials.pm line 2198.

This function call makes no sense, that subroutine always returns a list and doesn't take any parameters. I think it was meant to be GetSubscriptionFrequency which is in fact already called a few lines down.

Signed-off-by: kelly mcelligott <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
JD

Test plan:
1. Create a new subscription
  * When there is an irregular issue: Skip issue number
  * Select a frequency (not irregular)
  * Test prediction pattern and mark some "not published" (to fill the subscription.irregular DB field
2. Receive a first serial (mark it arrived, an "expected" one is created)
3. Claim the expected one
=> You have 1 arrived and 1 claimed.
It's the only way to not have an expected one and hit the else block in serials/serials-collection.pl
4. Generate next => boom

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
serials/serials-collection.pl