]> git.koha-community.org Git - koha.git/commit
Bug 27548: "use of uninitialized value" warning on branchoverdues.pl
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 25 Jan 2021 15:35:18 +0000 (17:35 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 5 Feb 2021 16:12:31 +0000 (17:12 +0100)
commit44d1675aaf1e602e12ccd669dad50a299654f89d
tree5e0f37e747028b218e8e107f1bccea803674315c
parentbc86c63c6b98d50908be039f9c45336d6b3471bf
Bug 27548: "use of uninitialized value" warning on branchoverdues.pl

On the beginning we have empty "location" parameter for this form,
but that not taken into account in comparison and undef warning emitted:
"Use of uninitialized value $location in string eq at
/usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl

Fixed by adding pre-check for $location.

To reproduce:
    1) Head over to "Circulation ->Overdues with fines" page. Check
       intranet-error.log where there will be many warnings
       "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72".
    2) Apply the patch, refresh the "Overdues with fines" page.
    3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit c3d22687568640930bad9ffbb426033423e7efe9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
circ/branchoverdues.pl