Bug 24892: Resolve uninitialized warns from opac-memberentry
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 18 Mar 2020 13:54:52 +0000 (13:54 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Fri, 3 Apr 2020 21:13:54 +0000 (21:13 +0000)
commit44d91396128a38a29b21f643f2e6439383a03e5c
treeffcbe73f6b089eec27b073c889f0789e19945069
parentcda91af335a163b9e1d12c2aac57ec46b24ddea4
Bug 24892: Resolve uninitialized warns from opac-memberentry

Especially line 500 (current master).

Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.

Simple fix, not completely trivial due to adding xor ;)

Test plan:
Do not apply, update from opac memberentry. Check warns in log.
Apply patch, update again. Less warns?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
opac/opac-memberentry.pl