]> git.koha-community.org Git - koha.git/commit
Bug 25882: Remove phr indicator from limits when processing
authorNick Clemens <nick@bywatersolutions.com>
Fri, 26 Jun 2020 13:19:47 +0000 (13:19 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 17 Aug 2020 14:25:26 +0000 (14:25 +0000)
commit455acf686d7e74aa5582bc700e856935e852573a
tree5abb175647444c11a18eec020b11be568ac6dab7
parentdbc7f861d4695a8538602b01d0e9402dff01ff02
Bug 25882: Remove phr indicator from limits when processing

We assume all limits from advanced search to be a phrase and quote them
when doing this we should remove the phrase marker to avoid doulbe quoting

To test:
 1 - Have koha using ES
 2 - Go to advanced search
 3 - Limit by a single itemtype that exists
 4 - Get some results
 5 - Limit by a different itemtype that exists
 6 - Get some results
 7 - Limit by both itemtypes
 8 - Get only the results for the second itemtype
 9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")
13 - Apply patches
14 - Restart all the things
15 - Repeat search for both itemtypes
16 - Note results now include both types

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a2b2426de842ac86048cbf71e3760b6483fc0b3c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm