]> git.koha-community.org Git - koha.git/commit
Bug 11281: Printing holds awaiting pickup prints both tabs
authorOwen Leonard <oleonard@myacpl.org>
Fri, 22 Nov 2019 19:29:53 +0000 (19:29 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 9 Mar 2020 19:57:24 +0000 (19:57 +0000)
commit5073a05caafb3598b40384409a02e9885e43c6ab
tree64df1bf89424497221af00b21a85d676bdf86225
parentcf8354aaa7cd3da8a8c51f6d84363db30e92f298
Bug 11281: Printing holds awaiting pickup prints both tabs

This patch adds columns configuration to the holds awaiting pickup
tables. Doing so helps solve the printing issue by adding a "Print"
option to both tables. Using this print function will provide a
printable version of only that table.

To test you should have multiple holds in your system which are marked
"waiting" and some which have been waiting longer than the value
specified in the ReservesMaxPickUpDelay system preference.

Apply the patch and go to Circulation -> Holds awaiting pickup.

 - On both the "Holds waiting" and "Holds waiting over..." tabs the
   DataTable should display correctly and all the controls should work,
   including the columns settings and the choices in the export menu.
 - Confirm that the "Print" action creates a printable version of only
   the table you are viewing.

 - Go to Administration -> Columns settings -> Circulation.
 - Change some visibility controls for the tables under the
   "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm
   that these changes are reflected in the "Holds waiting" interface.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 30145385916935464ccbc52a1a13755464863ef9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
admin/columns_settings.yml
koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt