]> git.koha-community.org Git - koha.git/commit
Bug 25724: Do not call ModReserveStatus when completing transfer
authorNick Clemens <nick@bywatersolutions.com>
Fri, 12 Jun 2020 10:51:36 +0000 (10:51 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 31 Jul 2020 20:46:57 +0000 (20:46 +0000)
commit51cd56ddb37dbb3c92105d948b8a83b98ad6bcfb
treed6b593dae805f298e2743e638e38033dcf408b65
parentbc1e7669bd2b1abccba7b1975b66adac0de550d2
Bug 25724: Do not call ModReserveStatus when completing transfer

I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL
That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due
to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0

Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status.

ModReserveStatus also calls CartToShelf regardless of what happens here.

To test:
1 - Set  UpdateItemLocationOnCheckin  to:
    _ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
7 - Apply patch
8 - Repeat
9 - Item is in CART location after completion of transfer

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Jason Robb <jrobb@sekls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit e025cd76437b212746717ad54b5da22e410bbe8f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm