]> git.koha-community.org Git - koha.git/commit
Bug 10110: Problems with diacritics in saved SQL reports
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 25 Apr 2013 11:54:31 +0000 (13:54 +0200)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Sat, 27 Apr 2013 11:15:46 +0000 (07:15 -0400)
commit79a9b11a7937bab8397ec526114b0c072b253b17
treeb477d0ce1aa76f9431198b427114638eca39408b
parentc48be8b905efa9ba4e472dbcbcea6ee15a92e075
Bug 10110: Problems with diacritics in saved SQL reports

Adds decoding for cgi params (for completeness).
Apparently, the NAME attribute of DBI statement handle has a UTF8 bug.
Fixing this by decoding the returned column names.
Did this in a shared routine.

http://bugs.koha-community.org/show_bug.cgi?id=10110
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Copying test plan from bug report:

Example SQL:
select
branchname as "Bibliothek (üöä)",
branchname "Bibiothek (üäa)",
branchname
from branches where branchcode = <<Bibliothekskürzel|branches>>

1) Create report with given example SQL or your own including
   some diacritics in the columnnames
2) Save the report and run it
3) Verify column names are broken before patch, but fixed after..

All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit d050e557f4ac3d7a8b1a0fa573a8ca00aa0862a9)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
reports/guided_reports.pl