]> git.koha-community.org Git - koha.git/commit
Bug 25070: Centralize member-alt-address-style
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Apr 2020 11:53:17 +0000 (13:53 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 17 Jun 2020 23:33:56 +0000 (23:33 +0000)
commit7d00ec3bb717b1d1e86862ff270e3de800bd5d48
tree5b4463d0943fd29a942f911e7a081dae19c31a2a
parent9526d6efea15c95d3d0d1195f3ba72b7f7f7c7d1
Bug 25070: Centralize member-alt-address-style

There are 5 includes files per value of AddressFormat (us, de, fr).
The code is duplicated for each language, the only thing that changes is the order.

Wwith this patchset we are going to refactore them to avoid further regressions.

The idea is to remove all code that is duplicated and remove the need of
having 5*3 files. We are going to limit them to 5 files, 1 per use.

Note that we could go even further, for instance
member-display-alt-address-style and member-display-address-style are
quite identical.

Test plan (for the whole patchset):
- Create a patron with all the address, contact and alternate info filled
- Edit them and save
- Look at the patron's info (top left) in the patron module, and the
patron detail view.
- Play with the different values of AddressFormat
The order and the info must be displayed identically before and after
this patchset. No change is expected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fdca61a7455bb5bdca32a718a43a7e2688bcea46)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-fr.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt