Bug 35536: Add RemovePlugins calls in plugin unit tests
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 14 Dec 2023 08:02:01 +0000 (08:02 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 22 Mar 2024 11:26:39 +0000 (12:26 +0100)
commit9d73d40ea38ac7a1662f5058c22c57b2b7438e40
treeb3e39a27770cf16f26bb47f5d7c518c7004940b3
parent950c1e63f864ea1b1a194d685b2d8bd7ae83190d
Bug 35536: Add RemovePlugins calls in plugin unit tests

[1] Replace Methods->delete by RemovePlugins.
    git grep -l "Plugins::Methods->delete" | xargs sed -i -e's/Plugins::Methods->delete/Plugins->RemovePlugins/g'
[2] Replace $schema->resultset('PluginData')->delete by destructive parameter.
[3] Add RemovePlugins too in Handler->delete too. Note that this call
    might be better off with disable? Added a comment.

Test plan:
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
12 files changed:
Koha/Plugins/Handler.pm
t/db_dependent/Koha/Plugins/Account_hooks.t
t/db_dependent/Koha/Plugins/BackgroundJob.t
t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t
t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t
t/db_dependent/Koha/Plugins/Circulation_hooks.t
t/db_dependent/Koha/Plugins/Holds_hooks.t
t/db_dependent/Koha/Plugins/Patron.t
t/db_dependent/Koha/Plugins/Plugins.t
t/db_dependent/Koha/Plugins/Recall_hooks.t
t/db_dependent/Koha/Plugins/authority_hooks.t
t/db_dependent/Koha/REST/Plugin/PluginRoutes.t