]> git.koha-community.org Git - koha.git/commit
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
authorKatrin Fischer <katrin.fischer.83@web.de>
Sun, 20 May 2018 02:23:47 +0000 (04:23 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 25 Jun 2018 17:35:32 +0000 (18:35 +0100)
commitb3d1a5bfecbfbac4af8335757414def1ee3e2df5
treeb07da47d3feeb3cfcca8b78871ec4511c0f6338d
parent279e328cdda0e3e17c244a39b933ce898bc5bee2
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions

If a user doesn't have circulate_remaining permissions, but has borrowers:
- checkouts tab is hidden
- details tab is visible
- holds tab on details is visible, but results in an error

The problem is that the svc/holds script requires circulate_remaining_permissions.

To test:
- Create 2 staff users with and without circulate_remaining_permissions
  Both need borrowers permission
- Go to the details tab in a patron's account who has holds
- Verify that you get a datatables error for the staff patron without
  circulate_remaining_permissions
- Apply patch
- Verify that now the holds tab is no longer displayed for this patron

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt