]> git.koha-community.org Git - koha.git/commit
Bug 24788: Remove autoloaded column accessors in Koha::Object->store
authorDavid Gustafsson <david.gustafsson@ub.gu.se>
Tue, 3 Mar 2020 13:32:31 +0000 (14:32 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 9 Apr 2020 20:39:59 +0000 (20:39 +0000)
commitbcf6cdb6eaa683adcd0cf2c51f229b5f0942ddac
treea6b49e54f7db37153edf28fc141b478eb96e7a22
parent1993e98edf0c272d6d93e18292a5c8b79da4b458
Bug 24788: Remove autoloaded column accessors in Koha::Object->store

Columns are accessed as methods, relying on AUTOLOAD, in
Koha::Object->store. This could be a source of strange bugs
if a column name clashes with an existing method name.

To test:

1) Apply patches for Bug 14957
2) Follow the testing instructions, when saving a new marc rule and
error is thrown.
3) Apply patch
4) Try saving a new rule once again, this should now work

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 508a6ad027b34c2279fbb1ff994152144b38ceb8)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Object.pm