]> git.koha-community.org Git - koha.git/commit
Bug 20120: Prevent writeoffs of more than the amount owed for a fee
authorKyle M Hall <kyle@bywatetsolutions.com>
Fri, 9 Mar 2018 14:20:40 +0000 (09:20 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 11 Jun 2018 08:57:34 +0000 (09:57 +0100)
commitc55ec0f561cc73fc5477e983b7d0d36a550b8b4c
treee163baea0a7aae114ee46fddade5dff88a63b4b7
parent86d608c43959f8b7311ea5f72c93f2262587a623
Bug 20120: Prevent writeoffs of more than the amount owed for a fee

In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit.

Test Plan:
1) Attempt to writeoff a single fee, set the amount input to more than
   the amount of the fee.
2) Note the writeoff makes the fee go negative.
3) Apply this patch
4) Attempt to repeat step 1, you should be unable to write-off an
   amount more than the amount outstanding for the fee!

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
members/pay.pl
members/paycollect.pl