Bug 30035: Fix month name in prediction pattern
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 7 Feb 2022 08:26:12 +0000 (09:26 +0100)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 15 Apr 2022 17:46:41 +0000 (17:46 +0000)
commitc9253082bbbe3bc2529188b0e908053d72b77eff
treeac5106dd5a7356b3ff3e06a083efa255b2300374
parent4a11b47095fa5eb80c4083c603c8ef74743b7968
Bug 30035: Fix month name in prediction pattern

We are using %B to display the month name but it seems that using the
CLDR pattern LLLL would be more appropriated.
https://metacpan.org/pod/DateTime#CLDR-Patterns
%B   - The full month name.
LLLL - The wide stand-alone form for the month.

For instance in Catalan:
https://metacpan.org/pod/DateTime::Locale::ca
%B will display "de gener" when LLLL will be "gener"

Test plan:
Create a new numbering pattern:
Home > Serials > Numbering patterns > New numbering pattern
Numbering formula: {X}
Label: monthname
Add: 1
Every: 1
Set back to: 1
When more than: 999
Formatting: Name of month
And test it at the bottom of the form
Locale: Catalan
The number column should contain "gener", not "de gener"
Test other locales and confirm that the output is correct (no change
expected for English, French and Spanish for instance).

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 93c33c527fdbfad0f46bc26a6b3496cba7d02fbb)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
C4/Serials.pm
t/db_dependent/Serials.t