Bug 36018: $orders->filter_by_active should check quantityreceived
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 21 Feb 2024 15:20:23 +0000 (15:20 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 10 May 2024 14:45:47 +0000 (16:45 +0200)
commitd563baa853e078472f66dd7b18c2bf3fcd2eddd2
tree9f5a93ddb85676a723eb99ab2073b24600508560
parent21c87aeb15e6380d71b41f8c5e8ff28df74b3edd
Bug 36018: $orders->filter_by_active should check quantityreceived

An active order that has no items to receive any more is actually
not very active anymore :)

Test plan:
Run t/db_dependent/Koha/Acquisition/Orders.t
Enable OPACAcquisitionDetails.
Add order on basket for new biblio. Check that opac-detail does not
yet count the item as on order (since status is still new).
Close basket. Check opac-detail again. Should count it now.
Reopen basket. Cancel line. Check opac-detail again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/Acquisition/Orders.pm
t/db_dependent/Koha/Acquisition/Orders.t