Bug 13958: Use SuspensionsCalendar syspref for more granularity
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 May 2019 15:10:57 +0000 (12:10 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 10 Dec 2019 22:58:58 +0000 (22:58 +0000)
commitee600debe401078e0a18afced0add198ba98fe09
tree6dcd45f2ffb6cc2c451bc731cecf34c0522f2888
parentb0c17be0f4a8cbd58f8cb17d53591be5363ac230
Bug 13958: Use SuspensionsCalendar syspref for more granularity

This patch makes the calculation of suspension expiration configuration
detached from the finesCalendar syspref. This way libraries have more
flexibility when setting circ rules.

I wrote this path as a bugfix, because the recent change pushed by bug 19204
changed this behavior and libraries have been complaining since they got
upgraded.

It is a minor change, just adding the new syspref, and replacing the
single place in which it is used for debarment calculation for the new
one.

The tests are updated similarly, just adding the new mocked syspref as
it was with the old one.

To test:
- Apply this patches
- updatedatabase
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit f59a34a9ca80c54159b976c6fb658a85dc3eef79)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm
t/db_dependent/Circulation.t