]> git.koha-community.org Git - koha.git/commit
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Fri, 19 Feb 2021 07:49:51 +0000 (09:49 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 12 Mar 2021 08:05:18 +0000 (09:05 +0100)
commitf0663f8a48b9bec6b65a68764a2376f73698e5b2
treeb02fb3a573643cd9cef327ee62364237328f75ff
parent8dce8789a253457d9e0c8287bbdbd418dae1af44
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable

The code is much more understandable now because with $biblio2 and
$biblionumber1 variables use to point to the same biblio one might
have thought $biblionumber1 points to $biblio1 which in this case is
not true. Let's just drop the extra variable because the object
notation of accessing is just as simple.

To test:
 1) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t => passes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit da81064b8b8b8efc6950084231b1943f25f7820d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t