]> git.koha-community.org Git - koha.git/commit
Bug 28524: Escape 'rank' in cat_issues_top.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 16 Jun 2021 12:51:08 +0000 (14:51 +0200)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Thu, 22 Jul 2021 13:22:27 +0000 (15:22 +0200)
commitf27cfd734b78c947e60e5603f19055a9204b0ba3
tree36f452347a289ab551c03360a5cd46268e870498
parent369c720beb56925871281b4edfd16f81410772cf
Bug 28524: Escape 'rank' in cat_issues_top.pl

It's a MySQL 8 keyword

Test plan:
Turn off strict_sql_modes (there are other problems in this script)
Hit Home Reports > Most-circulated items
Submit the form

Without this patch you got:
  You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use
  near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM,
  ccode as CCODE, loca' at line 1

With this patch applied you see the report result view

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit ea214856d112e262f2ab7df223b6ab9bf673ee67)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
reports/cat_issues_top.pl