Bug 25634: Warn if koha-shell returns non-zero in koha-foreach
authorDavid Cook <dcook@prosentient.com.au>
Mon, 1 Jun 2020 23:53:06 +0000 (09:53 +1000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Thu, 18 Jun 2020 16:50:58 +0000 (18:50 +0200)
commitf93bdd8c620a70f06bc81b40174a5f7ebab8752a
tree0dda533689b25011ed2b55d5ac6bc0c1a5460ced
parent9f71cc7c46f1f094bd39f22d9be43064440258b1
Bug 25634: Warn if koha-shell returns non-zero in koha-foreach

By putting koha-shell in an if statement, "set -e" will no longer
cause the entire koha-foreach program to exit, if koha-shell
returns a non-zero status.

If a non-zero status is returned, we warn on it, and the caller
of koha-foreach can interpret that command visually.

To Test:
1) Write a shell script that says "Hello" and then exits with a 1
status
2) Run koha-foreach against that shell script with multiple instances
available to koha-foreach
3) Before the patch, koha-foreach will die after the first "Hello"
4) After the patch, koha-foreach will continue, through all the
instances, and report which instances returned non-zero statuses
by which command.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 4c548cb08f3f3013778da71d47745f48b6adffd8)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 79663817ec58b23525f08862210ad4c29fe89d33)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit 1e982eafd1748f659438d2dd43c4f87a301459a5)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
debian/scripts/koha-foreach