]> git.koha-community.org Git - koha.git/log
koha.git
14 years agoDraft script to 'convert' HTML:Toolkit syntax in templates to Template::Toolkit....
Will Stokes [Mon, 23 Aug 2010 04:04:28 +0000 (16:04 +1200)]
Draft script to 'convert' HTML:Toolkit syntax in templates to Template::Toolkit. Will need human to go through most if not all templates (basically those with a loop) and fix up. Makes no attempt to fix horrendous formatting. Branch: html-template-to-template-toolkit

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
14 years agoBug 5046 - fix the zebra authorities configuration
Robin Sheat [Wed, 21 Jul 2010 02:58:37 +0000 (14:58 +1200)]
Bug 5046 - fix the zebra authorities configuration

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMerge branch 'origin/new/bug3756_reenable_local_sysprefs' of git://git.tamil.fr/git...
Galen Charlton [Wed, 28 Jul 2010 00:32:28 +0000 (20:32 -0400)]
Merge branch 'origin/new/bug3756_reenable_local_sysprefs' of git://git.tamil.fr/git/koha into to-push

* 'origin/new/bug3756_reenable_local_sysprefs' of git://git.tamil.fr/git/koha:
  Bug 3756 Don't display as local AutoSelfCheckID syspref and others

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3756 Don't display as local AutoSelfCheckID syspref and others
Frédéric Demians [Mon, 26 Jul 2010 14:18:37 +0000 (16:18 +0200)]
Bug 3756 Don't display as local AutoSelfCheckID syspref and others

Improve how sysprefs are extracted from .tmpl file in order not to miss
some of them.

14 years agobug 4989: set DB rev to 145
Galen Charlton [Thu, 22 Jul 2010 23:27:44 +0000 (19:27 -0400)]
bug 4989: set DB rev to 145

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug 4989) add index on guarantorid
Nahuel ANGELINETTI [Tue, 13 Jul 2010 08:56:12 +0000 (10:56 +0200)]
(bug 4989) add index on guarantorid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4996 - Untranslatable strings in budget/fund toolbar
Owen Leonard [Tue, 20 Jul 2010 18:37:07 +0000 (14:37 -0400)]
Fix for Bug 4996 - Untranslatable strings in budget/fund toolbar

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix typo in z3950 search in acquisitions
Chris Cormack [Tue, 20 Jul 2010 19:35:38 +0000 (07:35 +1200)]
Fix typo in z3950 search in acquisitions

Signed-off-by: Chris Cormack <chrisc@catalyst.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 5023 Remove unused Serials Modules
Colin Campbell [Tue, 20 Jul 2010 15:57:15 +0000 (16:57 +0100)]
Bug 5023 Remove unused Serials Modules

Modules possibly added in error
Neither is called elsewhere in the system

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFollow-up fix for Bug 5013, "New patron" menu button broken
Owen Leonard [Fri, 16 Jul 2010 15:43:09 +0000 (11:43 -0400)]
Follow-up fix for Bug 5013, "New patron" menu button broken

Menu was working on members-home.pl but not on members.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 5007: fixing the syspref for IntranetBiblioDefaultView
Andrew Chilton [Mon, 19 Jul 2010 04:24:06 +0000 (16:24 +1200)]
bug 5007: fixing the syspref for IntranetBiblioDefaultView

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 5034 - update the maintainer details, correctly
Robin Sheat [Mon, 19 Jul 2010 05:41:05 +0000 (17:41 +1200)]
Bug 5034 - update the maintainer details, correctly

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoCorrecting URL typo in link back to labels home page
Owen Leonard [Fri, 16 Jul 2010 14:44:38 +0000 (10:44 -0400)]
Correcting URL typo in link back to labels home page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 5021 Formatting of undefined serials dates
Colin Campbell [Fri, 16 Jul 2010 11:55:19 +0000 (12:55 +0100)]
Bug 5021 Formatting of undefined serials dates

Routine was checking undefinedness but such dates were
normalized on retrieval to 0000-00-00
Also planned/received date should also be checked

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4999, OPAC error pages have incorrect markup structure
Owen Leonard [Wed, 14 Jul 2010 13:56:39 +0000 (09:56 -0400)]
Fix for Bug 4999, OPAC error pages have incorrect markup structure

No strings have been harmed in the making of this patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMinor markup correction to send Cart form
Owen Leonard [Wed, 14 Jul 2010 19:59:07 +0000 (15:59 -0400)]
Minor markup correction to send Cart form

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMarkup corrections
Owen Leonard [Wed, 14 Jul 2010 17:57:01 +0000 (13:57 -0400)]
Markup corrections

- Changing input "button" to "submit" so that confirmation
  dialog redirects the user as expected
- Changing non-standard message box styles to standard ones

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3756 Difference between original and local sysprefs
Frédéric Demians [Tue, 13 Jul 2010 18:49:25 +0000 (20:49 +0200)]
Bug 3756 Difference between original and local sysprefs

Amend Chris N. patch in order to display local sysprefs as the
difference between DB sysprefs and .pref files sysprefs.

As a side effect, local sysprefs editor displays also deprecated
sysprefs which is a feature from my point of view. For example,
GranularPermissions is displayed as a local syspref because it has been
removed recently from admin.pref but hasn't been yet removed from DB
(could be done later with a DB update).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3756: Adding the ability to have localuse systempreferences
Chris Nighswonger [Mon, 12 Jul 2010 21:18:50 +0000 (09:18 +1200)]
Bug 3756: Adding the ability to have localuse systempreferences

Squashed commit of the following:

commit d42198bfadff20f40c38b3d9bc7f210ecc372e7c
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date:   Mon Jul 12 16:48:16 2010 -0400

    Bug 3756 [4/?] new sys prefs - no way to add a new local use preference

        Fixing Global Administration link

commit 060a52bc8d9da1d83387455967ca05292e5987b9
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date:   Mon Jul 12 16:45:07 2010 -0400

    Bug 3756 [3/?] new sys prefs - no way to add a new local use preference

        Hiding non-local sysprefs

commit d63858e13037fa91f18bc248ab770d757e31153c
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date:   Mon Jul 12 16:44:40 2010 -0400

    Bug 3756 [2/?]new sys prefs - no way to add a new local use preference

        Fixing a typo

commit 5b23a615018e049b1e11dbc10b131ecb30dfc6ab
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date:   Mon Jul 12 15:52:04 2010 -0400

    Bug 3756 new sys prefs - no way to add a new local use preference

        A quick and dirty fix

Signed-off-by: Chris Cormack <chrisc@catalyst.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 5013 "New patron" menu button broken on patron select screen
Owen Leonard [Thu, 15 Jul 2010 16:32:12 +0000 (12:32 -0400)]
Fix for Bug 5013 "New patron" menu button broken on patron select screen

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 5011 install debian graphicsmagick not imagemagick
Colin Campbell [Thu, 15 Jul 2010 15:59:17 +0000 (16:59 +0100)]
Bug 5011 install debian graphicsmagick not imagemagick

Scripts in install-misc were installing Image Magick
not Graphics::Magick the actual Koha dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agowr72054 fixing the z3950 search for acquisitions
Chris Cormack [Wed, 14 Jul 2010 04:32:44 +0000 (16:32 +1200)]
wr72054 fixing the z3950 search for acquisitions

Signed-off-by: Chris Cormack <chrisc@catalyst.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505: Quieting warns in acqui/z3950_search.pl
Chris Cormack [Wed, 14 Jul 2010 04:32:42 +0000 (16:32 +1200)]
Bug 2505: Quieting warns in acqui/z3950_search.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix 3419: fixes typo in inequality.
Ian Walls [Mon, 12 Jul 2010 18:22:48 +0000 (14:22 -0400)]
Bugfix 3419: fixes typo in inequality.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFixes Bug 4978: longoverdues.pl claims undefined subroutine ModItem
Ian Walls [Thu, 8 Jul 2010 20:21:01 +0000 (16:21 -0400)]
Fixes Bug 4978: longoverdues.pl claims undefined subroutine ModItem

Adds an explicit C4::Items:: prefix to the ModItem call on line 323

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4484, Rss tag is not escaped in search result
Owen Leonard [Wed, 7 Jul 2010 16:27:47 +0000 (12:27 -0400)]
Fix for Bug 4484, Rss tag is not escaped in search result

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agonewordersuggestion would not filter by status
Henri-Damien LAURENT [Wed, 7 Jul 2010 13:59:04 +0000 (15:59 +0200)]
newordersuggestion would not filter by status

All the suggestions would be displayed without any consideration of their status.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoerror 500 when record cannot be loaded
Henri-Damien LAURENT [Wed, 7 Jul 2010 13:59:03 +0000 (15:59 +0200)]
error 500 when record cannot be loaded

On a basket or a basket download, or csv export, if Koha cannot get a biblio, then it failed with error 500.
This patch fixes that behaviour skipping the faulty record in order to present the user with the biblios which are not causing trouble.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoUNIMARC coded field search : No results
Henri-Damien LAURENT [Wed, 7 Jul 2010 13:59:01 +0000 (15:59 +0200)]
UNIMARC coded field search : No results

ccl.properties had to be adapted in order to be able to request the good index

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #3772) show place hold button in isbd view
Nahuel ANGELINETTI [Thu, 5 Nov 2009 15:59:07 +0000 (16:59 +0100)]
(bug #3772) show place hold button in isbd view

This fix the isbd view to show the "place hold" button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #4954) allow date expiry modification only on step 0 and 3
Henri-Damien LAURENT [Wed, 7 Jul 2010 13:58:59 +0000 (15:58 +0200)]
(bug #4954) allow date expiry modification only on step 0 and 3

This add a verification, to allow automatic modification of expiry date, only if we are on a page that allow modification of expiry date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoUpdate 3.0 to 3.2 budgets
Henri-Damien LAURENT [Wed, 7 Jul 2010 13:58:58 +0000 (15:58 +0200)]
Update 3.0 to 3.2 budgets

FOREIGN_KEY_CHECKS had to be set to 0
in order to make the upgrade of aqbudgets table work.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4953 - make the debian package copy in YUI images
Robin Sheat [Wed, 7 Jul 2010 07:11:10 +0000 (19:11 +1200)]
bug 4953 - make the debian package copy in YUI images

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4952 - make the koha-remove script stop zebra for the instance
Robin Sheat [Wed, 7 Jul 2010 02:24:44 +0000 (14:24 +1200)]
bug 4952 - make the koha-remove script stop zebra for the instance

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4139: set DBrev to 143
Galen Charlton [Tue, 6 Jul 2010 12:24:13 +0000 (08:24 -0400)]
bug 4139: set DBrev to 143

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4139 - Adding some indexes to deal with a performance issue with overdue reports
Chris Cormack [Tue, 6 Jul 2010 08:58:03 +0000 (20:58 +1200)]
Bug 4139 - Adding some indexes to deal with a performance issue with overdue reports

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4188 Valid PDF file name when printing basket group with no name
Frédéric Demians [Sat, 3 Jul 2010 14:32:44 +0000 (16:32 +0200)]
Bug 4188 Valid PDF file name when printing basket group with no name

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2725: Fixes uppercasesurnames preference.
Garry Collum [Sat, 3 Jul 2010 13:17:01 +0000 (09:17 -0400)]
Bug 2725: Fixes uppercasesurnames preference.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3902: item class source can now be set during serials receiving
Galen Charlton [Fri, 2 Jul 2010 19:13:30 +0000 (15:13 -0400)]
bug 3902: item class source can now be set during serials receiving

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4808: allow limited-permission circ operators to print receipts
Galen Charlton [Fri, 2 Jul 2010 18:55:41 +0000 (14:55 -0400)]
bug 4808: allow limited-permission circ operators to print receipts

Staff users now only need circulation privileges to print
checkout receipts and slips; the 'borrowers' permission, which
allows editing patron records, is no longer required.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3916: set another "no change" dropdwon in batch item modification
Galen Charlton [Fri, 2 Jul 2010 18:38:28 +0000 (14:38 -0400)]
bug 3916: set another "no change" dropdwon in batch item modification

Item type drop-down in the batch item modification tool
now has its default value set to the 'no change' value.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4804) fix following bug: in neworderempty.pl, Click on minus sign in a item...
Alex Arnaud [Fri, 21 May 2010 14:44:33 +0000 (16:44 +0200)]
(BUG #4804) fix following bug: in neworderempty.pl, Click on minus sign in a item part don't decrements quantity.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3916: set final "no change" dropdwon in batch item modification
Galen Charlton [Fri, 2 Jul 2010 17:15:26 +0000 (13:15 -0400)]
bug 3916: set final "no change" dropdwon in batch item modification

Classification source drop-down in the batch item modification tool
now has its default value set to the 'no change' value.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4934 - Image missing for linked subfields in MARC display
Owen Leonard [Fri, 2 Jul 2010 16:46:02 +0000 (12:46 -0400)]
Fix for Bug 4934 - Image missing for linked subfields in MARC display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4932, Serial Enumeration / chronology not populated on receive
Owen Leonard [Fri, 2 Jul 2010 14:02:44 +0000 (10:02 -0400)]
Fix for Bug 4932, Serial Enumeration / chronology not populated on receive

- Correcting JavaScript so that serial enumeration / chronology is always
  prepopulated in the add item form when receiving a new issue.
- Altering the behavior of the "click to add item" link so that the
  "Arrived" option is automatically selected. This makes the link's
  behavior mirror the <select>'s behavior so that Arrived -> Add item
  and Add item -> Arrived.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4422: add AR (article) format icon to staff interface
Galen Charlton [Fri, 2 Jul 2010 16:40:01 +0000 (12:40 -0400)]
bug 4422: add AR (article) format icon to staff interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4422: Show article icon with DisplayOPACiconsXSLT
Jared CAMINS-ESAKOV [Fri, 9 Apr 2010 19:40:50 +0000 (15:40 -0400)]
bug 4422: Show article icon with DisplayOPACiconsXSLT

Show article (open book) icon on results and details screen when DisplayOPACiconsXSLT is enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for bug 4928, problematic 78x display in OPAC
Jared CAMINS-ESAKOV [Fri, 2 Jul 2010 14:05:45 +0000 (10:05 -0400)]
Fix for bug 4928, problematic 78x display in OPAC

- Add <xsl:if> wrappers around the display of subfield 'n' for 76x-78x fields
  This eliminates the issue in Firefox that caused the font size to grow
  progressively smaller on the OPAC Details page for records with multiple
  76x-78x fields

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoadd EUC-KR to list of support Z39.50 character encodings
Galen Charlton [Fri, 2 Jul 2010 16:17:15 +0000 (12:17 -0400)]
add EUC-KR to list of support Z39.50 character encodings

EUC-KR (an older character encoding for Korean) is used by the
Z39.50 server of the National Assembly Library of the Republic
of Korea.

Note that this requires that a suitable version of iconv,
one that supports mapping from EUC-KR to UTF-8,
be present on the Koha server.

Thanks to a person from the Korea Society for reporting the
issue on #koha.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4854: Show same subfields for 245 and 880$6245
Katrin Fischer [Fri, 2 Jul 2010 13:59:05 +0000 (15:59 +0200)]
Bug 4854: Show same subfields for 245 and 880$6245

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove a bunch of unconditional debug warns
Galen Charlton [Fri, 2 Jul 2010 14:56:15 +0000 (10:56 -0400)]
remove a bunch of unconditional debug warns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4188: add note about hiding the OrderPdfTemplate syspref
Galen Charlton [Fri, 2 Jul 2010 12:47:22 +0000 (08:47 -0400)]
bug 4188: add note about hiding the OrderPdfTemplate syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4188: move PDF templates for printed purchase orders
Galen Charlton [Fri, 2 Jul 2010 12:39:46 +0000 (08:39 -0400)]
bug 4188: move PDF templates for printed purchase orders

The PDF templates for purchase orders now live in the
directory koha-tmpl/intranet-tmpl/prog/pdf to separate
them from code.  As no automatic translation system for
PDF files is currently implemented, I'm keeping them out
of the language subdirectories for now.

At present, there are two choices of templates for printing
purchase orders (AKA basket groups), controlled by setting
the OrderPdfFormat syspref:

pdfformat::layout2pages (two-page layout)
pdfformat::layout3pages (three-page layout)

To customize a template or to add a new one requires two steps:

* modifying the PDF; note that OpenOffice source files
  are included as a way of generating the PDF
* modifying the code in acqui/pdfformat/layout*.pm to
  position the order text onto the template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove extraneous warns
Galen Charlton [Fri, 2 Jul 2010 12:19:14 +0000 (08:19 -0400)]
remove extraneous warns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4188 Allow acq basket group printing into PDF
Frédéric Demians [Sun, 18 Apr 2010 09:53:34 +0000 (11:53 +0200)]
Bug 4188 Allow acq basket group printing into PDF

Since new acquisition module workflow and specifications is not
documented, this fix is more an hypothesis than a patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug4929 - amended the instructions
Robin Sheat [Fri, 2 Jul 2010 00:55:46 +0000 (12:55 +1200)]
bug4929 - amended the instructions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2434: set DBrev to 142
Galen Charlton [Thu, 1 Jul 2010 23:37:30 +0000 (19:37 -0400)]
bug 2434: set DBrev to 142

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2434 followup patch to remove EVENT from message_transports
Nicole Engard [Tue, 29 Jun 2010 10:22:29 +0000 (06:22 -0400)]
bug 2434 followup patch to remove EVENT from message_transports

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug4926 - Improves the ID fields when sending lists and carts
Robin Sheat [Thu, 1 Jul 2010 05:41:33 +0000 (17:41 +1200)]
bug4926 - Improves the ID fields when sending lists and carts

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4915: Remove renewalsallowed from sample_itemtypes.sql
Katrin Fischer [Mon, 28 Jun 2010 20:49:43 +0000 (22:49 +0200)]
Bug 4915: Remove renewalsallowed from sample_itemtypes.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoCorrect typo in German sample news
Katrin Fischer [Mon, 28 Jun 2010 20:11:37 +0000 (22:11 +0200)]
Correct typo in German sample news

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 3683 - 'Sort by' column in list interface is not translatable
Owen Leonard [Fri, 25 Jun 2010 16:59:15 +0000 (12:59 -0400)]
Fix for Bug 3683 - 'Sort by' column in list interface is not translatable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 3372 - OPAC Reading History sorting breaks limit
Owen Leonard [Fri, 25 Jun 2010 16:26:39 +0000 (12:26 -0400)]
Fix for Bug 3372 - OPAC Reading History sorting breaks limit

Some other cosmetic and functional changes:

- "Show all/Show 50" links had been styled as tabs at some time
in the past. A CSS change somewhere broke this. Reimplementing it.

- Moving sort control to a <select> similar to the one used on
search results. Since javascript-based table sorting from the
table header is used elsewhere in the OPAC I felt the <select>
method better reflected the behavior of this re-sort.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4909 - extra > in path on contracts pages
Owen Leonard [Fri, 25 Jun 2010 13:48:20 +0000 (09:48 -0400)]
Fix for Bug 4909 - extra > in path on contracts pages

The logic for displaying a useful title did not take all
cases into account. This patch adds the missing case.

The patch also fixes problems with the "Cancel" link
on update and delete operations.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4911 Remove duplicated code
Colin Campbell [Fri, 25 Jun 2010 09:46:51 +0000 (10:46 +0100)]
Bug 4911 Remove duplicated code

Two duplicated subroutine definitions removed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove byte order mark (BOM) from installer SQL files
Galen Charlton [Fri, 25 Jun 2010 09:42:15 +0000 (05:42 -0400)]
remove byte order mark (BOM) from installer SQL files

The precence of a BOM can prevent an SQL script from being
run.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2434: assign to DBrev 141
Galen Charlton [Fri, 25 Jun 2010 09:32:33 +0000 (05:32 -0400)]
bug 2434: assign to DBrev 141

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2434 remove upcoming events for all languages
Nicole Engard [Wed, 2 Jun 2010 12:19:08 +0000 (08:19 -0400)]
bug 2434 remove upcoming events for all languages

this patch removed the upcoming events messaging option
and the upcoming event message from the system for all
languages since it was never implemented and confuses
librarians and patrons alike

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(MT #3651) Fix problems on search filters.
Alex Arnaud [Fri, 25 Jun 2010 08:59:37 +0000 (10:59 +0200)]
(MT #3651) Fix problems on search filters.

removing of useless value "no tabs" in organize by combo.
removing of useless value "Sort 1" in organize by combo.
Adding combodate for suggesteddate, manageddate, accepteddate.
Adding research on dates in query.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(MT #3651) Fills "book fund" combobox with bugdets and fix some bugs of research...
Alex Arnaud [Fri, 25 Jun 2010 08:59:36 +0000 (10:59 +0200)]
(MT #3651) Fills "book fund" combobox with bugdets and fix some bugs of research by filter.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoreplace references to defunct info email address
Galen Charlton [Fri, 25 Jun 2010 09:16:16 +0000 (05:16 -0400)]
replace references to defunct info email address

Now links to Koha project website.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove old revision history notes from a couple files
Galen Charlton [Fri, 25 Jun 2010 09:03:11 +0000 (05:03 -0400)]
remove old revision history notes from a couple files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4312: DBrev = 140 v3.02.00-beta
Galen Charlton [Fri, 25 Jun 2010 00:55:49 +0000 (20:55 -0400)]
bug 4312: DBrev = 140

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4312 change default for tagsmoderation to 0 from NULL
Nicole Engard [Wed, 23 Jun 2010 07:50:34 +0000 (03:50 -0400)]
bug 4312 change default for tagsmoderation to 0 from NULL

resending with fixes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4857) aqplan.pl: consideration of Planning categories with authorised values
Alex Arnaud [Thu, 24 Jun 2010 17:26:21 +0000 (19:26 +0200)]
(BUG #4857) aqplan.pl: consideration of Planning categories with authorised values

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT3652 : Unifying the search of neworder with Search
Henri-Damien LAURENT [Thu, 24 Jun 2010 17:26:18 +0000 (19:26 +0200)]
MT3652 : Unifying the search of neworder with Search

This patch unifies the search in neworder so that the same biblios should be sent back when searching from catalogue search or from box.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4811) suggestion.pl: display borrowers name in suggestion information filters...
Alex Arnaud [Thu, 24 Jun 2010 17:26:17 +0000 (19:26 +0200)]
(BUG #4811) suggestion.pl: display borrowers name in suggestion information filters (Suggested By, Managed by, Accepted by)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4810) parcel.pl: Fix a bug with applying a filter on pending orders displaying
Alex Arnaud [Thu, 24 Jun 2010 17:26:16 +0000 (19:26 +0200)]
(BUG #4810) parcel.pl: Fix a bug with applying a filter on pending orders displaying

When we apply a filter and click on "Click here to show x items" link, there are duplicates orders which are display.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #4523) possibility to show / hide the filters menu
Alex Arnaud [Thu, 24 Jun 2010 17:26:15 +0000 (19:26 +0200)]
(bug #4523) possibility to show / hide the filters menu

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3217 Impossible to change biblio record FW to Default
Frédéric Demians [Thu, 24 Jun 2010 19:13:46 +0000 (21:13 +0200)]
Bug 3217 Impossible to change biblio record FW to Default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(MT2371) basket.tmpl, in basket details, change Open on => Opened on
Alex Arnaud [Thu, 24 Jun 2010 17:26:11 +0000 (19:26 +0200)]
(MT2371) basket.tmpl, in basket details, change Open on => Opened on

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4356) Basket.pl: adding a link to the basketgroup
Alex Arnaud [Thu, 24 Jun 2010 17:26:12 +0000 (19:26 +0200)]
(BUG #4356) Basket.pl: adding a link to the basketgroup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value
Alex Arnaud [Thu, 24 Jun 2010 17:26:14 +0000 (19:26 +0200)]
(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value

This patch tranform the undefined value of budget spent to a money value which equals 0.00.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoSelect in budget add forum
Jean-André Santoni [Thu, 24 Jun 2010 17:26:13 +0000 (19:26 +0200)]
Select in budget add forum

Sorted the branches select.
Modified display to "branchcode - branchname"
Fixed a bug, selection was inverted.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4905 Runtime errors in about.pl
Colin Campbell [Thu, 24 Jun 2010 14:57:21 +0000 (15:57 +0100)]
Bug 4905 Runtime errors in about.pl

Calls to VERSION were generating errors when called on a string.
Use a bit of sleight of hand to avoid this
Added a couple of tests on Installer/PerlModules
Module needs better coverage testing (esp on newer perls)
Sorted to list of modules to make koha_perl_deps.pl more
human-friendly

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agofix two broken calls to _FixPriority
Galen Charlton [Tue, 23 Feb 2010 20:09:46 +0000 (15:09 -0500)]
fix two broken calls to _FixPriority

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3344: display in-transit status on holds priority list
Galen Charlton [Mon, 22 Feb 2010 03:22:43 +0000 (22:22 -0500)]
bug 3344: display in-transit status on holds priority list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4224: explicitly mark hold requests as being handled by item in transit
Galen Charlton [Mon, 22 Feb 2010 02:49:09 +0000 (21:49 -0500)]
bug 4224: explicitly mark hold requests as being handled by item in transit

This patch defines a new values of reserves.found, 'T', to indicate that
an item has been allocated to fill a hold request and is currently
in transit from one branch to another.  This explicit value is meant
to filter out hold requests from processing by holds queue batch
job.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4532, Use include file for bibliodefaultview logic
Owen Leonard [Wed, 19 May 2010 15:47:37 +0000 (11:47 -0400)]
Fix for Bug 4532, Use include file for bibliodefaultview logic

Note that this new include builds only the first half of the
anchor tag (<a>). Because title and subtitle are output differently
on some pages, rendering of the second half of the tag is left
to individual pages.

Includes fixes for staff client templates.

Change to basket.pl fixes a bug wherein the OPAC's bibliodefaultview
preference was being checked instead of the staff client's.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4821, With multiple 5XX fields, the font display gets progressively smaller
Owen Leonard [Thu, 27 May 2010 19:53:41 +0000 (15:53 -0400)]
Fix for Bug 4821, With multiple 5XX fields, the font display gets progressively smaller

Prevent the generation of empty label spans for various
bib details fields.  A construct like

<span class="results_summary"><span class="label" />contents note</span>

is consistently misinterpreted in many web browsers, leading to
CSS oddities.  See the bug for more details.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoPartial fix for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
Owen Leonard [Fri, 28 May 2010 18:50:30 +0000 (14:50 -0400)]
Partial fix for Bug 4423, Staff Client XSLT is just a copy of the OPAC one

This patch improves the template logic specifying a layout
based on whether the display is XSLT or normal, and whether
Amazon Content is on or off. Previously XSLT view did not
display Amazon covers when enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMore fixes for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
Owen Leonard [Wed, 2 Jun 2010 19:17:37 +0000 (15:17 -0400)]
More fixes for Bug 4423, Staff Client XSLT is just a copy of the OPAC one

- Adding material type icons from the OPAC side
- Adding OPAC View link
- Copying revised handling of MU from the OPAC
- Removing OPAC-specific markup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFollowup fix for Bug 4453: Removing invalid template fragment.
Owen Leonard [Fri, 4 Jun 2010 14:53:20 +0000 (10:53 -0400)]
Followup fix for Bug 4453: Removing invalid template fragment.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4278, canceling vendor add refreshes wrong
Owen Leonard [Fri, 4 Jun 2010 16:49:19 +0000 (12:49 -0400)]
Fix for Bug 4278, canceling vendor add refreshes wrong

Patch corrected to follow HDL's suggestion that link check
for existing vendor id and conditionally redirect based
on that.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 3895 - Menu on left of Contracts is for Admin Pages
Owen Leonard [Tue, 8 Jun 2010 19:16:30 +0000 (15:16 -0400)]
Fix for Bug 3895 - Menu on left of Contracts is for Admin Pages

- Also adding cancel link to the add/edit view
- Also adding message when there are no contracts to list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4886, missing 404 redirection on wrong biblionumber for MARC and ISBD...
Owen Leonard [Thu, 10 Jun 2010 17:28:28 +0000 (13:28 -0400)]
Fix for Bug 4886, missing 404 redirection on wrong biblionumber for MARC and ISBD details

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4884, opac-showmarc.pl can't find compact.xsl
Owen Leonard [Thu, 10 Jun 2010 17:09:14 +0000 (13:09 -0400)]
Fix for Bug 4884, opac-showmarc.pl can't find compact.xsl

This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4859, Formatting cleanup for merge biblio record interface
Owen Leonard [Tue, 8 Jun 2010 19:43:35 +0000 (15:43 -0400)]
Fix for Bug 4859, Formatting cleanup for merge biblio record interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place...
Owen Leonard [Thu, 10 Jun 2010 18:14:26 +0000 (14:14 -0400)]
Fix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place holds from Public Lists

The template was originally designed so that form controls were
hidden from users who didn't have permission to modify a particular
shelf  because the form controls were only used for deleting from
lists. Now that users can place holds and add tags via the check-
boxes, the controls must be available to all users.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug3916 : Batch Modify tool overwrites branches fields
Henri-Damien LAURENT [Wed, 23 Jun 2010 16:15:49 +0000 (18:15 +0200)]
Bug3916 : Batch Modify tool overwrites branches fields

This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default.
Adding a void branch selected
Changing default value to ""

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>