]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoMulti-bug fix - SetMarcUnicodeFlag for records coming from Koha
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha

This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode.  This should help open the door for reliable
input of diacriticals via acquisitions.

MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.

Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweak perldoc (--help) for leader_fix.pl
Joe Atzberger [Tue, 7 Apr 2009 22:37:56 +0000 (17:37 -0500)]
Tweak perldoc (--help) for leader_fix.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoScript to repair MARC21 leader/09.
Joe Atzberger [Fri, 3 Apr 2009 20:42:20 +0000 (15:42 -0500)]
Script to repair MARC21 leader/09.

Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09.  It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8).  This script diagnoses
and repairs the value in the leader, depending on runtime options.

The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal.  While we work on
fixing the input, this script will fix the existing data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix syntax error in fr-FR sysprefs SQL
Galen Charlton [Sat, 18 Apr 2009 13:37:40 +0000 (08:37 -0500)]
fix syntax error in fr-FR sysprefs SQL

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: unescaped single-quote in french sys. prefs. sql file
Michael Hafen [Mon, 13 Apr 2009 21:53:42 +0000 (15:53 -0600)]
bug: unescaped single-quote in french sys. prefs. sql file

The description for autoBarcode had an unescaped single-quote.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRe-insert useldapserver into koha-conf.xml
Joe Atzberger [Mon, 13 Apr 2009 22:05:49 +0000 (17:05 -0500)]
Re-insert useldapserver into koha-conf.xml

This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap.  This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove last reference to deprecated syspref NoReturnSetLost
Galen Charlton [Tue, 14 Apr 2009 13:51:08 +0000 (08:51 -0500)]
remove last reference to deprecated syspref NoReturnSetLost

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3110 - Move Serial Preferences to Serials Tab
John Beppu [Tue, 14 Apr 2009 19:45:15 +0000 (14:45 -0500)]
bug 3110 - Move Serial Preferences to Serials Tab

- Moved the following system preferences to the Serials tab:
  OPACDisplayExtendedSubInfo
  OPACSubscriptionDisplay
  RenewSerialAddsSuggestion
  SubscriptionHistory

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrected: fix for Bug 3112, Emailed list contains too much whitespace
Owen Leonard [Tue, 14 Apr 2009 19:46:58 +0000 (14:46 -0500)]
Corrected: fix for Bug 3112, Emailed list contains too much whitespace

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBut 3117 : fix typo in C4::Matcher causing compilation failure.
Ryan Higgins [Wed, 15 Apr 2009 17:23:21 +0000 (10:23 -0700)]
But 3117 : fix typo in C4::Matcher causing compilation failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoqualify warn; sort_by is not a required search parameter
Galen Charlton [Wed, 8 Apr 2009 20:13:12 +0000 (15:13 -0500)]
qualify warn; sort_by is not a required search parameter

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix various warnings
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings

* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3099: fix copying patron info to deletedborrowers (DB rev 018)
Galen Charlton [Wed, 8 Apr 2009 20:52:05 +0000 (15:52 -0500)]
bug 3099: fix copying patron info to deletedborrowers (DB rev 018)

Fixes the following problem:

When deleting a patron record via the intranet or the cleanborrowers tool,
patron records are deleted but are not copied to deletedborrowers.
C4::Members::MoveMemberToDeleted() fails with the following error:

deletemem.pl: DBD::mysql::st execute failed: Column count doesn't match value
count at row 1 at C4/Members.pm line 1672.,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3051) bad support of pagination in auth_finder
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:02:14 +0000 (13:02 +0100)]
(bug #3051) bad support of pagination in auth_finder

This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3049: display correct due date of renewed loans
Galen Charlton [Wed, 8 Apr 2009 19:46:01 +0000 (14:46 -0500)]
bug 3049: display correct due date of renewed loans

The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2915) C4::Biblio::DelBiblio delete the serials
Nahuel ANGELINETTI [Fri, 6 Mar 2009 10:37:55 +0000 (11:37 +0100)]
(bug #2915) C4::Biblio::DelBiblio delete the serials

This patch add the serials deletion in DelBiblio function, so now when a record is deleted all attached serials will be too.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2919 -- fix value_builder plugins for dateaccessioned, barcode
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode

This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBegin cleanup on additem.
Joe Atzberger [Wed, 21 Jan 2009 01:18:21 +0000 (19:18 -0600)]
Begin cleanup on additem.

REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see.  Remove  the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations.  There is no
longer any /cgi-bin in the actual directory file path.

This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor markup corrections for validity.
Owen Leonard [Wed, 8 Apr 2009 18:39:37 +0000 (13:39 -0500)]
Minor markup corrections for validity.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoauto truncation was not used
Henri-Damien LAURENT [Fri, 3 Apr 2009 10:28:24 +0000 (12:28 +0200)]
auto truncation was not used

Auto truncation now works on LTR languages
For RTL languages(Arab, Hebrew), development should be really improved.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: add items to batch - search results have multiple items on one table row
Michael Hafen [Wed, 11 Mar 2009 19:17:08 +0000 (13:17 -0600)]
bug: add items to batch - search results have multiple items on one table row

The table row openning and closing tags were outside the template loop.
This moves them inside the loop.  Without this search results with more
than one copy will append those copies to the one row.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: add items to label batch - need userenv loaded before call to SimpleSearch
Michael Hafen [Wed, 11 Mar 2009 19:25:40 +0000 (13:25 -0600)]
bug: add items to label batch - need userenv loaded before call to SimpleSearch

Since I added more IndependantBranches code to my git repo I need
userenv loaded before SimpleSearch() is called.  I think
get_template_and_user() should be called as soon as possible.  In this
case it could mean two calls, but it has to be so.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoIntroduce sth caching to Letters.pm
Joe Atzberger [Fri, 27 Mar 2009 15:34:34 +0000 (10:34 -0500)]
Introduce sth caching to Letters.pm

The re-creation of statement handles for the same queries, repeatedly,
seriously degrades the performance of notices.  This introduces new
class-level caching to avoid that problem.

Note: initial provisions
to do the same with caching of COLUMNS information about tables is
also included, but this would probably be most usefully implemented
in C4::Context (or a separate more central module).  The benefits of
caching that info would probably be even greater.  Note that this
proposed implementation might be obsoleted by ORM integration, where
DB structure info would already be cached.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPartial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available...
Owen Leonard [Mon, 6 Apr 2009 13:50:51 +0000 (08:50 -0500)]
Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"

GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoperltidy finishreceive.pl and two comments added
Joe Atzberger [Tue, 7 Apr 2009 22:37:50 +0000 (17:37 -0500)]
perltidy finishreceive.pl and two comments added

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3090 - Add perldoc details
Joe Atzberger [Tue, 7 Apr 2009 22:37:55 +0000 (17:37 -0500)]
Bug 3090 - Add perldoc details

This is half of the fix for 3090.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoparcel.pl cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:52 +0000 (17:37 -0500)]
parcel.pl cleanup

It looks like a lot of change, but it isn't much:
perltidy, removed unused "toggle" code, and corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoorderreceive cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup

Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoacceptorreject.pl cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:54 +0000 (17:37 -0500)]
acceptorreject.pl cleanup

Perltidy the ugly block (still ugly).
Use elsif where appropriate.
Added FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFactor common element out of both sides of conditional.
Joe Atzberger [Tue, 7 Apr 2009 22:37:53 +0000 (17:37 -0500)]
Factor common element out of both sides of conditional.

Add placeholder complaint about misuse of TMPL EXPR statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemove unused TMPL variable.
Joe Atzberger [Tue, 7 Apr 2009 22:37:51 +0000 (17:37 -0500)]
Remove unused TMPL variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 3095, Add to lists page doesn't redirect with no javascript
Owen Leonard [Tue, 7 Apr 2009 19:21:18 +0000 (14:21 -0500)]
Fix for Bug 3095, Add to lists page doesn't redirect with no javascript

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding new "tag" icon to tag link in lists interface. Also removing an unwanted ID...
Owen Leonard [Tue, 7 Apr 2009 19:03:02 +0000 (14:03 -0500)]
Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore fixes for Bug 3044
Owen Leonard [Tue, 7 Apr 2009 19:48:16 +0000 (14:48 -0500)]
More fixes for Bug 3044

Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD...
Nahuel ANGELINETTI [Mon, 23 Mar 2009 16:15:27 +0000 (17:15 +0100)]
(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view

this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd the possibility to replace, in sysprefs, the code by it's valuecode with {{code...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:37:48 +0000 (11:37 +0100)]
add the possibility to replace, in sysprefs, the code by it's valuecode with {{code}} ex : {{995c}}

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd warning for unrecognized sort order.
Joe Atzberger [Wed, 18 Mar 2009 22:21:47 +0000 (17:21 -0500)]
Add warning for unrecognized sort order.

This may help elucidate problems we are having with sorts that
do not seem to work.  I.E., if the inteface is requesting
unrecognized sort orders, we need to know about it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove incomplete bib bulk editing code
Galen Charlton [Mon, 6 Apr 2009 14:45:56 +0000 (09:45 -0500)]
remove incomplete bib bulk editing code

Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWriting Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing...
Owen Leonard [Wed, 18 Mar 2009 12:49:56 +0000 (07:49 -0500)]
Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago3040 : seriestitle mistaken as collection title
Henri-Damien LAURENT [Mon, 16 Mar 2009 21:05:21 +0000 (22:05 +0100)]
3040 : seriestitle mistaken as collection title

If series title was previously taken as collectiontitle
then you should launch
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/batchRebuildBiblioTables.pl

[RM note: applies only to UNIMARC users - MARC21
users should not run the batch jobs.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew styles for bulk hold and bulk tag inputs on search results page.
Owen Leonard [Sat, 4 Apr 2009 18:53:48 +0000 (13:53 -0500)]
New styles for bulk hold and bulk tag inputs on search results page.

This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAnother try at fixing Bug 2949.
Owen Leonard [Sat, 4 Apr 2009 15:19:33 +0000 (10:19 -0500)]
Another try at fixing Bug 2949.

This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agorestored tab-delimited report download
Galen Charlton [Sun, 5 Apr 2009 16:29:32 +0000 (11:29 -0500)]
restored tab-delimited report download

Previous patch broke this, always providing the
guided report download in CSV format regardless of
whether CSV or tab-delimited was requested.

Also, default name of downloaded file is reportresults.csv
for CSV output and reportresults.tab for tab-delimited.

Also removed a couple subroutine prototypes that
were leading to unnecessary compile-time warnings
under use warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3066 - Overhaul guided reports
Joe Atzberger [Tue, 31 Mar 2009 20:08:10 +0000 (15:08 -0500)]
Bug 3066 - Overhaul guided reports

execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCondense inarticulate construction of TMPL structures.
Joe Atzberger [Thu, 26 Mar 2009 15:59:17 +0000 (10:59 -0500)]
Condense inarticulate construction of TMPL structures.

Use map to replace multiple temporary hash constructions.
Also a minor POD fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agorunreport.pl and prep work on Guided.pm
Joe Atzberger [Fri, 27 Mar 2009 15:34:33 +0000 (10:34 -0500)]
runreport.pl and prep work on Guided.pm

The old location of runreport.pl was under tools, leaving it exposed
to web requests.  This is a security flaw since it does NOT check any
Auth and allows the user to request any Saved Report be run.  This is
not a problem under misc/crontab/ and it suggests the more appropriate use.

Guided.pm is not fixed here (see bug 3066), but it is prepared to be fixed
and made compatible with runreport as detailed in the perldoc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSerial IF statements on same $variable should be ELSIFs.
Joe Atzberger [Wed, 25 Mar 2009 20:25:47 +0000 (15:25 -0500)]
Serial IF statements on same $variable should be ELSIFs.

Small POD update also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agopatch for bug-3017
Mason James [Mon, 9 Mar 2009 02:13:06 +0000 (15:13 +1300)]
patch for bug-3017

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2862) improve sql reports
Nahuel ANGELINETTI [Fri, 12 Dec 2008 10:56:19 +0000 (11:56 +0100)]
(bug #2862) improve sql reports

Clear all non-alphanum chars at the end of an sql query.
Use ESCAPE=HTML to escape double quotes in csv export

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoInternationalize Amazon support
Frédéric Demians [Wed, 1 Apr 2009 19:36:28 +0000 (21:36 +0200)]
Internationalize Amazon support

With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated INSTALL.debian
David Bavousett [Thu, 18 Sep 2008 16:43:46 +0000 (11:43 -0500)]
Updated INSTALL.debian

Modified INSTALL.debian to update install and web
configuration instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges to installed indexing.
J. David Bavousett [Fri, 26 Dec 2008 22:12:06 +0000 (16:12 -0600)]
Changes to installed indexing.

These changes tidy up ISBN and ISSN indexing, per Michele Maenpaa.  It's being
set up manually on many new installations, and probably ought to become part of the default
Koha installation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges to bulkmarcimport.pl
J. David Bavousett [Fri, 26 Dec 2008 21:56:55 +0000 (15:56 -0600)]
Changes to bulkmarcimport.pl

Adds three new switches:

-idmap <filename> - optional output file of
                    map of source record ID numbers
                    to Koha biblionumber
-x                - if idmap is supplied, MARC tag
                    to get source record ID from
-y                - if idmap is supplied, MARC subfield
                    to get source record ID from

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoModifications to C4/Matcher for colon and ending punctuation
J. David Bavousett [Fri, 26 Dec 2008 21:38:00 +0000 (15:38 -0600)]
Modifications to C4/Matcher for colon and ending punctuation

Recommended by Michele Maenpaa, this adds handling colon and end-punctuation stripping
in subroutine _normalize, and fixes length testing in subroutine _get_match_keys

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded ISBN to RSS results.
J. David Bavousett [Fri, 30 Jan 2009 16:05:46 +0000 (10:05 -0600)]
Added ISBN to RSS results.

Added ISBN tag to RSS results, right after the title.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agotweek css for staff search results item type images
Michael Hafen [Wed, 18 Mar 2009 17:00:28 +0000 (11:00 -0600)]
tweek css for staff search results item type images

This add a clear:left; to the #searchresults ul li selector.  Otherwise
it's possible an item type image will be offset by an image above it and
not float all the way to the left.  This makes sure the image is clear
of the above image.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDDCN callnumber splitting with test.
Joe Atzberger [Fri, 13 Mar 2009 14:57:14 +0000 (09:57 -0500)]
DDCN callnumber splitting with test.

Similar to previous patch for LCCN splitting, this patch incorporates
changes to split_ddcn and supplies a test file for verifying proper
operation.  Note that the only previously documented example for intended
operation is included as one of the tests.

This regexps are created to be rather forgiving.  For example, the function
will not choke if two spaces were included where the "spec" (such as it is)
expects one.  Obviously this is because for CN splitting purposes, it doesn't
matter, we're not going to ever split in the middle of whitespace.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes...
Owen Leonard [Wed, 1 Apr 2009 18:17:54 +0000 (13:17 -0500)]
Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3084) in baskets, change the isbn of column
Nahuel ANGELINETTI [Thu, 2 Apr 2009 13:34:30 +0000 (15:34 +0200)]
(bug #3084) in baskets, change the isbn of column

this patch add a new column and put the isbn in it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding details to OPAC search results RSS, described in Bug 2973.
Owen Leonard [Thu, 2 Apr 2009 19:06:33 +0000 (14:06 -0500)]
Adding details to OPAC search results RSS, described in Bug 2973.

This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3088: fix crash in opac-ISBDdetail.pl
Galen Charlton [Fri, 3 Apr 2009 23:15:08 +0000 (18:15 -0500)]
bug 3088: fix crash in opac-ISBDdetail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix type of new serials display system preferences
Galen Charlton [Fri, 3 Apr 2009 21:46:21 +0000 (16:46 -0500)]
fix type of new serials display system preferences

OPACSerialIssueDisplayCount and StaffSerialIssueDisplayCount
should be integers, not free.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleared a trailing warn, sorry.
Daniel Sweeney [Fri, 27 Mar 2009 15:09:30 +0000 (10:09 -0500)]
Cleared a trailing warn, sorry.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdds a 'New Subscription' option for selection from the detail page of a record.
Joshua Ferraro [Thu, 26 Mar 2009 22:09:44 +0000 (17:09 -0500)]
Adds a 'New Subscription' option for selection from the detail page of a record.

NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 424: Serials display: installer does not make database changes for displa...
Joshua Ferraro [Thu, 26 Mar 2009 22:09:45 +0000 (17:09 -0500)]
Fix for Bug 424: Serials display: installer does not make database changes for display parameters, so can't save new subscriptions

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSerials Display Enhancement
Joshua Ferraro [Thu, 26 Mar 2009 22:09:46 +0000 (17:09 -0500)]
Serials Display Enhancement

Allows specification of how many issues of a subscription to display
at a global and subscription-specific level. Also adds a link to the
detail page to a specific subscription.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix syntax error in tags JavaScript
Galen Charlton [Fri, 3 Apr 2009 16:14:49 +0000 (11:14 -0500)]
fix syntax error in tags JavaScript

FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3034: Tag multiple items at once.
Stephen Edwards [Wed, 1 Apr 2009 17:19:35 +0000 (13:19 -0400)]
bug 3034: Tag multiple items at once.

Added a "Tag" button in the toolbar area of the results
page.  This activates an inline form that allows the user
to enter a tag that can then be applied to all currently
selected items.

In addition, a "Tag" link has been added to both the List and
Cart pages that provides the same functionality in those contexts.
In these two cases, the a per-item states appears below the
bibliographic information for each item.

Status that applies to the overall operation, such as failing to
provide a tag, will be shown in an alert dialog box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadded dependencies for new OAI-PMH server
Galen Charlton [Wed, 1 Apr 2009 16:49:43 +0000 (11:49 -0500)]
added dependencies for new OAI-PMH server

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd a UNIMARC to Dublin Core XSL
Frédéric Demians [Thu, 26 Mar 2009 20:54:25 +0000 (21:54 +0100)]
Add a UNIMARC to Dublin Core XSL

This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd another OAI server
Frederic Demians [Thu, 26 Mar 2009 20:54:24 +0000 (21:54 +0100)]
Add another OAI server

This OAI server has those characteristics:

   * It doesn't use C4::OAI anymore.
   * It uses HTTP::OAI library which is easily expandable.
   * XML result is not build anymore directly but using
     XML::SAX::Writer. It should solve encoding and XML related issues.
   * It returns two formats: oai_dc and marcxml.
   * DC is generated from biblioitems.marcxml by applying XSLT
     (MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
   * It uses the same tokens as previous OAI server (thanks Philippe
     Jaillon).
   * There is no more sets (it wasn't operational in previous version).

Add two new dependencies:

   * HTTP::OAI
   * XML::SAX::Writer
     available as a Debian package: libxml-sax-writer-perl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd } that slipped out because of bad merge
Galen Charlton [Wed, 1 Apr 2009 16:02:48 +0000 (11:02 -0500)]
add } that slipped out because of bad merge

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #3071 - Z39.50 search result highlights are mixed
Frédéric Demians [Sun, 29 Mar 2009 08:55:34 +0000 (10:55 +0200)]
Bug #3071 - Z39.50 search result highlights are mixed

This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd Babeltheque OPAC enhanced content
Frédéric Demians [Sat, 28 Mar 2009 07:23:42 +0000 (08:23 +0100)]
Add Babeltheque OPAC enhanced content

www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66fd962930007964a2f918665dc3a956
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix Amazon cover for UNIMARC
Frédéric Demians [Mon, 30 Mar 2009 06:42:22 +0000 (08:42 +0200)]
Fix Amazon cover for UNIMARC

In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-'
are valid. This patch modify ISBN normalization in order to
automaticaly suppress '-' before sending ISBN to Amazon
to get book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReformatting receipt template and CSS to be more readable.
Owen Leonard [Sun, 29 Mar 2009 23:46:39 +0000 (18:46 -0500)]
Reformatting receipt template and CSS to be more readable.

A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBUG-1503: fixes broken matching for 'hidden' values.
Mason James [Sun, 29 Mar 2009 23:54:15 +0000 (12:54 +1300)]
BUG-1503: fixes broken matching for 'hidden' values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2913) show "--" on repeated fields
Nahuel ANGELINETTI [Wed, 14 Jan 2009 12:26:51 +0000 (13:26 +0100)]
(bug #2913) show "--" on repeated fields

This patch just transform the script to set the field title as "--" if it was already shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix to ignore 600$2 'Source of heading' fields for MARC21 subject display
Mason James [Wed, 1 Apr 2009 04:11:13 +0000 (17:11 +1300)]
fix to ignore 600$2 'Source of heading' fields for MARC21 subject display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding patron address to select patron form.
Owen Leonard [Mon, 30 Mar 2009 16:15:04 +0000 (11:15 -0500)]
Adding patron address to select patron form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3057) mandatory subfield edition
Nahuel ANGELINETTI [Wed, 25 Mar 2009 15:12:06 +0000 (16:12 +0100)]
(bug #3057) mandatory subfield edition

modify the "name" of mandatory input field.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoConvert opac-reserve to use GetBranchesLoop.
Joe Atzberger [Tue, 24 Mar 2009 21:36:11 +0000 (16:36 -0500)]
Convert opac-reserve to use GetBranchesLoop.

Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoImprove performance and fault tolerance for sync_items...
Joe Atzberger [Mon, 23 Mar 2009 21:25:21 +0000 (16:25 -0500)]
Improve performance and fault tolerance for sync_items...

Pulled the GetMarcFromKohaField outside the loop, since we only need to
check it once.  Same for $item_sth.  Added safety checks for success of
delete_field and GetMarcItem, with warnings on failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agocleanup some of value_builder MARC21 plugins
Joe Atzberger [Fri, 13 Mar 2009 19:22:43 +0000 (14:22 -0500)]
cleanup some of value_builder MARC21 plugins

Tons of unnecessary dependencies removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoperltidy some ugly value_builder plugins
Joe Atzberger [Fri, 13 Mar 2009 19:22:42 +0000 (14:22 -0500)]
perltidy some ugly value_builder plugins

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agowhitespace cleanup and remove editor comments
Joe Atzberger [Wed, 18 Mar 2009 22:21:48 +0000 (17:21 -0500)]
whitespace cleanup and remove editor comments

No functionality affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3063) fix unimarc 4xx plugin with cloned field
Nahuel ANGELINETTI [Thu, 26 Mar 2009 12:59:37 +0000 (13:59 +0100)]
(bug #3063) fix unimarc 4xx plugin with cloned field

this patch fix the unimarc plugin 4xx to work with cloned fields, the id of the div wasn't replaced when the field was cloned.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoInstructions and packages required for Debian Lenny Installation
Frederic Demians [Fri, 13 Mar 2009 07:14:58 +0000 (08:14 +0100)]
Instructions and packages required for Debian Lenny Installation

INSTALL.debian-lenny
    Instructions for installing Koha on Debian Lenny.
    Based on INSTALL.debian. Almost all Perl modules are now available
    via Debian packages. MySQL installation is simplified.

debian-lenny.packages
    List of all Lenny packages required by Koha.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #3036 Avoid command-line installer blocking on opensolaris plateform
Frederic Demians [Fri, 13 Mar 2009 19:47:25 +0000 (20:47 +0100)]
Bug #3036 Avoid command-line installer blocking on opensolaris plateform

Koha installation/upgrade on OpenSolaris 'seems' to work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixes error below...
Mason James [Sun, 15 Mar 2009 05:52:35 +0000 (18:52 +1300)]
fixes error below...

 bookcount.pl: Illegal Date 'Item has no branch transfers record' does not match 'iso' format: yyyy-mm-dd at /home/mason/git/kap-k3-2/circ/bookcount.pl line 88

tested on 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branc...
Mason James [Mon, 16 Mar 2009 11:49:01 +0000 (00:49 +1300)]
fixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branches.pl line 242.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanging "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be...
Owen Leonard [Mon, 16 Mar 2009 15:23:41 +0000 (10:23 -0500)]
Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor bug fix Documentation update : 3039
Henri-Damien LAURENT [Mon, 16 Mar 2009 20:34:39 +0000 (21:34 +0100)]
Minor bug fix Documentation update : 3039

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoHiding labels for add to list options when user isn't logged in or options don't...
Owen Leonard [Tue, 17 Mar 2009 20:02:43 +0000 (15:02 -0500)]
Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoquietens a noisy debug pop-up, when debugging
Mason James [Wed, 18 Mar 2009 03:19:34 +0000 (16:19 +1300)]
quietens a noisy debug pop-up, when debugging

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2958 - notforloan (8008) is a numeric field.
Joe Atzberger [Thu, 19 Mar 2009 19:06:26 +0000 (14:06 -0500)]
Bug 2958 - notforloan (8008) is a numeric field.

Update index to allow searching for "On Order" items, -1 value.
Example:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-search.pl?q=ccl=notforloan:-1

Without this patch, search for "-1" is normalized to "1".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoInvalid field 'expiry' referenced.
Joe Atzberger [Wed, 18 Mar 2009 22:21:49 +0000 (17:21 -0500)]
Invalid field 'expiry' referenced.

This caused a warning from C4::Dates on every execution, since the value
passed to format_date was undefined.  Now we reference the correct field
and check for a populated value before trying to reformat it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug Fix : weight field was broken in UNIMARC
Henri-Damien LAURENT [Tue, 24 Mar 2009 13:45:29 +0000 (14:45 +0100)]
Bug Fix : weight field was broken in UNIMARC

Title-cover was not defined in record.abs
So the relevance ranking was broken.
This patch corrects that
For UNIMARC people, please reindex

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 3062, "place hold on lists different font"
Owen Leonard [Fri, 27 Mar 2009 20:31:52 +0000 (15:31 -0500)]
Fix for Bug 3062, "place hold on lists different font"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoconvert '&' to '&amp;' in Syndetics URLs
Galen Charlton [Fri, 27 Mar 2009 23:07:08 +0000 (18:07 -0500)]
convert '&' to '&amp;' in Syndetics URLs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>