Paul Poulain [Mon, 11 Jun 2012 13:38:35 +0000 (15:38 +0200)]
Revert "Subroutine prototypes used at line XXX, column 1. See page 194 of PBP."
This reverts commit
583abead1b3d537f78a3d558981b2e9abb2791ff.
The translator does not work anymore after this patch has been applied, so reverting it
Paul Poulain [Sun, 10 Jun 2012 16:16:33 +0000 (18:16 +0200)]
Bug 4246 Follow-up updatedatabase
Kyle M Hall [Sat, 9 Jun 2012 20:21:02 +0000 (16:21 -0400)]
Talking Tech Support - Phase I - Followup 3 - Follow PBP
* Fixes violations of Perl Best Practices, where possible
* perltidy both scripts
http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Thu, 10 May 2012 16:01:11 +0000 (12:01 -0400)]
Talking Tech Support - Phase I - Followup 2 - Bugfix
http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Mon, 26 Mar 2012 15:43:02 +0000 (11:43 -0400)]
Talking Tech Support - Phase I - Followup - Fix Messaging Preferences
There is a flaw in C4::Members::Messaging::GetMessagingPreferences where
the system assumes that every transport will use the same letter. This
is not necessarily true. Even with the default preferences of just
'email' and 'sms', we should be able to have different letters
for each, as one has a maximum character length ( sms ) and one
does not. GetMessagingPreferences currently uses the letter code
of the last result of its query as the letter code for every transport type.
The returned data is a hashref with a key 'transport_types' that is
an array of transport_types this borrower has selected for the given
alert.
This commit modifies GetMessagingPreferences such that the the
'transport_types' array is now a hash where the name of the transport
type is now a key to the value of the letter code set for that transport
type.
It also modifies code calling GetMessagingPreferences where necessary,
and as a side benefit will correctly get the letter codes for email
and sms correctly, if they are defined differently.
http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
In use in production by two libraries: Middletown and Washoe
who give their sign off but don't have git to do so.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Ian Walls [Wed, 22 Feb 2012 17:44:38 +0000 (12:44 -0500)]
Talking Tech Support - Phase I
Implements support for Talking Tech I-tiva phone notification for OVERDUE, PREDUE and HOLD notifications.
Overdues respect triggers as configured for the patron's branch.
Predue and Holds notifications respect patron's messaging preference choices.
A new column for phone notification is added if the TalkingTechItivaPhoneNotification system preference is turned on
Record of phone messages being sent to patrons is added to the patron's Notices
tab; notice of success or failure can be retrieved from I-tiva.
See the TalkingTech.README for installation and set-up instructions.
Aside from the control system preference, and the necessary changes to Messaging Preferences
forms to make use of phone notifications, the bulk of the code resides in external
cronjobs.
TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. Actual transmission
of the file must be handled by the system administrator.
TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. Getting the
file from I-tiva to Koha is the job of the system administrator, as well.
Both scripts have a --help option with full documentation.
The only necessary change to core Koha behavior is in C4::Letters::EnqueueLetter. The return
value was changed from 0 or 1 (successful addition of letter to message_queue or not), to the actual
insert ID of the letter. This was required by the outbound script to present a unique Transaction ID
for the notice added to the patron's record (so a 'sent' or 'failed' status could be updated). Since
the dbh and sth are not shared, and the last_insert_id() command is table-specific, this should be thread-safe.
No changes are necessary to any parts of Koha, as all usage of EnqueueLetter currently ignores the return value.
To Test:
1. Turn on TalkingTechItivaPhoneNotification system preference
2. Verify that 'phone' is now a valid notification option for patrons on both staff and OPAC side
3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt should succeed
4. Set up the patron for notices to triggers:
a. include checked out items due in a range of days, including the value set up in their messaging preferences.
b. place several holds, some in position, others waiting for pickup, others in transit.
c. set the patron up to have overdues, overdue by a range of days that includes the delay values for
the patrons branch and categorycode
5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE --type=OVERDUE --outfile=/tmp/talkingtechtest.csv
The resulting talkingtechtest.csv file should include all the items due on X days (where X is the patrons' preference),
and none of the ones due in other increments. Similarly, overdues messages should be added for each item due by a delay
value as configured; overdues of other numbers of days should be ignore. Holds that are waiting pick up or in transit should
have messages, those still pending should not.
Messages should be added to the patron's notices tab for each issue sent. Verify these messages exist, and all Notices
tokens are replaced with appropriate information.
Repeat, this time with 4c making use of the default branch overdue triggers, instead of branch-specific triggers.
To test the inbound script, create a CSV with rows in the format "<<Message_id>>","<<SUCCESS or FAIL>>"
Message ID should correspond to the final column of the talkingtechtest.csv file (the transaction id) for the message.
Primary Authorship: Ian Walls
Additional modifications: Kyle M Hall
http://bugs.koha-community.org/show_bug.cgi?id=4246
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested and in use in production by two public libraries : Middletown
and Washoe. Both have given their sign off, but don't have git to
actually sign off.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 24 Apr 2012 14:49:15 +0000 (10:49 -0400)]
Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version
Current jQuery-driven tabs are done using a very old
version of the tabs plugin. This patch upgrades jQueryUI
to the latest version and adds the tabs widget dependency
to the jqueryui js file and updates the syntax for existing
tabs:
- $("#foo > ul").tabs(); changes to $("#foo").tabs();
- Remove full URL from tab links (use #anchor only).
Pages with "static" tabs (tabs which are built in the
markup rather than generated by the plugin) have been
modified to use their own style. Examples: pay.tt in
the staff client and opac-readingrecord.tt in the OPAC.
Edit: Minor revision to some uncorrected markup
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Sun, 10 Jun 2012 09:54:59 +0000 (10:54 +0100)]
Bug 8201: Receive date not passed through correctly
All orders were received with today's date instead of the receive date
given with the invoice number.
To test:
1) Add an order with a few order lines
2) Create a new invoice, receive date != today's date
3) Start receiving orders, check date on receive screens is correct
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mason James [Wed, 23 May 2012 19:52:14 +0000 (07:52 +1200)]
Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm
Subroutine prototypes used at line XXX, column 1. See page 194 of PBP.
(Severity: 5)
Note: Rebased on master 06/09/2012 by jcamins
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mason James [Wed, 23 May 2012 16:32:17 +0000 (04:32 +1200)]
Bug 6679: Fixing 5 perlcritic violations in opac/*
1 more to go... :)
opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1.
See page 429 of PBP. (Severity: 5)
Note: Rebased on master 06/09/2012 by jcamins
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mason James [Wed, 23 May 2012 20:57:07 +0000 (08:57 +1200)]
Subroutine prototypes used at line XXX, column 1. See page 194 of PBP.
(Severity: 5)
Note: Rebased on master 06/09/2012 by jcamins
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Mason James [Wed, 23 May 2012 21:01:57 +0000 (09:01 +1200)]
Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm
Subroutine prototypes used at line XXX, column 1. See page 194 of PBP.
(Severity: 5)
Note: Rebased on master 06/09/2012 by jcamins
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Tue, 5 Jun 2012 10:06:23 +0000 (12:06 +0200)]
Bug 4838 Fix repeated authorities selection
How to test:
Create an authority, with more than one heading, for example a
UNIMARC multilingual author:
200 $7 da
$a 原
$b 純輔
200 $7 ba
$a Hara
$b Junsuke
In data entry form, on 700 field, you click on ... Search for the above author.
In auhtority search result page, you just have a 'Choose' link, and so you just
can select the first heading (in Chinesse writing).
Apply the patch. Repeat. Now you have, on result page, you have two links, and
can select one heading or the other.
Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Sun, 10 Jun 2012 12:06:03 +0000 (14:06 +0200)]
Merge remote-tracking branch 'origin/new/bug_7747'
Owen Leonard [Fri, 1 Jun 2012 14:09:30 +0000 (10:09 -0400)]
Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI
This patch removes the template calls to the now-obsolete
YUI JS dependencies and removes the relevant YUI files themselves.
First two work perfectly, circulation search header and overdues patron
authorized value. Authorities search does not seem to work, old yui file
are still referenced in auth_finder.tt. The jquery works, but data set
is not found, or I messed up my authority record.
Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Mon, 12 Sep 2011 19:50:18 +0000 (15:50 -0400)]
Fix for Bug 6855 - List bullet showing in wrong place on error message
Added some more specific CSS to help Webkit browsers display
the lists bullets correctly.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 9 June 2012. Signing off as well, since the rebase and test
were trivial.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Amit Gupta [Wed, 30 May 2012 07:07:33 +0000 (12:37 +0530)]
Bug 8166 - Adding new currencies & exchange rates
if not fill any field it save blank record
To Test:
1) Go to Currencies & Exchange rates.
2) Create New currency
3) If you not fill any field for ex: (Currency, rate, symbol)
it will not save the record.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Sun, 10 Jun 2012 11:56:26 +0000 (13:56 +0200)]
Adding Shari Perkins as contributor
(she submitted some patches for online help)
Sophie Meynieux [Fri, 23 Mar 2012 14:02:22 +0000 (15:02 +0100)]
Bug 7815 : Order pickup libraries list by name rather than by code
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Fri, 1 Jun 2012 13:22:30 +0000 (15:22 +0200)]
Bug 8178 - circ/circulation.pl under plack duplicates checkout rows
Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)
This also fixes %renew_failed initialization on each request.
Test scenario:
1. start intranet under plack
2. open /cgi-bin/koha/circ/circulation.pl and reload page few time
confirming that rows gets duplicated
3. apply patch and reload page to verify that it works
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Sat, 9 Jun 2012 11:04:48 +0000 (07:04 -0400)]
Bug 6141 - html glitches causing problems to translator
* opac-topissue.pl = untranslatable string removed
* authorities.pl missing _() in javascript
Rewrite of patch authored by Julian Maurice.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Sat, 9 Jun 2012 10:43:56 +0000 (11:43 +0100)]
Bug 8217:[SIGNED-OFF] Focus on search box in staff detail page
Signed-off-by: Marc Veron <veron@veron.ch>
Works exactly as expected.
Adds onload="document.getElementById('search-form').focus() to HTMP body.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Robin Sheat [Wed, 23 May 2012 05:24:21 +0000 (17:24 +1200)]
Bug 8139 - add margin to recent comments CSS to fix stuff with menus
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Simple CSS change, fixes the problem with left navigation
overlapping list of recent comments on small screens in OPAC.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Kyle M Hall [Wed, 25 Apr 2012 12:33:21 +0000 (08:33 -0400)]
Bug 8005 - Lost item is not anonymized when checked in
This bug is caused by the subroutine C4::Circulation::LostItem
not passing the privacy parameter when calling
C4::Circulation::MarkIssueReturned.
This issue is actually anonymized when the item is marked as lost,
not when the item is checked in.
Note, even if the issue is anonymized, the fine charged for lost
items still contains a description of the lost item, which is
required for the ability to forgive fees for lost items that
are later found.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 5 Jun 2012 16:54:52 +0000 (12:54 -0400)]
Bug 8184 - Duplicate budget page lacks heading and breadcrumbs
Adding title, heading, and breadcrumbs for "duplicate a budget"
operation. Also:
- adding cancel link for duplicate and edit
- correcting the CSS so that the "edit" menu button
is styled like an edit button.
operations.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Lyon3 Team [Sat, 9 Jun 2012 10:06:49 +0000 (11:06 +0100)]
Bug 7652: Add item barcode on top of its editing form
Signed-off-by: Adrien Saurat <adrien.saurat@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
christophe croullebois [Wed, 6 Jun 2012 13:14:15 +0000 (15:14 +0200)]
Bug 8197 : Software error when you have cleaned cookies and try to past the url to opac-topissues.pl
Try to delete cookies and paste the url to opac-topissues.pl.
Without the patch we have a Software error.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Fridolyn SOMERS [Mon, 22 Aug 2011 13:14:24 +0000 (15:14 +0200)]
BUG5312 XHTML correction in authority summary
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Dobrica Pavlinusic [Thu, 5 Apr 2012 13:41:29 +0000 (15:41 +0200)]
Bug 7872 - C4::Items::GetItemsInfo should use C4::Koha instead of SQL queries directly
This simplifies code, and has nice side-effect that memoize of
C4::Koha functions will be more effective.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marc Veron [Fri, 8 Jun 2012 11:40:31 +0000 (13:40 +0200)]
Bug 7586 - Search: Language restriction does NOT show expected results (no items shown)
modified: etc/zebradb/marc_defs/marc21/biblios/record.abs
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Sun, 10 Jun 2012 08:54:39 +0000 (10:54 +0200)]
Bug 7601 follow-up DBRev number
Marc Veron [Fri, 8 Jun 2012 15:39:39 +0000 (17:39 +0200)]
Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng")
When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French.
Test:
- Apply patch
- Edit preference DefaultLanguageField008, fill in e.g. 'ger'
- Go to Cataloguing, Add marc Record
- Click in field 008. Language code should read 'ger' (instead of 'eng')
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Paul Poulain [Sun, 10 Jun 2012 08:41:34 +0000 (10:41 +0200)]
Merge remote-tracking branch 'origin/new/bug_7936'
Shari Perkins [Wed, 6 Jun 2012 21:27:25 +0000 (17:27 -0400)]
Bug 7936 followup: Copyediting Help Files
Copyedited Admin Help Files beginning with the letter "a."
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Shari Perkins [Tue, 5 Jun 2012 21:09:16 +0000 (17:09 -0400)]
Bug 7936 followup: Copyedited Offline Circ help files
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Shari Perkins [Tue, 5 Jun 2012 20:58:55 +0000 (16:58 -0400)]
Bug 7936 followup: Copyedited Acquisitions help files
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 13 Apr 2012 18:02:53 +0000 (14:02 -0400)]
Bug 7936: Serials Help for 3.8
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Fri, 13 Apr 2012 18:01:35 +0000 (14:01 -0400)]
Bug 7936: Offline Circ Help
This is missing a new file for the Firefox plugin because
I haven't documented it yet because I can't get it to work.
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Thu, 12 Apr 2012 16:47:27 +0000 (12:47 -0400)]
Bug 7936: Admin Help files for 3.8
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Nicole C. Engard [Thu, 12 Apr 2012 16:02:56 +0000 (12:02 -0400)]
Bug 7936: Acq Help Files for 3.8
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Mon, 4 Jun 2012 08:06:22 +0000 (10:06 +0200)]
Bug 8062 [SIGNED-OFF] Perl module dependency Template::Plugin::HtmlToText
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Mon, 14 May 2012 07:57:50 +0000 (09:57 +0200)]
Bug 8062 [SIGNED-OFF] Cart email broken for non english templates
Fix basket email sent from OPAC. The email body is now generated HTML
(to be translatable), and converted into TEXT before beeing sent by
email.
To test that it works in other language than English, you have to update
your language .po file:
perl translate update de-DE
Then, translated strings coming from opac-sendbasket.tt, and install the
translation:
perl translate install de-DE
New dependency: Template::Plugin::HtmlToText
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Paul Poulain [Sat, 9 Jun 2012 16:50:38 +0000 (18:50 +0200)]
Bug 7951 follow-up DBRev
Kyle M Hall [Fri, 13 Apr 2012 15:12:29 +0000 (11:12 -0400)]
Bug 7951 - Suspending holds needs a system preference
Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Paul Poulain [Sat, 9 Jun 2012 16:26:52 +0000 (18:26 +0200)]
Bug 5337 DBRev number
Matthias Meusburger [Mon, 16 Jan 2012 13:47:26 +0000 (14:47 +0100)]
Bug 5337: EAN management : Adds ean for various searches
- in various acquisition pages and serials home
- in database : biblioitems.ean
- adds ean and its mapping in default english bibliographic framework
- adds ean mapping in default french bibliographic framework
- ean search is not enabled for MARC21
The required mapping between the ean marc field and the biblioitems.ean
database field will be automatically added on an existing unimarc installation.
However, if you already have records with ean, you will have to
run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean
Signed-off-by: jmbroust <jean-manuel.broust@univ-lyon2.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passed QA at second run. Removed a merge marker only.
Paul Poulain [Sat, 9 Jun 2012 14:28:00 +0000 (16:28 +0200)]
bug 8167 follow-up: DBRev number
Kyle M Hall [Wed, 11 Apr 2012 13:55:55 +0000 (09:55 -0400)]
Bug 8167 - Add syspref allow a choice of blocking, non-blocking, or do nothing when issuing lost items.
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Works as advertised.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Fri, 25 May 2012 06:10:19 +0000 (08:10 +0200)]
Bug 6267: [SIGNED-OFF]Fix a typo
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marcel de Rooy [Thu, 22 Mar 2012 10:59:01 +0000 (11:59 +0100)]
Bug 7805: Exposing the new list permissions in opac and staff
This report builds on 7310.
Had to correct some lines in ModShelf and AddShelf as well in order to
save 0 values correctly for the permission columns.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Mon, 28 May 2012 14:07:35 +0000 (10:07 -0400)]
Bug 8092 follow-up: Add optional dependency on CHI
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Tue, 15 May 2012 17:03:30 +0000 (13:03 -0400)]
Bug 8092: Convert Koha::Cache to use CHI
Implements cache handlers for Memcached, mmap shared-file persistent,
and in-process memory caches. If CHI is unavailable, Koha::Cache::Memcached
will fall back to using Cache::Memcached::Fast, or caching will be skipped
without croaking.
To test: run t/Cache.t with the following options, before and after
installing CHI:
2. Tests 3-9 should be skipped with the following:
export CACHING_SYSTEM=
2. You should receive two failures with the following if CHI is not installed:
export CACHING_SYSTEM=memory
3. You should receive two failures with the following if CHI is not installed:
export CACHING_SYSTEM=fastmmap
4. You will need memcached activated for the following to work (but it
will work both with and without CHI):
export CACHING_SYSTEM=memcached
export MEMCACHED_SERVERS=127.0.0.1:11211
export MEMCACHED_NAMESPACE=KOHA
5. You should receive two failures with the following:
export CACHING_SYSTEM=thisdoesntexist
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Works as advertised, now we need a follow up to add the new dependency.
http://bugs.koha-community.org/show_bug.cgi?id=8029
Jonathan Druart [Wed, 6 Jun 2012 10:56:56 +0000 (12:56 +0200)]
Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron
Test scenario:
1. make sure that you have ExtendedPatronAttributes enabled
2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0
(you might need to modify categorycode according to your local config)
3. verify that you get all extended patron attributes in form
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Tue, 22 May 2012 09:31:32 +0000 (11:31 +0200)]
Bug 8119 - Followup Show hint when disabling active currency checkbox
Display the message on editing
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 18 May 2012 13:19:34 +0000 (09:19 -0400)]
Bug 8119 - Show hint when disabling active currency checkbox
Display a hint when the exchange rate != 1.0: "The active currency
must have a rate of 1.0"
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Jonathan Druart [Wed, 6 Jun 2012 08:18:01 +0000 (10:18 +0200)]
Bug 8195: Selected link must be bold (in admin and tools)
For several links, the selected entry is not bold, try with these pages:
admin/smart-rules.pl
admin/biblio_framework.pl
tools/export.pl
This patch fixes this behaviour
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 5 Jun 2012 16:23:18 +0000 (12:23 -0400)]
Bug 8187 - [SIGNED-OFF] Batch patron modification missing from tools sidebar menu
Adding a link to the tools sidebar menu for batch patron modification.
Also changing the link text on the Tools home page to make it
somewhat clearer.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Frédéric Demians [Fri, 6 Apr 2012 17:39:03 +0000 (19:39 +0200)]
Bug 7818 Add UNIMARC biblio records zebra DOM def files
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I tested two UNIMARC Koha installations using the sample UNIMARC
data from the BibLibre sandbox, comparing the results with DOM
and with GRS-1 indexing. The results are very similar, though there
are some differences. Most noticeable:
* relevance and facets seem to be more accurate with DOM enabled
* the GRS-1 configuration returns approximately 10% more results with
random single keywords like "petit," but the DOM results contain
the most relevant items, and any lacks in the configuration can
easily be corrected as UNIMARC users identify fields that should be
indexed but aren't
* authority-controlled searches match exactly
* author and topic facets do not work with the out-of-the-box GRS-1
indexing configuration (?!?)
(adding second sign-off line below because all that probably looks like
a commit message and not a sign off)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 6 Apr 2012 15:26:12 +0000 (11:26 -0400)]
Bug 7818: add warning about not editing record.abs when using DOM filter
This commit also updates the authority and biblio DOM indexing definition
XSL to include updated header comments.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 6 Apr 2012 15:18:55 +0000 (11:18 -0400)]
Bug 7818: update comment to clarify availability of DOM index mode
DOM indexing is now available for both bibs and authorities.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 6 Apr 2012 04:48:04 +0000 (00:48 -0400)]
Bug 7818: use Title-cover for title phrase weighting
This is offerred as a compromise alternative to creating
a new Title-rel index to avoid having the statement of
responsiblity unduly affect field weight when using the DOM
filter and MARC21 -- the problem with creating a Title-rel index
is that it would *force* reindexing upon upgrade.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 6 Apr 2012 04:05:46 +0000 (00:05 -0400)]
Bug 7818: -x option of rebuild_zebra.pl now works with DOM filter
One consequence is that the -x and -a options are no longer
mutually exclusive.
Also, because of the way that the GRS-1 SGML filter works, if you're
indexing multiple documents, you can't just wrap them in a document
element, but the DOM filter *requires* it. Consequently, two
new config settings in koha-conf.xml are added to indicate the
Zebra filter in use so that the -x option of rebuild_zebra.pl
knows whether to wrap the exported records or not:
- bib_index_mode (defaults to 'grs1' if not specified)
- auth_index_mode (defaults to 'dom')
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Mon, 26 Mar 2012 05:16:11 +0000 (01:16 -0400)]
Bug 7818: Zebra DOM filter index definitions for MARC21 bibs
The file biblio-zebra-indexdefs.xsl, which is the stylesheet that
is used by the Zebra DOM filter to convert an incoming MARC21 bib
to its indexed form, was generated by the following two steps:
misc/maintenance/make_zebra_dom_cfg_from_record_abs \
--input etc/zebradb/marc_defs/marc21/biblios/record.abs \
--output etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \
etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \
> etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Records indexed using this XSLTshould behave similarly to records
indexed using the GRS-1 filter and the old record.abs definition, with
the following big exception (and improvemwent): indexed phrases now
span subfield boundaries if a specific subfield wasn't specified in the
index definition. For example, the GRS-1 filter index definition
melm 245 Title
would allow 245 $a Cats on boxes : $b cardboard fantasies
to be searched as the phrases "cats on boxes" or "cardboard fantasies",
but a title phrase seach of "cats on boxes cardboard fantasises"
wouldn't work. The DOM filter equivalent,
<index_data_field xmlns="http://www.koha-community.org/schemas/index-defs" tag="245">
<target_index>Title:w</target_index>
<target_index>Title:p</target_index>
</index_data_field>
*does* allow phrase searches to span subfield boundaries.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Mon, 26 Mar 2012 05:10:09 +0000 (01:10 -0400)]
Bug 7818: add index_data_field option to DOM indexing repertoire
Adds a new kohaidx:index_data_field index definition type which
indexes all of the subfields of a MARC data field as a single
phrase, separating the contents of each with a space.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Mon, 26 Mar 2012 05:08:58 +0000 (01:08 -0400)]
Bug 7818: move koha-indexdefs-to-zebra.xsl
Since the koha-indexdefs-to-zebra.xsl stylesheet will be used
by both bib and authority indexing, put in a central location.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Mon, 26 Mar 2012 05:05:58 +0000 (01:05 -0400)]
Bug 7818: utility to generate DOM indexing configs
misc/maintenance/make_zebra_dom_cfg_from_record_abs:
generate a DOM filter Zebra index config from a GRS-1 config
Given a Zebra record.abs file containing a set of index definitions for
Zebra's GRS-1 filter, write an equivalent DOM filter configuration.
To generate the XSLT that is to be used by Zebra, run something like
the following on the output of this utility:
xsltproc ZEBRA_CFG_DIR/xsl/koha-indexdefs-to-zebra.xsl \
biblio-koha-indexdefs.xml \
> ZEBRA_CFG_DIR/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
The above example assumes that the output of the program was named
biblio-koha-indexdefs.xsl.
This commit also introduces Koha::Indexer::Utils, a new package for
misceallenous routines that support Koha's indexing definitions.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 23 Mar 2012 23:08:58 +0000 (19:08 -0400)]
Bug 7818: update miscellaneous installer scripts
Teach a couple of the quick-install scripts about
DOM mode for bibs.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Galen Charlton [Fri, 23 Mar 2012 22:52:27 +0000 (18:52 -0400)]
Bug 7818: update installer for biblio DOM indexing
Adds the necessary bits to enable DOM indexing for bib
records as an option during installation from source.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Srdjan [Mon, 28 May 2012 00:12:34 +0000 (12:12 +1200)]
bug_8138: added 773$t field to search results
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Colin Campbell [Fri, 1 Jun 2012 07:10:21 +0000 (08:10 +0100)]
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
warnings in log because of undefined value in
string concatenation
variable should be initialized to empty string rather
than left undefined
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Removes a warning in logs
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Fri, 18 May 2012 14:46:01 +0000 (10:46 -0400)]
Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items
This patch modifies the permissions required to access the cataloging
home page (addbooks.pl) so that the user requires edit_catalogue,
edit_items, or fast_cataloging permission.
Users with only edit_catalogue permission will only see biblio edit
links. Users with edit_items permission will only see item edit
links. Users with fast_cataloging permission will only be able to
view information about contents of the catalog--useless for them
but I'm not sure how better to handle it.
To test, log in as a user with each of the above permissions
enabled separately and in combination and test access.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Fri, 1 Jun 2012 22:29:52 +0000 (10:29 +1200)]
Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results
Paul Poulain [Tue, 5 Jun 2012 14:22:44 +0000 (16:22 +0200)]
Merge remote-tracking branch 'origin/new/bug_8182'
Paul Poulain [Tue, 5 Jun 2012 14:22:30 +0000 (16:22 +0200)]
Bug 8182 follow-up, fixing BLO typo mistake
Colin Campbell [Thu, 18 Aug 2011 15:48:44 +0000 (16:48 +0100)]
Bug 3638 : Captured Holds may need to generate a transfer
If a discharged item is captured for a hold at another branch
the selfcheck should generate a branchtransfer for it.
This was complicated as the checkin routine was setting its own
location from a field not set in many scm machines (e.g. 3M)
also in ILS::Transaction the test for location was incorrect
assuming that an empty string or undefined was a valid location
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Colin Campbell [Mon, 4 Jul 2011 15:44:16 +0000 (16:44 +0100)]
Bug 3638 Self Check Should Capture Hold Items
Shelf Check was receiving messages saying item was wanted
for a hold but the item was discharged to the shelf
not associated with the hold or transited to
the pickup location. The message was also being sent
on discharge of items when a suitable item had already
been captured.
Checkin now associates the item with the hold and sets
the appropriate data for a correct checkin response
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Kyle M Hall [Fri, 1 Jun 2012 18:30:05 +0000 (14:30 -0400)]
Bug 8182 - Problem with overdue fine calculations after upgrade
Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26. When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin. Therefore the
patron is being charged double overdue fines from the original date up to 5/26.
This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead.
This is an unusual patch as it modifies a previous database update. This
make sense because if a install has already been updated past the db rev
update, this fix will be too late. It will only help those that have not
updated past that db revision.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 29 May 2012 15:30:28 +0000 (11:30 -0400)]
Bug 8160 - Link to cataloging appears for users without cataloging permission
This patch wraps cataloging links on the staff client home
page and in the header menu with checks for edit_catalogue
OR edit_items permission.
To test, access the staff client as a user with various
permissions. The "cataloging" link on the main page and
in the header menu should only appear to a user with
edit_catalogue permission, edit_items permission, or both.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Mon, 14 May 2012 01:48:53 +0000 (13:48 +1200)]
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, changes are as advertised.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Tue, 5 Jun 2012 13:54:50 +0000 (15:54 +0200)]
Welcome to Piotr Kowalski, that is 183th
Piotr Kowalski [Mon, 28 May 2012 09:50:49 +0000 (21:50 +1200)]
Bug 8116 : Fixing warn in error log
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Wed, 16 May 2012 16:44:56 +0000 (12:44 -0400)]
Bug 8111 - Language chooser display problem in self-checkout
- Adds required JavaScript and JavaScript linked files
- Updates CSS with changes relevant to this feature which had
been made to the main CSS file.
- Removes an image file which has been made obsolete now that
sco.css uses the main image sprite like opac.css does.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jared Camins-Esakov [Mon, 28 May 2012 23:27:45 +0000 (19:27 -0400)]
Bug 7847: OPAC search dies with Plack
Due to a dependency cycle between C4::Search and C4::Items, searches
in the OPAC die spectacularly under Plack. This counter-patch extends
dpavlin's solution and replaces use with require for C4::Search in
C4::Items and for C4::Items in C4::Search.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 22 May 2012 18:42:42 +0000 (14:42 -0400)]
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings
To simplify the sentence structure for better translation flexibility
the message now reads:
"Item in your cart: " + number
Fixed in both OPAC and staff client, although I'm not sure
the message is actually triggered in the staff client.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Strings become translatable
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Liz Rea [Tue, 29 May 2012 21:06:22 +0000 (16:06 -0500)]
Bug 8129 - Quickslips not printing
Implemented from the suggestions attached to the bug.
To test:
Check out a book to a patron
Click print -> quick slip
Slip should show only today's checkouts.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Wed, 16 May 2012 13:27:59 +0000 (09:27 -0400)]
Bug 8108 - Remove unused images from the OPAC
Removing image files which are no longer used. Some have been
replaced by a sprite, some by CSS gradients, and some are
simply left behind from previous designs.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Jared Camins-Esakov [Sat, 26 May 2012 12:48:15 +0000 (08:48 -0400)]
Bug 8159: Fix error in kohastructure.sql
Adds a missing semicolon.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 29 May 2012 14:57:41 +0000 (10:57 -0400)]
Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI
This follow-up removes the default jQueryUI images and amends the
staff client CSS to override calls to those images with a "Koha-
native" style.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Tue, 24 Apr 2012 14:49:15 +0000 (10:49 -0400)]
Bug 7747 - Replace YUI autocomplete with jQueryUI
In order to facilitate a more painless process for converting
to jQueryUI I will submit separate patches for various "widgets,"
starting with Autocomplete.
This patch replaces all instances of YUI autocomplete with
a jQueryUI version. The patch includes an up-to-date version
of jQuery and jQueryUI libraries.
The patch also moves some markup in instances where it should
have been removed in favor of a different include.
To test, find the various autocomplete instances and confirm
that they are working:
- Circulation search header autocomplete
- Overdues patron attribute authorized value filter (must
have patron attributes enabled, and a patron attribute
defined which uses authorized values.
- Authorities search plugin. Edit a MARC record and use
an authorities plugin link to do a search for authority
records.
Incomplete: There is a YUI autocomplete instance in a UNIMARC
plugin (unimarc_field_210c_bis.tt) which I couldn't figure out
how to test, even on a sandbox set up with UNIMARC. I could use
help with a follow-up.
http://bugs.koha-community.org/show_bug.cgi?id=7447
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passes all tests outlined, is quite pretty.
Passes t xt
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Kyle M Hall [Wed, 23 May 2012 11:43:59 +0000 (07:43 -0400)]
Bug 8140 - [SIGNED-OFF] Error when exporting label xml
It appears that the name of a variable was changed,
but the declaration of said variable was not.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Mon, 21 May 2012 08:06:36 +0000 (20:06 +1200)]
Bug 4330 : Adding copyright headers and fixing FSF addresses
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 23:03:21 +0000 (11:03 +1200)]
Bug 4330 : Fixing FSF address and copyright headers for acqui/
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:45:50 +0000 (22:45 +1200)]
Bug 4330 : Last of the opac files with wrong FSF address
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:30:41 +0000 (22:30 +1200)]
Bug 4330 : Adding missing license statement
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:27:29 +0000 (22:27 +1200)]
Bug 4330 Fixing FSF statements
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 10:14:04 +0000 (22:14 +1200)]
Bug 4330 : Fixing FSF address and copyright statements
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Chris Cormack [Sun, 20 May 2012 09:55:55 +0000 (21:55 +1200)]
Bug 4330 : Fixing FSF address and copyright headers
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Owen Leonard [Thu, 24 May 2012 14:17:31 +0000 (10:17 -0400)]
Bug 7127 - Templates must be valid XHTML
Fixing markup errors on OPAC detail page and OPAC results.
Also conditionally including ratings JS on OPAC detail.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Paul Poulain [Mon, 28 May 2012 15:36:32 +0000 (17:36 +0200)]
Bug 8144 - 775 tag in the MARC record causes display issue
Fixing XSL template in the OPAC and staff client following
recommendations by Jared.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Fixes the markup and correctly displays 775 notes.
Mason James [Wed, 23 May 2012 20:17:07 +0000 (08:17 +1200)]
Bug 8145 - [SIGNED-OFF] opac-tags.pl fails when DEBUG is set
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>