]> git.koha-community.org Git - koha.git/log
koha.git
15 years ago(bug #3198) fix serial receive with autobarcode
Nahuel ANGELINETTI [Mon, 11 May 2009 08:46:58 +0000 (10:46 +0200)]
(bug #3198) fix serial receive with autobarcode

this add an arg to GetMarcFromKohaField, else it will always return (0,0).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding the irc meeting and maintenance tree to the history
Chris Cormack [Sun, 10 May 2009 09:49:23 +0000 (21:49 +1200)]
Adding the irc meeting and maintenance tree to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3213 - UNIMARC/MARC21 selection
Frédéric Demians [Mon, 11 May 2009 11:41:49 +0000 (13:41 +0200)]
Bug 3213 - UNIMARC/MARC21 selection

Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.

DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3213 - Add UNIMARC XSLT stylesheet
Frédéric Demians [Mon, 11 May 2009 11:41:50 +0000 (13:41 +0200)]
Bug 3213 - Add UNIMARC XSLT stylesheet

With those stylesheets result and detail pages
render better UNIMARC biblio record than normal
views. But works still have to be done in order
to reach UNIMARC-ISBD compliant display.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMore fixes for Bug 2704, 440 Display Issues
Owen Leonard [Thu, 30 Apr 2009 16:36:19 +0000 (11:36 -0500)]
More fixes for Bug 2704, 440 Display Issues

Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3195 : Item Transfers and Holds disrupted.
Ryan Higgins [Thu, 7 May 2009 18:19:05 +0000 (11:19 -0700)]
bug 3195 : Item Transfers and Holds disrupted.

This follows revert of commit 257a439d (bug 3025).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRevert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"
Ryan Higgins [Thu, 7 May 2009 18:19:04 +0000 (11:19 -0700)]
Revert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"

This reverts commit 257a439dafa33d0c642f1ec7badedb5414027e64.
This patch causes Bug 3195 .

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3190) allow right truncation in lot of records
Nahuel ANGELINETTI [Wed, 6 May 2009 08:50:51 +0000 (10:50 +0200)]
(bug #3190) allow right truncation in lot of records

This patch just add an option to zebra-biblios.cfg that allow to make right truncate requests on a huge request.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3174) show the member name in reports
Nahuel ANGELINETTI [Mon, 4 May 2009 15:16:45 +0000 (17:16 +0200)]
(bug #3174) show the member name in reports

this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2287: handle case where autoMemberNum is off
Galen Charlton [Fri, 8 May 2009 13:44:03 +0000 (08:44 -0500)]
bug 2287: handle case where autoMemberNum is off

When importing a patron file where new records
do not have a card number *and* autoMemberNum is
off, make sure that bororwers.cardnumber is set to NULL
for those new patrons rather than '' - otherwise, only
one patron with an empty barcode can be created, as there is
a uniqueness constraint on borrowers.cardnumber

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow autogenerated cardnumbers again to solve http://bugs.koha.org/cgi-bin/bugzilla3...
MJ Ray [Tue, 5 May 2009 15:52:47 +0000 (16:52 +0100)]
Allow autogenerated cardnumbers again to solve http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2287

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3183) fix the SetMarcUnicodeFlag function
Nahuel ANGELINETTI [Mon, 4 May 2009 09:22:15 +0000 (11:22 +0200)]
(bug #3183) fix the SetMarcUnicodeFlag function

This patch fix the funciton SetMarcUnicodeFlag for UNIMARC support, now the function will fix the length of the field, and set encoding as "50  " instead of "5050".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoOptimize XSLT.pm
Frédéric Demians [Thu, 7 May 2009 17:28:33 +0000 (19:28 +0200)]
Optimize XSLT.pm

Avoid reading marc_tag_structure for each biblo record to
transform by XSLT. Not totaly useless on OPAC result page.
Should be done via application variables rather than
request variable, but this is another story.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd system preference search to administration home page (Bug 3181)
Owen Leonard [Sat, 2 May 2009 18:35:14 +0000 (13:35 -0500)]
Add system preference search to administration home page (Bug 3181)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]
Frédéric Demians [Thu, 7 May 2009 16:57:26 +0000 (18:57 +0200)]
Bugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]

Thanks G. Henry

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix all templates errors reported by xt/author/valid-templates.t
Galen Charlton [Fri, 1 May 2009 22:59:04 +0000 (17:59 -0500)]
fix all templates errors reported by xt/author/valid-templates.t

In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2944 fix courtesy of Amr Denni
Chris Cormack [Sun, 3 May 2009 05:02:22 +0000 (17:02 +1200)]
Bug 2944 fix courtesy of Amr Denni

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Colin Campbell [Thu, 7 May 2009 13:59:25 +0000 (14:59 +0100)]
(bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoSpelling correction
Owen Leonard [Sat, 2 May 2009 16:40:50 +0000 (11:40 -0500)]
Spelling correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding David Birmingham and Collin Campbell as a developer
Chris Cormack [Fri, 1 May 2009 23:50:16 +0000 (11:50 +1200)]
Adding David Birmingham and Collin Campbell as a developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMoved some variable definitions out of conditionals
Colin Campbell [Tue, 5 May 2009 09:36:41 +0000 (10:36 +0100)]
Moved some variable definitions out of conditionals

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3081 - The category code in the patron personal details page in opac showed the...
Garry Collum [Sun, 3 May 2009 04:23:14 +0000 (00:23 -0400)]
Bug 3081 - The category code in the patron personal details page in opac showed the category code and not the description. This patch makes the description appear instead. Looking at both opac-userupdate.pl and opac-userupdate.tmpl, the actual value of this text box is not retrieved for any purpose.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3193) fix the comtd value in acqui-home.pl
Nahuel ANGELINETTI [Wed, 6 May 2009 10:26:55 +0000 (12:26 +0200)]
(bug #3193) fix the comtd value in acqui-home.pl

this patch fix the value of the comtd value which is not the same as in bookfund.pl, clicking on the value from acqui-home.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemove duplicate assignments for $template->param(script_name)
Joe Atzberger [Mon, 4 May 2009 20:16:01 +0000 (15:16 -0500)]
Remove duplicate assignments for $template->param(script_name)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3157: IE compatibility for label display
Joe Atzberger [Wed, 6 May 2009 19:41:51 +0000 (14:41 -0500)]
Bug 3157: IE compatibility for label display

Also fixed validation errors where label elements were "for" non-existant ids.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChanges to tabindex values to improve keyboard access.
Owen Leonard [Mon, 9 Mar 2009 13:38:06 +0000 (08:38 -0500)]
Changes to tabindex values to improve keyboard access.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2750) Cannot return to another branch if the independantbranch option is set...
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON

The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleaning up Self-Checkout interface, adding some basic formatting based on other...
Owen Leonard [Wed, 26 Nov 2008 20:46:07 +0000 (14:46 -0600)]
Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.

Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdateDatabases for 3.0.2
Henri-Damien LAURENT [Wed, 6 May 2009 13:42:19 +0000 (15:42 +0200)]
UpdateDatabases for 3.0.2

updating elements in order to make 3.0.2 work

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2687 followup: Increase maxlength attribute to support 64 characters
Danny Bouman [Thu, 20 Nov 2008 14:35:26 +0000 (09:35 -0500)]
bug 2687 followup: Increase maxlength attribute to support 64 characters

Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3177 - haspermission offers bogus option
Joe Atzberger [Thu, 30 Apr 2009 15:04:38 +0000 (10:04 -0500)]
Bug 3177 - haspermission offers bogus option

$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding link back to OPAC for emailed cart and lists.
Owen Leonard [Tue, 21 Apr 2009 19:12:55 +0000 (14:12 -0500)]
Adding link back to OPAC for emailed cart and lists.

Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3141: use quoted printable encoding in cart/list emails
Galen Charlton [Sat, 18 Apr 2009 23:25:42 +0000 (18:25 -0500)]
bug 3141: use quoted printable encoding in cart/list emails

Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding.  Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2908 followup - use "list", not "shelf"
Galen Charlton [Mon, 12 Jan 2009 22:16:47 +0000 (16:16 -0600)]
bug 2908 followup - use "list", not "shelf"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoSetting focus on form fields
Owen Leonard [Sat, 18 Apr 2009 21:45:22 +0000 (16:45 -0500)]
Setting focus on form fields

This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrected: fix for Bug 3112, Emailed list contains too much whitespace
Owen Leonard [Tue, 14 Apr 2009 19:46:58 +0000 (14:46 -0500)]
Corrected: fix for Bug 3112, Emailed list contains too much whitespace

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3187) authority search pagination doesn't work
Nahuel ANGELINETTI [Tue, 5 May 2009 09:52:36 +0000 (11:52 +0200)]
(bug #3187) authority search pagination doesn't work

this patch just set a marclist argument value on search authority, else the pagination won't work.

15 years ago(bug #3058) show items that are excluded of loan in search results
Nahuel ANGELINETTI [Wed, 25 Mar 2009 16:34:31 +0000 (17:34 +0100)]
(bug #3058) show items that are excluded of loan in search results

This patchs show all items that are available for reading to the library but excluded of loan.
And don't show them as same way as "damaged" or other "not for loan" status.

15 years ago(bug #3057) mandatory subfield edition
Nahuel ANGELINETTI [Wed, 25 Mar 2009 15:08:48 +0000 (16:08 +0100)]
(bug #3057) mandatory subfield edition

modify the "name" of mandatory input field.

15 years ago(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD...
Nahuel ANGELINETTI [Mon, 23 Mar 2009 16:14:30 +0000 (17:14 +0100)]
(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view

this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.

15 years ago(bug #3051) bad support of pagination in auth_finder
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:00:03 +0000 (13:00 +0100)]
(bug #3051) bad support of pagination in auth_finder

This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

15 years ago(bug #3025) multiple check-in of a multiple times reserved item go wrong
Nahuel ANGELINETTI [Tue, 10 Mar 2009 14:24:47 +0000 (15:24 +0100)]
(bug #3025) multiple check-in of a multiple times reserved item go wrong

This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something).

15 years ago(bug #3011) csv export doesn't fill all the fields
Nahuel ANGELINETTI [Fri, 6 Mar 2009 11:24:29 +0000 (12:24 +0100)]
(bug #3011) csv export doesn't fill all the fields

This patch just fix the script which export to csv the overdue, and field the missing fields

15 years ago(bug #2939) delete a warning
Nahuel ANGELINETTI [Tue, 3 Feb 2009 08:45:48 +0000 (09:45 +0100)]
(bug #2939) delete a warning

just add a default value to $sep

15 years ago(bug #2938) add a serials subscriptions report
Nahuel ANGELINETTI [Fri, 30 Jan 2009 16:17:12 +0000 (17:17 +0100)]
(bug #2938) add a serials subscriptions report

this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

15 years ago(bug #2908) adding send shelf by e-mail feature
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:32:14 +0000 (10:32 +0100)]
(bug #2908) adding send shelf by e-mail feature

This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

15 years agoBug fix to OPAC shelf browsing query statement
David Birmingham [Thu, 30 Apr 2009 16:54:48 +0000 (12:54 -0400)]
Bug fix to OPAC shelf browsing query statement

If the items.location field was NULL, then the current
SQL query would produce no results.  I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.

In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open.  This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding warnings, fixing a bug that meant the title of an item that had a fine was...
Chris Cormack [Fri, 1 May 2009 21:39:25 +0000 (09:39 +1200)]
Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug #2974 Adding category code to BorrowerMandatoryField produced a "The following...
Garry Collum [Fri, 1 May 2009 01:54:31 +0000 (21:54 -0400)]
Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"

If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element.  The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank.  Added code to check for an empty string in the first
element.

You can test this by making salutation (title) mandatory.

Also fixed some typos in some of the comments.  Why?  Because I'm a Librarian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3174) fill borrower number, and show author and creation date in saved reports
Nahuel ANGELINETTI [Thu, 30 Apr 2009 09:36:52 +0000 (11:36 +0200)]
(bug #3174) fill borrower number, and show author and creation date in saved reports

This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agonew author test for syntax errors in HTML templates
Galen Charlton [Wed, 29 Apr 2009 21:51:11 +0000 (16:51 -0500)]
new author test for syntax errors in HTML templates

Added a new author test to look for syntax errors
in the HTML templates.  Run by doing

prove xt/author/valid-templates.t

from the root of a Koha source tree.

This test will help catch the following errors:

* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
  cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag

This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix XHTML validation error introduced in previous patch
Galen Charlton [Fri, 1 May 2009 21:17:26 +0000 (16:17 -0500)]
fix XHTML validation error introduced in previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoEnhancements/fixes for OPAC advanced search screen
Jane Wagner [Wed, 29 Apr 2009 18:14:56 +0000 (14:14 -0400)]
Enhancements/fixes for OPAC advanced search screen

Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemove unused $toggle code
Joe Atzberger [Thu, 30 Apr 2009 17:15:12 +0000 (12:15 -0500)]
Remove unused $toggle code

Some trivial other cleanups also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding the creation of sql library on the wiki
Chris Cormack [Thu, 30 Apr 2009 21:41:08 +0000 (09:41 +1200)]
Adding the creation of sql library on the wiki

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrect comparison which was using an octal number
Colin Campbell [Fri, 1 May 2009 08:32:27 +0000 (09:32 +0100)]
Correct comparison which was using an octal number

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding Liz Rea to the history.txt
Chris Cormack [Thu, 30 Apr 2009 03:33:13 +0000 (15:33 +1200)]
Adding Liz Rea to the history.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix to C4::Koha::_isbn_cleanup
Galen Charlton [Thu, 30 Apr 2009 18:06:24 +0000 (13:06 -0500)]
fix to C4::Koha::_isbn_cleanup

Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoVerbiage clarification in intranet advsearch.tmpl
root [Thu, 30 Apr 2009 16:42:23 +0000 (11:42 -0500)]
Verbiage clarification in intranet advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoLibraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Liz Rea [Thu, 30 Apr 2009 16:30:26 +0000 (11:30 -0500)]
Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoWhoops I typo'd Garry's name - fixed
Chris Cormack [Wed, 29 Apr 2009 21:52:13 +0000 (09:52 +1200)]
Whoops I typo'd Garry's name - fixed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUsability change: widened the search type dropdown from 9em to 10em so that it doesn...
root [Wed, 29 Apr 2009 18:14:45 +0000 (13:14 -0500)]
Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdating history docs for new developer
Chris Cormack [Wed, 29 Apr 2009 20:24:19 +0000 (08:24 +1200)]
Updating history docs for new developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUsability change: Added example of 5.00 to fines/manual credit and fines/manual invoi...
Liz Rea [Wed, 29 Apr 2009 16:22:53 +0000 (11:22 -0500)]
Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoOPAC Advanced Search - have user's branch selected by default
Michael Hafen [Tue, 28 Apr 2009 20:16:31 +0000 (14:16 -0600)]
OPAC Advanced Search - have user's branch selected by default

If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCheckout page - Check Out's table sortable on barcode
Michael Hafen [Tue, 28 Apr 2009 20:24:17 +0000 (14:24 -0600)]
Checkout page - Check Out's table sortable on barcode

Add the barcode column of the Check Out's table to the tablesorter
setup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agominPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorr...
Garry Collum [Wed, 29 Apr 2009 02:55:21 +0000 (22:55 -0400)]
minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3126: remove comma for IE7
Joe Atzberger [Tue, 28 Apr 2009 17:08:31 +0000 (12:08 -0500)]
Bug 3126: remove comma for IE7

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Chris Cormack [Tue, 28 Apr 2009 23:32:27 +0000 (11:32 +1200)]
Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBugs 2822, 2551, 3163 fixes to XSLT
Jane Wagner [Tue, 28 Apr 2009 12:01:25 +0000 (08:01 -0400)]
Bugs 2822, 2551, 3163 fixes to XSLT

Resent with additional comments.

Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music.  Modified record display to use Sound.

Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource.  Changed the record display page
to also use Continuing Resource.

Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display.  Modified the utils file
to force a space.

The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png).  Also, corrected spelling of icon name
from pencile.png to pencil.png.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix DOS newlines in MARC21slimUtils.xsl
Galen Charlton [Tue, 28 Apr 2009 13:58:05 +0000 (08:58 -0500)]
fix DOS newlines in MARC21slimUtils.xsl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2750) Cannot return to another branch if the independantbranch option is set...
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON

The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2961) change the workflow of the new issue
Nahuel ANGELINETTI [Mon, 27 Apr 2009 15:13:08 +0000 (17:13 +0200)]
(bug #2961) change the workflow of the new issue

This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2915 followup - small efficiency improvement
Galen Charlton [Mon, 27 Apr 2009 15:31:03 +0000 (10:31 -0500)]
bug 2915 followup - small efficiency improvement

Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.

No user-visible change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFollowup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
Joe Atzberger [Thu, 23 Oct 2008 20:56:22 +0000 (15:56 -0500)]
Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".

updatedatabase change deferred for now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrect iso639_2_code for Spanish is "spa" not "rus".
Joe Atzberger [Mon, 13 Oct 2008 16:46:14 +0000 (11:46 -0500)]
Correct iso639_2_code for Spanish is "spa" not "rus".

The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Joe Atzberger [Fri, 24 Apr 2009 22:31:53 +0000 (17:31 -0500)]
Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3161: don't display blank language chooser
Galen Charlton [Sun, 26 Apr 2009 16:45:24 +0000 (11:45 -0500)]
bug 3161: don't display blank language chooser

If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoWhoops missed Brendan's commit, fixed the history now
Chris Cormack [Mon, 27 Apr 2009 00:17:21 +0000 (12:17 +1200)]
Whoops missed Brendan's commit, fixed the history now

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2505: fix more warnings in opac-search.pl
Galen Charlton [Sun, 26 Apr 2009 15:23:55 +0000 (10:23 -0500)]
bug 2505: fix more warnings in opac-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2505 Adding use warnings, and fixing the warnings generated
Chris Cormack [Sat, 25 Apr 2009 04:49:48 +0000 (16:49 +1200)]
Bug 2505 Adding use warnings, and fixing the warnings generated

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix warning in C4::AuthoritiesMarc::merge()
Galen Charlton [Sun, 26 Apr 2009 14:48:42 +0000 (09:48 -0500)]
fix warning in C4::AuthoritiesMarc::merge()

"my" variable @X masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1200

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoimproved POD for C4::Serials::HasSubscriptionExpired()
Galen Charlton [Sun, 26 Apr 2009 14:48:41 +0000 (09:48 -0500)]
improved POD for C4::Serials::HasSubscriptionExpired()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd items.itemnotes to the Notes/Comments search in Marc21
Michael Hafen [Thu, 20 Nov 2008 18:08:40 +0000 (11:08 -0700)]
Add items.itemnotes to the Notes/Comments search in Marc21

This uncomments the 952$z and assigns it to the Notes index in
marc21

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2776 : emailPurchaseSuggestions syspref deprecated
Ryan Higgins [Wed, 12 Nov 2008 03:31:34 +0000 (22:31 -0500)]
Bug 2776 : emailPurchaseSuggestions syspref deprecated

This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG-3160: fixes 'itemlost' check on item return.
Mason James [Sat, 25 Apr 2009 01:18:58 +0000 (13:18 +1200)]
BUG-3160: fixes 'itemlost' check on item return.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix XHTML error - duplicate tabindex
Galen Charlton [Sat, 25 Apr 2009 01:35:52 +0000 (20:35 -0500)]
fix XHTML error - duplicate tabindex

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNew developer for history.txt
Chris Cormack [Fri, 24 Apr 2009 20:11:02 +0000 (08:11 +1200)]
New developer for history.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3159: allow editing child patron that has no valid guarantor
Galen Charlton [Sat, 25 Apr 2009 00:46:36 +0000 (19:46 -0500)]
bug 3159: allow editing child patron that has no valid guarantor

If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record.  When attempt, no changes were saved
and the following error is recorded in the Apache error log:

memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...

This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMake js prompts translatable using _("...") and comment out unused vars.
Joe Atzberger [Fri, 24 Apr 2009 17:30:19 +0000 (12:30 -0500)]
Make js prompts translatable using _("...") and comment out unused vars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRevisions to auto-generated authorities patch
Brian Harrington [Fri, 24 Apr 2009 18:39:54 +0000 (14:39 -0400)]
Revisions to auto-generated authorities patch

It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup and tighten Letters module.
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.

Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2505 followup: restored correct item type image display
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2505: adding warnings to opac-detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl

Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModify GoogleJacket display
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display

On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agorefactor: removing a few unnecessary loops and moving HTML out of script into template
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3152 OPAC reading history column headers don't line up with text
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text

Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3128 - followup and correction
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3128: IE7 tweak
Joe Atzberger [Wed, 22 Apr 2009 21:16:56 +0000 (16:16 -0500)]
Bug 3128: IE7 tweak

Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNew Developer
Chris Cormack [Thu, 23 Apr 2009 21:59:17 +0000 (09:59 +1200)]
New Developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>