]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 7936: Patron Help Files
Nicole C. Engard [Thu, 12 Apr 2012 08:15:54 +0000 (04:15 -0400)]
Bug 7936: Patron Help Files

12 years agoBug 7936: Catalogue Help Files
Nicole C. Engard [Wed, 11 Apr 2012 06:59:48 +0000 (02:59 -0400)]
Bug 7936: Catalogue Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Patron Card Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:24:16 +0000 (00:24 -0400)]
Bug 7936: Patron Card Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Label Help Files
Nicole C. Engard [Wed, 11 Apr 2012 04:20:55 +0000 (00:20 -0400)]
Bug 7936: Label Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Circ Help Files
Nicole C. Engard [Wed, 11 Apr 2012 03:56:15 +0000 (23:56 -0400)]
Bug 7936: Circ Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Holds Help File for 3.8
Nicole C. Engard [Wed, 11 Apr 2012 02:59:35 +0000 (22:59 -0400)]
Bug 7936: Holds Help File for 3.8

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Comments Moderation Help File
Nicole C. Engard [Tue, 10 Apr 2012 19:46:07 +0000 (15:46 -0400)]
Bug 7936: Comments Moderation Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Suggestion help file
Nicole C. Engard [Tue, 10 Apr 2012 19:13:02 +0000 (15:13 -0400)]
Bug 7936: Suggestion help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Authorities Help Files
Nicole C. Engard [Tue, 10 Apr 2012 19:01:10 +0000 (15:01 -0400)]
Bug 7936: Authorities Help Files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Marc Export Help File
Nicole C. Engard [Tue, 10 Apr 2012 18:57:36 +0000 (14:57 -0400)]
Bug 7936: Marc Export Help File

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Tags help file
Nicole C. Engard [Tue, 10 Apr 2012 18:55:30 +0000 (14:55 -0400)]
Bug 7936: Tags help file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Tools Help for 3.8
Nicole C. Engard [Tue, 10 Apr 2012 16:00:12 +0000 (12:00 -0400)]
Bug 7936: Tools Help for 3.8

This updates the tools help files and adds a new
help file for the new upload cover images tool.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Cataloging Help Files
Nicole C. Engard [Mon, 9 Apr 2012 20:12:25 +0000 (16:12 -0400)]
Bug 7936: Cataloging Help Files

These are the updated help files for cataloging

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: Help file for Lists
Nicole C. Engard [Mon, 9 Apr 2012 20:06:36 +0000 (16:06 -0400)]
Bug 7936: Help file for Lists

This is the 3.8 help file for lists.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7936: 3.8 Help Files
Nicole C. Engard [Mon, 9 Apr 2012 19:57:41 +0000 (15:57 -0400)]
Bug 7936: 3.8 Help Files

These are the three help files that do not belong in any
specific directory. Links updated to the 3.8 manual.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5345 [FOLLOW-UP] DataTables in Koha
Owen Leonard [Tue, 6 Mar 2012 17:43:55 +0000 (12:43 -0500)]
Bug 5345 [FOLLOW-UP] DataTables in Koha

Adding missing images: The "disabled" version of the next,
previous, first, and last buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5668'
Paul Poulain [Fri, 13 Apr 2012 13:32:25 +0000 (15:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_5668'

12 years agoBug 5668 Error during during insall with web installer, Step 3
mveron [Thu, 12 Apr 2012 20:17:02 +0000 (22:17 +0200)]
Bug 5668 Error during during insall with web installer, Step 3

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Before patch web installer dies with error message on creating
database tables:
ERROR 1064 (42000) at line 2821: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '- biblionumber int(11)
NOT NULL, - rating_value tinyint(1) NOT NULL, - ' at line 2

After patch installation completes normally. I also checked
that tables ratings and pending_offline_operations were
created correctly.

Note: This is Marc Veron's first patch for Koha - congratulations!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7831 : Sort budgets for selection in new order
Colin Campbell [Tue, 27 Mar 2012 15:04:12 +0000 (16:04 +0100)]
Bug 7831 : Sort budgets for selection in new order

The select budget dropdown list should be presented in
an ordered fashion. To achieve this sort the budget array
by the visible text.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7876'
Paul Poulain [Thu, 12 Apr 2012 16:11:05 +0000 (18:11 +0200)]
Merge remote-tracking branch 'origin/new/bug_7876'

12 years agoBug 7876 - Followup - Fix span tag position, add fine amount spans.
Kyle M Hall [Tue, 10 Apr 2012 16:51:23 +0000 (12:51 -0400)]
Bug 7876 - Followup - Fix span tag position, add fine amount spans.

Span was outside, the if statement, could possible cause problems
with jQuery customizations, moved span to inside the conditional.

Also added span for the fine amount itself, so that it may be
re-used for jQuery customizations.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passed tests, spans appear to be correct.

12 years agoBug 2034: Removing unused scripts billig.pl/billing.tt
Katrin Fischer [Sun, 8 Apr 2012 09:26:24 +0000 (11:26 +0200)]
Bug 2034: Removing unused scripts billig.pl/billing.tt

- Scripts are currently not linked from anywhere in the templates
- Functionality can also be achieved with a custom report
- There are unresolved problems with the sql in the existig scripts

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7940 - Placing a hold on a single item from the staff cart causes errors
Kyle M Hall [Tue, 10 Apr 2012 15:36:36 +0000 (11:36 -0400)]
Bug 7940 - Placing a hold on a single item from the staff cart causes errors

This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7838 - Add sort-string-utf.chr for Ukrainian and Russian
Serhij Dubyk {Сергій Дубик} [Tue, 27 Mar 2012 23:46:09 +0000 (02:46 +0300)]
Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7834: order search at the top of acq does nothing
Katrin Fischer [Mon, 9 Apr 2012 07:48:46 +0000 (09:48 +0200)]
Bug 7834: order search at the top of acq does nothing

Entering a search term for 'title' or 'vendor' at the top search
form in acq (tab 'Orders search') did redirect to the advanced
search form, but didn't start the search.

After applying the patch the search will bring back results immediately
or redirect to the form, when there are no results.

To test:
- Check all searches still work as expected by searching for title,
vendor, order name and invoice number
- Check advanced search still has the search terms prepopulated
- Check searches with and without results are ok

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7756: FIX send email for late orders
Jonathan Druart [Tue, 10 Apr 2012 08:06:59 +0000 (10:06 +0200)]
Bug 7756: FIX send email for late orders

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- sending claim mails works now
- claim counter is not increased when vendor has no email address

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agomissing \n in updatedatabase that causes some ugly display
Paul Poulain [Wed, 11 Apr 2012 13:18:40 +0000 (15:18 +0200)]
missing \n in updatedatabase that causes some ugly display

12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Wed, 11 Apr 2012 07:34:48 +0000 (09:34 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 [FOLLOW-UP] Capitalize strings consistently
Owen Leonard [Tue, 10 Apr 2012 19:43:48 +0000 (15:43 -0400)]
Bug 2780 [FOLLOW-UP] Capitalize strings consistently

Changes to the case of some hidden input values prevented
the user from being able to save a new SQL report.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, can now save sql reports.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agomembers now passes perlcritic, but not misc. removing testing of misc
Paul Poulain [Tue, 10 Apr 2012 16:03:55 +0000 (18:03 +0200)]
members now passes perlcritic, but not misc. removing testing of misc

12 years agoUpdating euskara and french translation teams
Paul Poulain [Tue, 10 Apr 2012 14:13:37 +0000 (16:13 +0200)]
Updating euskara and french translation teams

12 years agoBug 7935 follow-up: DBRev number
Paul Poulain [Tue, 10 Apr 2012 13:26:55 +0000 (15:26 +0200)]
Bug 7935 follow-up: DBRev number

12 years agoBug 7935: Introduce sys pref to control 'browse results' in OPAC
Katrin Fischer [Mon, 9 Apr 2012 19:27:16 +0000 (21:27 +0200)]
Bug 7935: Introduce sys pref to control 'browse results' in OPAC

Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.

Preference is activated by default and can be deactivated using the
system preference.

To test:
 - Check database update works correctly
 - Check that browsing and paging still works with after database update
 - Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
 - Check the feature does no longer show up in OPAC
 - Check that a new installation also has the system preference with correct default

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2505 follow-up: C4::Ris not ready for use strict;use warnings;
Paul Poulain [Tue, 10 Apr 2012 13:08:47 +0000 (15:08 +0200)]
Bug 2505 follow-up: C4::Ris not ready for use strict;use warnings;

The patch pushed a few hours ago is a good 1st step in the right direction.
however, many things are still to do to have the script OK with strict/warning, so commenting them

Errors if you have them:

Global symbol "$utf" requires explicit package name at C4/Ris.pm line 111.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 350.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 353.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 363.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 389.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 431.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 438.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 439.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 440.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 441.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 442.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 443.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 464.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 465.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 466.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 479.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 480.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 483.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 484.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 485.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 501.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 505.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 527.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 530.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 539.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 540.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 556.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 557.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 561.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 562.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 578.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 579.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 583.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 584.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 613.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 614.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 629.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 630.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 645.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 646.
Global symbol "$intype" requires explicit package name at C4/Ris.pm line 674.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 706.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 707.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 710.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 715.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 721.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 725.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 729.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 730.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 731.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 734.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 735.
Global symbol "$protoyear" requires explicit package name at C4/Ris.pm line 738.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 772.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 776.
Global symbol "@kwsubfields" requires explicit package name at C4/Ris.pm line 779.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 789.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 892.
Global symbol "@notesubfields" requires explicit package name at C4/Ris.pm line 895.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 901.
Global symbol "$marcprint" requires explicit package name at C4/Ris.pm line 935.
Global symbol "$utf" requires explicit package name at C4/Ris.pm line 962.
Global symbol "$uniout" requires explicit package name at C4/Ris.pm line 966.
C4/Ris.pm had compilation errors.

12 years agoBug 5668 follow-up: removing empty lines in opac.pref
Paul Poulain [Tue, 10 Apr 2012 12:58:32 +0000 (14:58 +0200)]
Bug 5668 follow-up: removing empty lines in opac.pref

Those lines where introduced by this patch

12 years agoBug 5668 follow-up: DBRev number
Paul Poulain [Tue, 10 Apr 2012 12:57:55 +0000 (14:57 +0200)]
Bug 5668 follow-up: DBRev number

12 years agoBug 5668 - Star ratings in the opac
Mason James [Fri, 30 Mar 2012 03:35:29 +0000 (16:35 +1300)]
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7743 follow up fixing syntax to so templates pass test
Chris Cormack [Mon, 9 Apr 2012 08:04:20 +0000 (20:04 +1200)]
Bug 7743 follow up fixing syntax to so templates pass test

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Failing test was: xt/author/valid-templates.t

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac
Chris Cormack [Thu, 5 Apr 2012 03:40:46 +0000 (15:40 +1200)]
Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

12 years agoBug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
Chris Cormack [Thu, 5 Apr 2012 02:43:20 +0000 (14:43 +1200)]
Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests

signed-off-by Jonathan Druart <jonathan.druart@biblibre.com>

12 years agoBug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such
Colin Campbell [Fri, 23 Mar 2012 12:17:58 +0000 (12:17 +0000)]
Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such

Intention of code is that data is output in utf-8 requires an
encoding layer to ensure that. ':utf-8' flags the stream as utf-8
but does not ensure output characters are correctly encoded

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7871: prevents crash when suggestion linked to erased budget
Adrien Saurat [Tue, 3 Apr 2012 07:56:46 +0000 (09:56 +0200)]
Bug 7871: prevents crash when suggestion linked to erased budget

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber
Julian Maurice [Thu, 22 Mar 2012 16:20:01 +0000 (17:20 +0100)]
Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber

This sub only takes one parameter

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7886 follow-up DBRev number
Paul Poulain [Tue, 10 Apr 2012 09:53:15 +0000 (11:53 +0200)]
Bug 7886 follow-up DBRev number

12 years agoBug 7886 - C4/ShelfBrowser slow SQL performance
Dobrica Pavlinusic [Wed, 4 Apr 2012 23:03:30 +0000 (01:03 +0200)]
Bug 7886 - C4/ShelfBrowser slow SQL performance

ShelfBrowser uses two SQL queries with syntax

WHERE ((cn_sort = ? AND itemnumber < ?) OR cn_sort < ?)
AND homebranch = ? AND location = ? AND ccode = ?

homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
index_merge intersect(items_ccode,homebranch,items_location)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7900: Link to vendor from subscription detail is broken
Katrin Fischer [Fri, 6 Apr 2012 15:09:30 +0000 (17:09 +0200)]
Bug 7900: Link to vendor from subscription detail is broken

To test:
- Add a serial subscription with a link to a vendor
- Check the subscription detail page for the name and link to the vendor
- Check that the link works correctly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2505 : Switch on warnings in circ/returns.pl
Colin Campbell [Wed, 15 Jun 2011 11:15:14 +0000 (12:15 +0100)]
Bug 2505 : Switch on warnings in circ/returns.pl

Removed a compile time warning caused by a void context
in a bit of too clever obscure code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2505 : use warnings in smart_rules.pl
Colin Campbell [Tue, 7 Jun 2011 13:34:18 +0000 (14:34 +0100)]
Bug 2505 : use warnings in smart_rules.pl

Fix some careless code redeclaring a variable
declaring a variable in a condition
so that these don't generate errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2505 - enable Perl warnings in all modules and scripts
Mason James [Thu, 15 Mar 2012 08:06:22 +0000 (21:06 +1300)]
Bug 2505 - enable Perl warnings in all modules and scripts

enable warnings, and correct perlcritic's 'Loop iterator is not lexical' errors in C4/Ris.pm

modified:   C4/Ris.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7893 - add package dependencies
Robin Sheat [Wed, 4 Apr 2012 11:10:59 +0000 (23:10 +1200)]
Bug 7893 - add package dependencies

This adds some dependencies to the control file that are required.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2780 - Capitalize strings consistently (home, about, login)
Katrin Fischer [Sun, 8 Apr 2012 21:42:36 +0000 (23:42 +0200)]
Bug 2780 - Capitalize strings consistently (home, about, login)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:32:48 +0000 (10:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)
Katrin Fischer [Sun, 8 Apr 2012 21:31:33 +0000 (23:31 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some strings:
* itemcallnumber => item call number
* Profile marcfields=> Profile MARC fields

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)
Katrin Fischer [Sun, 8 Apr 2012 20:50:10 +0000 (22:50 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some vocabulary replacing "shelf" by "list"

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)
Katrin Fischer [Sun, 8 Apr 2012 19:29:39 +0000 (21:29 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Sun, 8 Apr 2012 17:39:00 +0000 (19:39 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Fixes some more strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Fri, 6 Apr 2012 22:26:23 +0000 (00:26 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Some missing strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:04:51 +0000 (10:04 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 - Capitalize strings consistently - various
Katrin Fischer [Sun, 8 Apr 2012 20:35:26 +0000 (22:35 +0200)]
Bug 2780 - Capitalize strings consistently - various

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (serials)
Katrin Fischer [Sun, 8 Apr 2012 20:17:24 +0000 (22:17 +0200)]
Bug 2780 - Capitalize strings consistently (serials)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Katrin Fischer [Sun, 8 Apr 2012 19:44:56 +0000 (21:44 +0200)]
Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (patron cards)
Katrin Fischer [Sun, 8 Apr 2012 18:44:38 +0000 (20:44 +0200)]
Bug 2780 - Capitalize strings consistently (patron cards)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (offline circulation)
Katrin Fischer [Sun, 8 Apr 2012 18:22:41 +0000 (20:22 +0200)]
Bug 2780 - Capitalize strings consistently (offline circulation)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (members)
Katrin Fischer [Sun, 8 Apr 2012 17:49:57 +0000 (19:49 +0200)]
Bug 2780 - Capitalize strings consistently (members)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Katrin Fischer [Fri, 6 Apr 2012 17:52:41 +0000 (19:52 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Katrin Fischer [Fri, 6 Apr 2012 17:43:29 +0000 (19:43 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)

Fixes some missed strings.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (Labels templates)
Owen Leonard [Fri, 6 Apr 2012 19:50:10 +0000 (15:50 -0400)]
Bug 2780 - Capitalize strings consistently (Labels templates)

Correcting capitalization in Labels templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Labels help)
Owen Leonard [Fri, 6 Apr 2012 19:11:44 +0000 (15:11 -0400)]
Bug 2780 - Capitalize strings consistently (Labels help)

Correcting capitalization in Labels help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Misc. help pages)
Owen Leonard [Fri, 6 Apr 2012 18:06:37 +0000 (14:06 -0400)]
Bug 2780 - Capitalize strings consistently (Misc. help pages)

Correcting capitalization in various help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Circulation help)
Owen Leonard [Fri, 6 Apr 2012 13:35:18 +0000 (09:35 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation help)

Correcting capitalization in Circulation help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Authorities and Cataloging help)
Owen Leonard [Fri, 6 Apr 2012 13:20:42 +0000 (09:20 -0400)]
Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help)

Correcting capitalization in Authorities and Cataloging help pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Admin help)
Owen Leonard [Thu, 5 Apr 2012 16:33:37 +0000 (12:33 -0400)]
Bug 2780 - Capitalize strings consistently (Admin help)

Correcting capitalization in Administration help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Acqui help)
Owen Leonard [Thu, 5 Apr 2012 15:46:12 +0000 (11:46 -0400)]
Bug 2780 - Capitalize strings consistently (Acqui help)

Correcting capitalization in Acquisitions help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Installer)
Owen Leonard [Fri, 6 Apr 2012 19:42:02 +0000 (15:42 -0400)]
Bug 2780 - Capitalize strings consistently (Installer)

Correcting capitalization in Installer templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Error pages)
Owen Leonard [Thu, 5 Apr 2012 15:14:11 +0000 (11:14 -0400)]
Bug 2780 - Capitalize strings consistently (Error pages)

Correcting capitalization in staff client error pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (OPAC includes)
Owen Leonard [Wed, 4 Apr 2012 19:18:39 +0000 (15:18 -0400)]
Bug 2780 - Capitalize strings consistently (OPAC includes)

Correcting capitalization in OPAC includes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Circulation)
Owen Leonard [Wed, 4 Apr 2012 18:38:11 +0000 (14:38 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation)

Correcting capitalization in Circulation templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging pages)
Owen Leonard [Wed, 4 Apr 2012 16:56:17 +0000 (12:56 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging pages)

Correcting capitalization in Cataloging templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging plugins)
Owen Leonard [Wed, 4 Apr 2012 16:36:12 +0000 (12:36 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging plugins)

Correcting capitalization in Cataloging plugins. Also
correcting some instances of invalid HTML.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Catalog pages)
Owen Leonard [Wed, 4 Apr 2012 14:59:43 +0000 (10:59 -0400)]
Bug 2780 - Capitalize strings consistently (Catalog pages)

Correcting capitalization in the staff client catalog pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Staff client cart)
Owen Leonard [Wed, 4 Apr 2012 14:22:29 +0000 (10:22 -0400)]
Bug 2780 - Capitalize strings consistently (Staff client cart)

Correcting capitalization in the staff client's cart templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Authorities pages)
Owen Leonard [Wed, 4 Apr 2012 13:47:15 +0000 (09:47 -0400)]
Bug 2780 - Capitalize strings consistently (Authorities pages)

Correcting capitalization in Authorities templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Admin pages)
Owen Leonard [Tue, 3 Apr 2012 19:28:23 +0000 (15:28 -0400)]
Bug 2780 - Capitalize strings consistently (Admin pages)

Correcting capitalization in Administration templates.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2733 - Can't print patron account
Owen Leonard [Tue, 3 Apr 2012 13:03:25 +0000 (09:03 -0400)]
Bug 2733 - Can't print patron account

Changing "print page" link to "print summary." I hope this will
alleviate the suggstion that the option prints the current page.

- Changed "Quick slip" to "Print quick slip" to make it consistent
  with the other options in the menu

- Corrected the case of other text strings as required by
  Bug 2780.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Fri, 6 Apr 2012 16:28:07 +0000 (18:28 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 - Capitalize strings consistently (OPAC pages)
Owen Leonard [Wed, 4 Apr 2012 19:31:11 +0000 (15:31 -0400)]
Bug 2780 - Capitalize strings consistently (OPAC pages)

Correcting capitalization in OPAC templates

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passes tests, changes look consistent by reading through the patch.

What a doozy!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6701 - login timeout is in seconds
Dobrica Pavlinusic [Tue, 27 Mar 2012 13:14:22 +0000 (15:14 +0200)]
Bug 6701 - login timeout is in seconds

I checked in C4/Auth and we are using perl time() for comparison with this value.

I also added description of specifying timeout in days which is available in code.

Robin Sheat suggested to document just lowercase d for days option, to reduce
confusion although uppercase D works as days specifier as well.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7781'
Paul Poulain [Fri, 6 Apr 2012 16:22:19 +0000 (18:22 +0200)]
Merge remote-tracking branch 'origin/new/bug_7781'

12 years agoBug 7847 - OPAC search dies with plack
Dobrica Pavlinusic [Sat, 31 Mar 2012 01:28:47 +0000 (03:28 +0200)]
Bug 7847 - OPAC search dies with plack

This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation there.

Following chang removes circural dependecy introduced by commit
b65efdaacaf77fb53fee479da7f2e990ba0adeed which is part of Bug 6027

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7894 [SIGNED-OFF]: crude fix: convert results array into an arrayref
MJ Ray [Wed, 4 Apr 2012 09:23:06 +0000 (10:23 +0100)]
bug 7894 [SIGNED-OFF]: crude fix: convert results array into an arrayref

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
This patch fixes the problem with the first record on the second
page, but there is still a problem with the next/previous links,
as described in comments 3 and 4 in the bug report. I'm signing
off since it's unclear wether that problem is directly linked to
the "first record on the second page" problem, and a partial fix
seems better than no fix at all.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7758 - Koha allowing LOST items to check out without alert
Kyle M Hall [Thu, 5 Apr 2012 15:16:47 +0000 (11:16 -0400)]
Bug 7758 - Koha allowing LOST items to check out without alert

Adds a confirmation alert when issuing an item that has
been marked as lost.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertiesd

Tested:
- checking out an item that is marked lost performs all usual lost operations
- checking out an item that is marked lost prompts for confirmation

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5549 follow-up DBRev number
Paul Poulain [Fri, 6 Apr 2012 15:59:47 +0000 (17:59 +0200)]
Bug 5549 follow-up DBRev number

for lengthunit follow-up (that was missing in kohastructure, see comments 86 - 95

12 years agobug 5549: change to kohastructure.sql missing from commit 8cea8e5cc05075dc391194248d3...
MJ Ray [Thu, 5 Apr 2012 17:56:39 +0000 (18:56 +0100)]
bug 5549: change to kohastructure.sql missing from commit 8cea8e5cc05075dc391194248d31a54586389601

Also deletes earlier updatedatabase addition of lengthunit to avoid errors for people upgrading from stable (thanks Katrin for the idea)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked creating a database from scratch and updating a database
with missing lengthunit column. Both worked without any problem.
If you update and have the column updatedatabase will report an error,
but the database will be ok.

12 years agoBug 7897: Move the SocialNetworks syspref to the Opac tab
Jonathan Druart [Thu, 5 Apr 2012 11:50:48 +0000 (13:50 +0200)]
Bug 7897: Move the SocialNetworks syspref to the Opac tab

Original bug is Bug 7470

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7445 - Clicking on a tag gives "Language ... does not exist"
Magnus Enger [Mon, 2 Apr 2012 13:27:49 +0000 (15:27 +0200)]
Bug 7445 - Clicking on a tag gives "Language ... does not exist"

To test:
- Syspref QueryStemming = Try
- Install Norwegian bokmål:
  cd misc/translator/
  perl translate install nb-NO
- Go to Home › Administration › System Preferences > I18N/L10N
  and enable "Norsk bokmål(nb-NO)" for opaclanguages as well as
  setting opaclanguagesdisplay = Allow
- Make sure you have selected "Norsk bokmål" as the active language
  in the OPAC
- Find a record that has a tag (which does not contain any digits)
- Click on the tag and see that you get the error in the title of
  this bug
- Apply the patch
- Click on the tag again and the error should be gone

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test with a great test plan. Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7613 follow-up DBRev number
Paul Poulain [Fri, 6 Apr 2012 15:37:26 +0000 (17:37 +0200)]
Bug 7613 follow-up DBRev number

12 years agoBug 7613 follow up to fix perlcritic errors
Chris Cormack [Thu, 5 Apr 2012 02:28:06 +0000 (14:28 +1200)]
Bug 7613 follow up to fix perlcritic errors

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug_7613: OCLC Connexion gateway
Srdjan [Thu, 29 Mar 2012 03:04:50 +0000 (16:04 +1300)]
bug_7613: OCLC Connexion gateway

svc/import_bib:
* takes POST request with parameters in url and MARC XML as DATA
* pushes MARC XML to an impoort bach queue of type 'webservice'
* returns status and imported record XML
* is a drop-in replacement for svc/new_bib

misc/cronjobs/import_webservice_batch.pl:
* a cron job for processing impoort bach queues of type 'webservice'
* batches can also be processed through the UI

misc/bin/connexion_import_daemon.pl:
* a daemon that listens for OCLC Connexion requests and is compliant
  with OCLC Gateway spec
* takes request with MARC XML
* takes import batch params from a config file and forwards the lot to
  svc/import_bib
* returns status

ImportBatches:
* Added new import batch type of 'webservice'
* Changed interface to AddImportBatch() - now it takes a hashref
* Replaced batch_type = 'batch' with
  batch_type IN ( 'batch', 'webservice' ) in some SELECTs

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
12 years agoBug 7641 - Add ability to suspend reserves - Followup
Kyle M Hall [Thu, 29 Mar 2012 15:50:43 +0000 (11:50 -0400)]
Bug 7641 - Add ability to suspend reserves - Followup

  * Switch from C4::Dates to $KohaDates
  * Fix 'Resume All Suspended All Requests'
  * Change button text to follow capitalization rules
  * Change 'requests' to 'holds'

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7781 : enhancements on main page
Adrien Saurat [Thu, 22 Mar 2012 11:07:16 +0000 (12:07 +0100)]
Bug 7781 : enhancements on main page

- moves the different search boxes on top of page
- displays the Koha logo
- displays the breadcrumb bar
- displays a general title "Welcome to Koha"
- reorganises the links to modules
- centers the main menu even if no news are displayed
- fixes the Submit button when CircAutocompl is on

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>