]> git.koha-community.org Git - koha.git/log
koha.git
15 years agobug 2505: enable warnings in C4::Breeding
Galen Charlton [Sun, 7 Jun 2009 22:02:51 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::Breeding

* also start to standardize ISBN normalization

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings in C4::Log
Galen Charlton [Sun, 7 Jun 2009 22:02:50 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::Log

Also corrected several links to viewlog.pl that
didn't take into account the recent renaming
of one of its parameters from 'module' to 'modules'

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings in call number normalization modules
Galen Charlton [Sun, 7 Jun 2009 22:02:49 +0000 (10:02 +1200)]
bug 2505: enable warnings in call number normalization modules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremoved incorrect module import
Galen Charlton [Sun, 7 Jun 2009 22:02:48 +0000 (10:02 +1200)]
removed incorrect module import

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings in C4/Input.pm
Galen Charlton [Sun, 7 Jun 2009 22:02:47 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4/Input.pm

Also removed POD containing disused function
checkvalidisbn.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings in C4::ImportBatch and C4::Matcher
Galen Charlton [Sun, 7 Jun 2009 22:02:46 +0000 (10:02 +1200)]
bug 2505: enable warnings in C4::ImportBatch and C4::Matcher

Also fix issues with normalizing ISBNs and the default
normalizer in C4::Matcher.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3303: removed references to news_channels*
Galen Charlton [Sun, 7 Jun 2009 22:02:45 +0000 (10:02 +1200)]
bug 3303: removed references to news_channels*

Removed routines in C4/NewsChannels.pm that refered
to missing database tables news_channels and news_channel_categories.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3302: removed disused references to opac_electronic
Galen Charlton [Sun, 7 Jun 2009 22:02:44 +0000 (10:02 +1200)]
bug 3302: removed disused references to opac_electronic

Removed routines in C4/NewsChannels.pm that refer to
a missing opac_electronic table.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enabled warnings in C4::NewsChannels
Galen Charlton [Sun, 7 Jun 2009 22:02:43 +0000 (10:02 +1200)]
bug 2505: enabled warnings in C4::NewsChannels

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: turn on warnings in seven modules
Galen Charlton [Sun, 7 Jun 2009 22:02:42 +0000 (10:02 +1200)]
bug 2505: turn on warnings in seven modules

C4::XSLT
C4::VirtualShelves
C4::Review
C4::Output
C4::Boolean
C4::Charset
C4::Stats

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadditional cleanup in GetItemsInfo()
Galen Charlton [Sun, 7 Jun 2009 19:31:43 +0000 (14:31 -0500)]
additional cleanup in GetItemsInfo()

* remove unused variable
* moved declaration of $count_reseves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoved a buggy conditional if that resulted in an incorrect item status
David Birmingham [Fri, 5 Jun 2009 20:40:55 +0000 (16:40 -0400)]
Removed a buggy conditional if that resulted in an incorrect item status

Previous conditional check with if ($restype) is not needed because a true
result for one item will result in subsqeuent items defaulting to this true
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3299: fix setting renewal due date explicitly
Galen Charlton [Sat, 6 Jun 2009 19:26:18 +0000 (14:26 -0500)]
bug 3299: fix setting renewal due date explicitly

When renewing a loan from the patron details page, setting
the renewal due date now works again.  Broken by patch
for bug 2770.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2926: fix staging import hang
Galen Charlton [Sat, 6 Jun 2009 21:45:54 +0000 (16:45 -0500)]
bug 2926: fix staging import hang

Fixes a hang of the staging import tool when it
attempts to process a MARC21 record that claims
that it's UTF-8 when it is not.  The staging import
will now attempt to fix the character encoding of such
records.

Also added a FIXME to bulkmarcimport.pl, which because
of its use of MARC::Batch will skip over such records -
better than the original hang of the staging import, but
worse than the staging import's new ability to fix such
records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3278: move three sysprefs to Staff client tab
Galen Charlton [Sat, 6 Jun 2009 21:54:48 +0000 (16:54 -0500)]
bug 3278: move three sysprefs to Staff client tab

* viewMARC
* viewISBN
* viewLabeledMARC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3201: missing090field.pl - skip bad bibs
Galen Charlton [Sat, 6 Jun 2009 23:13:22 +0000 (18:13 -0500)]
bug 3201: missing090field.pl - skip bad bibs

Patch courtesy of G. Henry <henry@cmi.univ-mrs.fr>

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2737: fixed typo in MARC21 008 plugin
Galen Charlton [Sat, 6 Jun 2009 23:25:21 +0000 (18:25 -0500)]
bug 2737: fixed typo in MARC21 008 plugin

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3081: Add description for category code.
Garry Collum [Thu, 7 May 2009 23:40:16 +0000 (19:40 -0400)]
Bug 3081: Add description for category code.

Adds the category code to the description in "my personal details" in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3097: statistics on itemcount not working
Henri-Damien LAURENT [Wed, 8 Apr 2009 10:18:39 +0000 (12:18 +0200)]
bug 3097: statistics on itemcount not working

replacing issues.itemnumber by statistics.itemnumber
since issues was not included in the query.
All statistics on circulation for item count were zeroed.

[RM note: specifically, this patch fixes the results
 when you set the 'cell value' to 'count unique items']

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup branches.pl and .tmpl
Joe Atzberger [Sat, 6 Jun 2009 00:02:56 +0000 (19:02 -0500)]
Cleanup branches.pl and .tmpl

Remove entire subs that were unused.  Remove "toggle" code.
Comment out unconditional warn.
Remove inaccurate comments regarding long-fixed bugs and obsolete processes.
Remove unused variables.
Added "dialog message" div around MESSAGE8.

NOTE: all printer functions currently useless, unfixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3197) Fix errors in markup causing validation errors
Colin Campbell [Sat, 6 Jun 2009 12:57:37 +0000 (13:57 +0100)]
(bug #3197) Fix errors in markup causing validation errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding 3.0.2 release to history
Chris Cormack [Sat, 6 Jun 2009 07:08:36 +0000 (19:08 +1200)]
Adding 3.0.2 release to history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3300: Fixes XHTML errors in viewlog.tmpl
Garry Collum [Sat, 6 Jun 2009 14:06:24 +0000 (10:06 -0400)]
Bug 3300: Fixes XHTML errors in viewlog.tmpl

Corrects a couple of missing ids associated with labels, and removes an extra </div> that appears because or the inclusion of intranet-bottom.inc

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoretweak font-size of OPAC search box
Galen Charlton [Fri, 5 Jun 2009 23:25:28 +0000 (18:25 -0500)]
retweak font-size of OPAC search box

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUse Google Indic Transliteration API to allow users to transliterate english typed...
savitra.sirohi [Thu, 4 Jun 2009 10:37:14 +0000 (16:07 +0530)]
Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages.

This is available only on the masthead search box in the OPAC.

User has to enter a word in english and press space or return to transliterate the word. The destination language can be selected from a drop down list. User can temporarily turn on/off the feature by using "ctrl +g".

A system preference - GoogleIndicTransliteration can be used to turn on this feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'
Galen Charlton [Fri, 5 Jun 2009 22:47:00 +0000 (17:47 -0500)]
bug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix Bug 3259 part 2 - fixed terminology on circulation.tmpl
Nicole Engard [Thu, 4 Jun 2009 15:48:32 +0000 (10:48 -0500)]
Fix Bug 3259 part 2 - fixed terminology on circulation.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix Bug 3259 - change 'too many renewals' to 'not renewable'
Nicole Engard [Thu, 4 Jun 2009 15:44:20 +0000 (10:44 -0500)]
Fix Bug 3259 - change 'too many renewals' to 'not renewable'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup: remove unconditional warn
Galen Charlton [Fri, 5 Jun 2009 22:38:32 +0000 (17:38 -0500)]
followup: remove unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoStandalone branch selection
Joe Atzberger [Thu, 4 Jun 2009 17:43:53 +0000 (12:43 -0500)]
Standalone branch selection

selectbranchprinter now posts to itself to set the branch.  That also means that
other pages can set the branch by linking to selectbranchprinter like:
    /cgi-bin/koha/circ/selectbranchprinter.pl?branch=MAIN

We use HTTP_REFERER to allow the user to continue back to wherever they linked from,
defaulting to circulation.pl (the former POST target).

Note that all "branchprinter" functions are basically useless as the data is not
properly handled in the session storage.  Chris C. expects this to be addressed
with later patches for HLT.  There appear to be no 3.0 users of this intended
functionality yet.

Includes squashed patch to fix tmpl and to automatically redirect if there are no
POST params to be recycled.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup selectbranchprinter.pl and .tmpl
Joe Atzberger [Fri, 29 May 2009 21:09:34 +0000 (16:09 -0500)]
Cleanup selectbranchprinter.pl and .tmpl

Use GetBranchesLoop and warnings.  Remove unused code.  Moved the Get's to after auth.
I begin to show how this script will use referer to redirect back to the sending
page upon successful change of branch or printer (see hidden div and recycle_loop).

Indicator for singleBranchMode added.
Also added another helper function for GetBranchesLoop, namely mybranch.  This
encapsulates the logic for finding an intelligent default selection, which is
almost always desirable.

This does not resolve bug 2426, but is work in that direction.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup cities.pl and .tmpl - major
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major

80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings.  Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code.  Etc.

TODO: Stop redirecting to the same page.  Instead get the correct data and show it
on THIS pass.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup previous patch - remove disused $opacstylesheet
Galen Charlton [Fri, 5 Jun 2009 22:06:16 +0000 (17:06 -0500)]
followup previous patch - remove disused $opacstylesheet

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPull the last OPAC-specific tmpl vars out of gettemplate.
Joe Atzberger [Thu, 4 Jun 2009 17:43:52 +0000 (12:43 -0500)]
Pull the last OPAC-specific tmpl vars out of gettemplate.

These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3289 - Fixed bad conditional check that made news items not show up until the...
Liz Rea [Thu, 4 Jun 2009 16:22:00 +0000 (11:22 -0500)]
Bug 3289 - Fixed bad conditional check that made news items not show up until the day after pubdate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding another developer to the history
Chris Cormack [Wed, 3 Jun 2009 22:18:26 +0000 (10:18 +1200)]
Adding another developer to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2624: Fix for non-persistent check boxes in check-in screen.
Garry Collum [Wed, 3 Jun 2009 21:37:01 +0000 (17:37 -0400)]
Bug 2624: Fix for non-persistent check boxes in check-in screen.

Found this bug when playing with AutomaticItemReturn. The "Forgive overdue charges" and "Dropbox mode" would lose their value the item was transfered (if automatic transfer was off), caught a hold, or caught a hold at another location.
This patch does not completely do away with the problem.  If an item is checked-in in simple mode, then one of the forms mentioned above opens, then the user checks one of the selection boxes, the value is not retained.  Javasript would have to be added to transfer the value to the confirmation form when the checkbox is clicked.

This patch also cleans up a few minor XHTML errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3291) fix blue.css to bold fields and tags in marc view
Nahuel ANGELINETTI [Thu, 4 Jun 2009 10:26:10 +0000 (12:26 +0200)]
(bug #3291) fix blue.css to bold fields and tags in marc view

Add a css property, and fix a class, to show fields and subfields as bold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor POD update - copied section doesn't apply to other function
Joe Atzberger [Wed, 3 Jun 2009 16:26:26 +0000 (11:26 -0500)]
Minor POD update - copied section doesn't apply to other function

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadditional SCO template fixes
Galen Charlton [Wed, 3 Jun 2009 19:29:39 +0000 (14:29 -0500)]
additional SCO template fixes

* removed sco.js, which is no longer used
* fixed XHTML warnings in sco-main.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix minor warning issues in SCO
Galen Charlton [Wed, 3 Jun 2009 19:12:05 +0000 (14:12 -0500)]
fix minor warning issues in SCO

* test for NO_MORE_RENEWALS now does expect
  that hash key will always exist
* removed unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup SCO - OPAC self checkout
Joe Atzberger [Wed, 3 Jun 2009 14:31:46 +0000 (09:31 -0500)]
Cleanup SCO - OPAC self checkout

~ vestigial broken scripts and templates removed
~ meaningless dependencies removed
~ Focus handling issues resolved for cross-browsers
~ Timeout only invoked for non-first screen.  This keeps the refresh from
flooding the logs continuously for no purpose.
~ two halves of "validuser" conditional linked in TMPL
~ elsif's used for $op conditionals

The focus should now appear on the "Return to Account Summary" button during errors.
The user can scan anything (w/ carriage return) and get back to the first screen.
Also, special functionality is added for the magic barcode "__KOHA_NEW_CIRC__".
This effectively ends the patron session and logs them out so the next patron can begin.
The purpose is for patrons to avoid having to use a keyboard at all, if libraries
print and have this special barcode available for patrons at the SCO station.

Enhancement was requested by Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3268: Adds the ability to edit the description of a holiday.
Garry Collum [Sat, 30 May 2009 22:30:13 +0000 (18:30 -0400)]
Bug 3268: Adds the ability to edit the description of a holiday.

Adds another radio button to the edit holiday form. This is a partial fix, because you cannot make an edit to a single holiday for multiple branches.

Also fixed a small XHTML error and a wording error from my previous patch on holidays.tmpl (bug 3274).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a new developer to the history documentation
Chris Cormack [Fri, 29 May 2009 21:02:39 +0000 (09:02 +1200)]
Adding a new developer to the history documentation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3274: Patch to fix Holiday Exceptions radio button.
Garry Collum [Sat, 30 May 2009 16:29:11 +0000 (12:29 -0400)]
Bug 3274: Patch to fix Holiday Exceptions radio button.

Holiday exceptions only make since for repeatable holidays. Javascript showHoliday function was looking for a 'showTitle' id that no longer existed in the showHolidau form.  Added a hidden input field because of the possibility of re-adding the title text input field at a later time.
Added code to determine whether a holiday as an exception or not, so that the "Delete this program" radio button changes to "Delete this exception" because that is the program's true functionality if the holiday is an exception.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl
Garry Collum [Sun, 31 May 2009 02:27:33 +0000 (22:27 -0400)]
Bug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3276: Minor XHTML error in opac-passwd.tmpl
Garry Collum [Sun, 31 May 2009 11:02:29 +0000 (07:02 -0400)]
Bug 3276: Minor XHTML error in opac-passwd.tmpl

Fixes a reference to a non-existent id.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow zebra search for Lexile numbers in field 521$a
savitra.sirohi [Wed, 3 Jun 2009 03:55:41 +0000 (09:25 +0530)]
Allow zebra search for Lexile numbers in field 521$a

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl
Garry Collum [Tue, 2 Jun 2009 22:44:31 +0000 (18:44 -0400)]
Bug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3170 followup
Galen Charlton [Tue, 2 Jun 2009 20:05:05 +0000 (15:05 -0500)]
bug 3170 followup

* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
  regardless of whether a new one is created
  or an existing one modified

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3170) do not check fields < 010
Nahuel ANGELINETTI [Fri, 29 May 2009 10:32:46 +0000 (12:32 +0200)]
(bug #3170) do not check fields < 010

This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3170) check if mandatory fields are not empty
Nahuel ANGELINETTI [Thu, 30 Apr 2009 13:09:36 +0000 (15:09 +0200)]
(bug #3170) check if mandatory fields are not empty

This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3271 : Added tooltip when adding to a list with no item selected (same as for...
Matthias Meusburger [Fri, 29 May 2009 12:43:55 +0000 (14:43 +0200)]
bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3272: preserve formatting when editing help
Galen Charlton [Fri, 29 May 2009 13:37:14 +0000 (08:37 -0500)]
bug 3272: preserve formatting when editing help

Tweak the TinyMCE settings so that more of the original
whitespace and HTML is preserved when editing help, making
help patches easier to understand.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This...
Zeno Tajoli [Fri, 29 May 2009 08:28:25 +0000 (10:28 +0200)]
Fix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This second patch for the same bug is only for white spaces and newlines

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3252: Fixes XHTML on catalog statistic form page.
Garry Collum [Fri, 29 May 2009 02:30:24 +0000 (22:30 -0400)]
Bug 3252: Fixes XHTML on catalog statistic form page.

Several form input fields were within a <table> element, but not in a <td>.  This patch pulls the input fields out of the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding 2 new developers to the history
Chris Cormack [Fri, 29 May 2009 02:24:15 +0000 (14:24 +1200)]
Adding 2 new developers to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix markup error in unimarc_field_128a.tmpl
Galen Charlton [Fri, 29 May 2009 01:51:23 +0000 (20:51 -0500)]
fix markup error in unimarc_field_128a.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix markup problems in label-edit-layout.tmpl
Galen Charlton [Fri, 29 May 2009 01:44:44 +0000 (20:44 -0500)]
fix markup problems in label-edit-layout.tmpl

* couple constructs that caused translation bugs
* now valid XHTML

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix minor translation bugs in two OPAC templates
Galen Charlton [Fri, 8 May 2009 21:56:12 +0000 (16:56 -0500)]
fix minor translation bugs in two OPAC templates

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2884: followup patch
Galen Charlton [Fri, 29 May 2009 01:13:21 +0000 (20:13 -0500)]
bug 2884: followup patch

[1] Restore behavior of the input field for the library
    code; when adding a new library, it should be a
    a text box; when editing an existing library,
    should be a hidden input.
[2] When user attempts to add a new library with the same
    code as that of an existing library, populate the form
    with what the user entered for the new library, not the
    values from the existing library.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #2884: Add error management to branches
Paul Poulain [Thu, 28 May 2009 16:32:16 +0000 (18:32 +0200)]
fix for #2884: Add error management to branches

While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)
Galen Charlton [Thu, 28 May 2009 12:51:12 +0000 (07:51 -0500)]
bug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)

Also added index on authorised_values.lib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Galen Charlton [Fri, 13 Feb 2009 15:39:38 +0000 (09:39 -0600)]
bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes

Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix permissions error introduced in prior patch
Galen Charlton [Thu, 28 May 2009 23:47:01 +0000 (18:47 -0500)]
fix permissions error introduced in prior patch

15 years agoremoving comments
Paul Poulain [Thu, 28 May 2009 16:32:21 +0000 (18:32 +0200)]
removing comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing API of ModBiblioMarc
Paul Poulain [Thu, 28 May 2009 16:32:19 +0000 (18:32 +0200)]
Fixing API of ModBiblioMarc

no need to retrieve $biblionumber, as we already know it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(not new_acq related) smallfix to avoid a die in case of an invalid record
Paul Poulain [Thu, 28 May 2009 16:32:24 +0000 (18:32 +0200)]
(not new_acq related) smallfix to avoid a die in case of an invalid record

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremoving useless line (use Data::Dumper)
Paul Poulain [Thu, 28 May 2009 16:32:27 +0000 (18:32 +0200)]
removing useless line (use Data::Dumper)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for 2997 : superlibrarian's ability to edit item/patron home branch affected...
Paul Poulain [Thu, 28 May 2009 16:32:14 +0000 (18:32 +0200)]
fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected

Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc
Michael Hafen [Thu, 28 May 2009 18:36:22 +0000 (12:36 -0600)]
bugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc

There used to be two TMPL_IF's here, now there's just one.  Missed removing
the second /TMPL_IF though.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Zeno Tajoli [Thu, 28 May 2009 12:45:20 +0000 (14:45 +0200)]
Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Garry Collum [Thu, 28 May 2009 01:48:12 +0000 (21:48 -0400)]
Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.

Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow option to preserve Extended Attributes on patron import update.
Joe Atzberger [Wed, 27 May 2009 18:38:58 +0000 (13:38 -0500)]
Allow option to preserve Extended Attributes on patron import update.

Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.

Several functions added to Members::Attributes with corresponding tests.

[ LL ref. 342 ]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2641, 3263: minor fixes to labeled MARC view
Galen Charlton [Wed, 27 May 2009 18:10:47 +0000 (13:10 -0500)]
bug 2641, 3263: minor fixes to labeled MARC view

* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2642, 3263: new MARC display system preferences (DB rev 036)
Galen Charlton [Wed, 27 May 2009 18:10:46 +0000 (13:10 -0500)]
bug 2642, 3263: new MARC display system preferences (DB rev 036)

* Added definitions of the new display sysprefs:

  viewISBD - Allow display of ISBD view of bibiographic records
  viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
  viewMARC - viewMARC  Allow display of MARC view of bibiographic records

* Adjusted IntranetBiblioDefaultView
  * made type choice (fixing bug 1933)
  * added better description for English
  * added labeled_marc option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: fixed ersatz references to AmazonContent
Galen Charlton [Wed, 27 May 2009 18:10:45 +0000 (13:10 -0500)]
bug 3263: fixed ersatz references to AmazonContent

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2641, 3263: Staff Search Results Interface Changes
Rick Welykochy [Wed, 27 May 2009 18:10:44 +0000 (13:10 -0500)]
bug 2641, 3263: Staff Search Results Interface Changes

New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1933: started work fixing IntranetBiblioDefaultView syspref
Galen Charlton [Wed, 27 May 2009 18:10:43 +0000 (13:10 -0500)]
bug 1933: started work fixing IntranetBiblioDefaultView syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: Staff Search Results Interface Changes
Galen Charlton [Wed, 27 May 2009 18:10:42 +0000 (13:10 -0500)]
bug 3263: Staff Search Results Interface Changes

Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix DB rev for adding location to subscriptions: 035
Galen Charlton [Wed, 27 May 2009 14:57:23 +0000 (09:57 -0500)]
fix DB rev for adding location to subscriptions: 035

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agovarious improvements to subscription editing
Galen Charlton [Wed, 27 May 2009 14:57:24 +0000 (09:57 -0500)]
various improvements to subscription editing

* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding and managing location in subscription
Henri-Damien LAURENT [Wed, 27 May 2009 14:57:22 +0000 (09:57 -0500)]
Adding and managing location in subscription

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3244: Support for multiple PAC interfaces.
Ryan Higgins [Wed, 27 May 2009 15:31:47 +0000 (10:31 -0500)]
bug 3244: Support for multiple PAC interfaces.

Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Chris Nighswonger [Wed, 27 May 2009 15:30:14 +0000 (11:30 -0400)]
Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers

Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSmall documentation improvement for C4::Service
Jesse Weaver [Wed, 27 May 2009 14:31:29 +0000 (08:31 -0600)]
Small documentation improvement for C4::Service

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix uninitialized value warnings during COinS generation
Galen Charlton [Wed, 27 May 2009 14:01:00 +0000 (09:01 -0500)]
fix uninitialized value warnings during COinS generation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated INSTALL.opensuse file to wiki version
Ricardo Dias Marques [Tue, 26 May 2009 22:42:34 +0000 (23:42 +0100)]
Updated INSTALL.opensuse file to wiki version

Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:

Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0

This commit is supposed to be applied to the 3.0.x branch.

Changelog:

– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoQuick fix to catch some instances of XSS vulnerability, there will be more probably...
Chris Cormack [Fri, 22 May 2009 20:05:56 +0000 (08:05 +1200)]
Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circulation.pl
Joe Atzberger [Tue, 26 May 2009 21:41:01 +0000 (16:41 -0500)]
Cleanup circulation.pl

Removed many unused variables.
Switched to elsif where appropriate.
Cleaned up some whitespace.
Corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup waitingreserves.pl and .tmpl
Joe Atzberger [Tue, 26 May 2009 21:41:03 +0000 (16:41 -0500)]
Cleanup waitingreserves.pl and .tmpl

Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3169 - Google jacket display, remove preview image on result page
Frédéric Demians [Sat, 23 May 2009 06:43:01 +0000 (08:43 +0200)]
Bug 3169 - Google jacket display, remove preview image on result page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1687: Can't assign holidays to all branches at once.
Garry Collum [Sun, 24 May 2009 16:10:23 +0000 (12:10 -0400)]
Bug 1687: Can't assign holidays to all branches at once.

This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Garry Collum [Mon, 25 May 2009 00:51:18 +0000 (20:51 -0400)]
Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.

Added code to detect if the syspref for item-level_itypes is being used.  The report now correctly returns data based on the syspref.  There are some pre-existing XML errors with the FORM view of catalogue_stats.pl.  I'll send a subsequent patch to deal with these.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3219: handle variation in Amazon responses
Galen Charlton [Tue, 26 May 2009 19:20:03 +0000 (14:20 -0500)]
bug 3219: handle variation in Amazon responses

An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3261: Fix for invalid XHTML on Personal Details page.
Garry Collum [Wed, 27 May 2009 01:32:42 +0000 (21:32 -0400)]
Bug 3261: Fix for invalid XHTML on Personal Details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup view_holdsqueue.pl and .tmpl (minor)
Joe Atzberger [Fri, 22 May 2009 21:45:51 +0000 (16:45 -0500)]
Cleanup view_holdsqueue.pl and .tmpl (minor)

Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agominor fix - don't declare variables in a conditional
Galen Charlton [Wed, 27 May 2009 11:53:17 +0000 (06:53 -0500)]
minor fix - don't declare variables in a conditional

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup branchtransfers
Joe Atzberger [Fri, 22 May 2009 20:31:07 +0000 (15:31 -0500)]
Cleanup branchtransfers

Remove unused sub and variables.
Convert to using GetBranchesLoop instead of local code.
Use elsif where appropriate.
Added fallback values and enabled warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup transferstoreceive.pl and .tmpl
Joe Atzberger [Fri, 22 May 2009 19:35:35 +0000 (14:35 -0500)]
Cleanup transferstoreceive.pl and .tmpl

Removed unused variables.  Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field.  Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.

Mostly whitespace edits in template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>