]> git.koha-community.org Git - koha.git/log
koha.git
16 years agoMajor SIP components reworked.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:55 +0000 (18:14 -0500)]
Major SIP components reworked.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoExpanded SIP config file.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:54 +0000 (18:14 -0500)]
Expanded SIP config file.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoObject oriented module is not an Exporter.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:53 +0000 (18:14 -0500)]
Object oriented module is not an Exporter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd debugging around readline.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:52 +0000 (18:14 -0500)]
Add debugging around readline.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSIP tests for renew and renew_all.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:51 +0000 (18:14 -0500)]
SIP tests for renew and renew_all.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDebugging util. script for SIP config XML.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:50 +0000 (18:14 -0500)]
Debugging util. script for SIP config XML.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTweak verify_cksum.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:49 +0000 (18:14 -0500)]
Tweak verify_cksum.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSIP abstraction layer implementation for ILS, Items and Patrons.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:48 +0000 (18:14 -0500)]
SIP abstraction layer implementation for ILS, Items and Patrons.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAbstraction layer implementation for Transactions.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:47 +0000 (18:14 -0500)]
Abstraction layer implementation for Transactions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd check to resensitize sub.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:46 +0000 (18:14 -0500)]
Add check to resensitize sub.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoObject oriented module is not an Exporter. 2 subs added, also.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:45 +0000 (18:14 -0500)]
Object oriented module is not an Exporter. 2 subs added, also.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrect package name.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:44 +0000 (18:14 -0500)]
Correct package name.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoObject Oriented module is not an Exporter.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:43 +0000 (18:14 -0500)]
Object Oriented module is not an Exporter.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd do_renew_all function, necessary for implementation.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:42 +0000 (18:14 -0500)]
Add do_renew_all function, necessary for implementation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoWhitespace cleanup and one commented-out function added.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:41 +0000 (18:14 -0500)]
Whitespace cleanup and one commented-out function added.

Verify with: git diff -w  C4/SIP/Sip/Configuration.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTrivial POD revision.
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:40 +0000 (18:14 -0500)]
Trivial POD revision.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSIP/t - test files adapted, supplemented, expanded. Note: requires matching data...
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:39 +0000 (18:14 -0500)]
SIP/t - test files adapted, supplemented, expanded. Note: requires matching data to be loaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSIP/koha_test - remove duplicative tests
Joe Atzberger (siptest [Wed, 4 Jun 2008 23:14:38 +0000 (18:14 -0500)]
SIP/koha_test - remove duplicative tests

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoConvert to using loop_context_vars for rows instead of highlight/toggle/whatever.
Joe Atzberger [Wed, 4 Jun 2008 20:21:41 +0000 (15:21 -0500)]
Convert to using loop_context_vars for rows instead of highlight/toggle/whatever.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemove bad use of map in void context, exclusively for side effects!
Joe Atzberger [Wed, 4 Jun 2008 20:21:40 +0000 (15:21 -0500)]
Remove bad use of map in void context, exclusively for side effects!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd Debug for warns and remove unnecessary middleman variables from returns.
Joe Atzberger [Wed, 4 Jun 2008 20:21:39 +0000 (15:21 -0500)]
Add Debug for warns and remove unnecessary middleman variables from returns.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoShow copy/volume info on STAFF detail page.
Joe Atzberger [Tue, 3 Jun 2008 17:40:18 +0000 (12:40 -0500)]
Show copy/volume info on STAFF detail page.

This change helps the staff side catch up w/ the OPAC display and be
more useful to librarians dealing with serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix is_approved() to handle the 3-state nature of approval.
Joe Atzberger [Tue, 3 Jun 2008 14:27:15 +0000 (09:27 -0500)]
Bugfix is_approved() to handle the 3-state nature of approval.

That is, a term is either approved, or rejected, or neither.
Without an external dictionary, most terms will fall into the
latter category.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agominor changes in french translation
Paul POULAIN [Mon, 2 Jun 2008 13:39:18 +0000 (15:39 +0200)]
minor changes in french translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation updated
Paul POULAIN [Mon, 2 Jun 2008 13:39:15 +0000 (15:39 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agore fixing opac-suggestion < misplaced
Paul POULAIN [Mon, 2 Jun 2008 13:39:14 +0000 (15:39 +0200)]
re fixing opac-suggestion < misplaced

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agohtml fix (detected by translator)
Paul POULAIN [Mon, 2 Jun 2008 13:39:12 +0000 (15:39 +0200)]
html fix (detected by translator)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agosmall fixes in french translation
Paul POULAIN [Mon, 2 Jun 2008 13:39:11 +0000 (15:39 +0200)]
small fixes in french translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix to have the branch search on OPAC being really a branch search, not kw
Paul POULAIN [Mon, 2 Jun 2008 13:39:10 +0000 (15:39 +0200)]
fix to have the branch search on OPAC being really a branch search, not kw

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agodisplay itemnote on check-out (added, was not here) & check-in (red-ed, was already...
Paul POULAIN [Mon, 2 Jun 2008 13:39:09 +0000 (15:39 +0200)]
display itemnote on check-out (added, was not here) & check-in (red-ed, was already here)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd MARC preview to cataloguing search, and add a link to add holdings. Once the...
Ryan Higgins [Mon, 2 Jun 2008 23:23:25 +0000 (18:23 -0500)]
Add MARC preview to cataloguing search, and add a link to add holdings. Once the edititems permission patch is accepted, this page should be updated to require edititems instead of editcatalogue.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadd single-transaction flag to mysqldump in example backup script.
Ryan Higgins [Mon, 2 Jun 2008 23:23:09 +0000 (18:23 -0500)]
add single-transaction flag to mysqldump in example backup script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRestrict OPAC tags display to approved=>1.
Joe Atzberger [Mon, 2 Jun 2008 18:16:32 +0000 (13:16 -0500)]
Restrict OPAC tags display to approved=>1.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrection to: Comment out confirmation popups (on successful events).
Joe Atzberger [Mon, 2 Jun 2008 17:43:22 +0000 (12:43 -0500)]
Correction to: Comment out confirmation popups (on successful events).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoComment out confirmation popups (on successful events).
Joe Atzberger [Mon, 2 Jun 2008 17:33:33 +0000 (12:33 -0500)]
Comment out confirmation popups (on successful events).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2078 - settle on application/xml Content-type for feeds
Galen Charlton [Mon, 2 Jun 2008 15:53:38 +0000 (10:53 -0500)]
kohabug 2078 - settle on application/xml Content-type for feeds

Required by IE6 to at least get a feed to display as XML
in the browser instead of being downloaded.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2078 - send correct Content-type for search feeds
Galen Charlton [Mon, 2 Jun 2008 14:05:04 +0000 (09:05 -0500)]
kohabug 2078 - send correct Content-type for search feeds

OPAC search RSS and ATOM feeds now have the correct
Content-type sent - "application/rss+xml" and "application/atom+xml",
respectively.

As part of this patch, added an optional fourth parameter
to C4::Output::output_html_with_http_headers to specify
the content type.  If that parameter is now supplied, or if
the value of the parameter does not contain at least a "/",
the default type of "text/html" is returned.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2078 - removed ersatz ESCAPE="html" added in prior patch
Galen Charlton [Mon, 2 Jun 2008 14:05:03 +0000 (09:05 -0500)]
kohabug 2078 - removed ersatz ESCAPE="html" added in prior patch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2078 - fixed channel links in Atom and RSS
Galen Charlton [Mon, 2 Jun 2008 13:13:35 +0000 (08:13 -0500)]
kohabug 2078 - fixed channel links in Atom and RSS

query_cgi already includes the "q=" bit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOPACBaseURL - do not tack on :443 if using SSL
Galen Charlton [Mon, 2 Jun 2008 13:13:34 +0000 (08:13 -0500)]
OPACBaseURL - do not tack on :443 if using SSL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2078 - fix feed validation errors
Galen Charlton [Mon, 2 Jun 2008 02:43:31 +0000 (21:43 -0500)]
kohabug 2078 - fix feed validation errors

Fix several validation errors in RSS and Atom feeds
generated from the OPAC:

- add missing guid to RSS elements
- add missing feed ID and element ID to Atom elements
- reflect OPACBaseURL changes
- fix atom:link self links
- add HTML escaping to fields comming from bib record
- set default timestamp for Atom updated elements

Issues identified but not solved in this patch:

- setting Atom updated element for each bib (presumably
  from biblio.timestamp)
- possible problems performing paging of Atom feed

Based on successful validation of feeds by feedvalidatory.org,
it is expected that feeds should now work in IE7 and IE6.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocalculate OPACBaseURL instead of using syspref
Galen Charlton [Mon, 2 Jun 2008 02:43:30 +0000 (21:43 -0500)]
calculate OPACBaseURL instead of using syspref

Calculate OPACBaseURL from the
CGI environment variables instead of using the
system preference.  As a result of this patch,
it should be possible to change the hostname,
protocol, or port of the OPAC without having to
reset a system preference.

Also added a FIXME to opac/unapi - the URL of
the SRU/W server has no necessary relationship
to the URL of the OPAC.

Once this patch is confirmed, the syspref can
be removed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2180 - improve display when fines block checkouts
Galen Charlton [Mon, 2 Jun 2008 02:43:28 +0000 (21:43 -0500)]
kohabug 2180 - improve display when fines block checkouts

If a patron's fine balance is over the limit set by the
noissuecharges syspref, checkouts are blocked.  However,
this was not made very clear in the interface.

Improved the display by doing the following:

[1] If the fine balance is over the noissuecharges limit, use the "blocker"
styling (i.e., make all of the text red).
[2] Add wording to explicitly signal whether or not the fine balance is
blocking charges.

Documentation changes: new screenshots of blocked checkouts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoApply item-level_itypes syspref to MARC export.
Ryan Higgins [Sun, 1 Jun 2008 17:48:54 +0000 (12:48 -0500)]
Apply item-level_itypes syspref to MARC export.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIndependent-branchify MARC export. Add option to remove all holdings except your...
Ryan Higgins [Sun, 1 Jun 2008 17:25:17 +0000 (12:25 -0500)]
Independent-branchify MARC export. Add option to remove all holdings except your own, and force that behavior for independent branches. Also add accession date limit to export.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSort dropdowns for libraries by name instead of branchcode in several staff-side...
Ryan Higgins [Sun, 1 Jun 2008 14:56:49 +0000 (09:56 -0500)]
Sort dropdowns for libraries by name instead of branchcode in several staff-side interfaces.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemove commented deprecated code and a useless query on items.
Ryan Higgins [Sun, 1 Jun 2008 14:56:30 +0000 (09:56 -0500)]
Remove commented deprecated code and a useless query on items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemove a couple of warns.
Ryan Higgins [Sun, 1 Jun 2008 14:56:15 +0000 (09:56 -0500)]
Remove a couple of warns.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoItems from Bug 2167 ("URL handling in staff client inconsistent"): Removing display...
Owen Leonard [Sat, 31 May 2008 19:31:05 +0000 (14:31 -0500)]
Items from Bug 2167 ("URL handling in staff client inconsistent"): Removing display of URL from moredetail.pl. URLs are now displayed on detail.pl just as they are in the OPAC. Also removing display of biblio-level call number. Item level call number is displayed already.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 2183, "Account tab needs spacing between description and stadard text...
Owen Leonard [Sat, 31 May 2008 19:08:57 +0000 (14:08 -0500)]
Fix for bug 2183, "Account tab needs spacing between description and stadard text" Please note that this is a band-aid for a larger issue, described in Bug 2188

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix 1979 - display hold numbers. Note that hold priorities are still buggy.
Joe Atzberger [Sat, 31 May 2008 15:33:24 +0000 (10:33 -0500)]
Bugfix 1979 - display hold numbers. Note that hold priorities are still buggy.

But that is a separate bug from whether they display or not.
Also added basic error handling if biblionumber is not received, or
if biblionumber is bad, since that otherwise crashes the page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAddresses Bug 2073, clarifying OpacCloud's limitations.
Joe Atzberger [Sat, 31 May 2008 14:38:55 +0000 (09:38 -0500)]
Addresses Bug 2073, clarifying OpacCloud's limitations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoPrinters code paring, related to bug 2045. This does not resolve the bug,
Joe Atzberger [Sat, 31 May 2008 14:38:54 +0000 (09:38 -0500)]
Printers code paring, related to bug 2045. This does not resolve the bug,

but it converts the template to using loop_context_var, and removes unused
variables from the script.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix typo in field name, apply branchcode selector logic from fines-ll.
Joe Atzberger [Sat, 31 May 2008 05:06:55 +0000 (00:06 -0500)]
Fix typo in field name, apply branchcode selector logic from fines-ll.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFIXME added to note discrepancy.
Joe Atzberger [Sat, 31 May 2008 05:06:54 +0000 (00:06 -0500)]
FIXME added to note discrepancy.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoWrap up Tags integration - add sysprefs for new installs.
Joe Atzberger [Sat, 31 May 2008 05:01:51 +0000 (00:01 -0500)]
Wrap up Tags integration - add sysprefs for new installs.

Note that when the user is not logged in, the Tags input box/button will not display.
The user will see a message telling them to log in to add tags.  However, in order to
keep the results display clean, the message will display only once, utilizing the loop
context variable "__first__".  Useful stuff!

I also threw OPACShelfBrowser sysprefs.sql, but it still needs added to updatedatabase.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2186 - improve display of empty import batches
Galen Charlton [Fri, 30 May 2008 19:37:33 +0000 (14:37 -0500)]
kohabug 2186 - improve display of empty import batches

[1] Display the "No records have been staged" message only
    if no import batches exist.
[2] When displaying a batch that has no bibs in it, display
    a "There are no records in this batch to import".  Also,
    do not display the "import record into catalogue" button
    for an empty batch.
[3] Add CSS class "problem" to both messages.

Documentation changes: minor; only required if screenshots
exist of the manage staged MARC records page that has no
import batches on it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX issuingrules : total for all itemtype was not properly calculated
Paul POULAIN [Wed, 28 May 2008 16:48:07 +0000 (18:48 +0200)]
BUGFIX issuingrules : total for all itemtype was not properly calculated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding orderby parameter : Fixes changing page in auth_finder.pl
Henri-Damien LAURENT [Mon, 19 May 2008 15:54:42 +0000 (17:54 +0200)]
Adding orderby parameter : Fixes changing page in auth_finder.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFrom HDL:
Joshua Ferraro [Fri, 30 May 2008 18:56:17 +0000 (13:56 -0500)]
From HDL:

I agree that opac-suggestions.tmpl modification is Not required any longer.
But still, the modification in opac-suggestions.pl is really necessary.
If you donot do that, ppl are presented with ALL suggestions and not
their suggestions by default, which is not what My Suggestions suggests.

16 years agoAdding search on ISSN for z3950_search.pl
Henri-Damien LAURENT [Mon, 26 May 2008 14:37:06 +0000 (16:37 +0200)]
Adding search on ISSN for z3950_search.pl

seems that search on ISSN was not taken into account adding @or @attr 1=8

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoving autotruncate for authors.
Henri-Damien LAURENT [Mon, 26 May 2008 13:53:23 +0000 (15:53 +0200)]
removing autotruncate for authors.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing typo in DB update
NCE [Fri, 30 May 2008 17:31:12 +0000 (13:31 -0400)]
Fixing typo in DB update

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadd borrower note to check-in
Paul POULAIN [Fri, 30 May 2008 14:33:38 +0000 (16:33 +0200)]
add borrower note to check-in

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoenhance the patron note on check-out (was not enough visible, now is red)
Paul POULAIN [Fri, 30 May 2008 14:33:36 +0000 (16:33 +0200)]
enhance the patron note on check-out (was not enough visible, now is red)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIf the catalogue contains a value that is not in authorised values and it should...
Paul POULAIN [Wed, 28 May 2008 20:33:56 +0000 (22:33 +0200)]
If the catalogue contains a value that is not in authorised values and it should, display the code

very usefull for us (UNIMARC) to find languages that are in the database but not in the auth values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDisplaying branchcode and notes fields in full serials issue table.
Paul POULAIN [Wed, 28 May 2008 16:48:11 +0000 (18:48 +0200)]
Displaying branchcode and notes fields in full serials issue table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRespect BiblioDefaultView when search returns only 1 result & jump directly to the...
Paul POULAIN [Wed, 28 May 2008 16:48:10 +0000 (18:48 +0200)]
Respect BiblioDefaultView when search returns only 1 result & jump directly to the detail

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agosmall (UNIMARC) fix, error in regexp writing
Paul POULAIN [Wed, 28 May 2008 16:48:09 +0000 (18:48 +0200)]
small (UNIMARC) fix, error in regexp writing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agochange in button description to explain that we will import into catalogue
Paul POULAIN [Wed, 28 May 2008 16:48:08 +0000 (18:48 +0200)]
change in button description to explain that we will import into catalogue

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadd script to install koha on a fresh debian.
Marc Chantreux [Fri, 30 May 2008 16:15:05 +0000 (18:15 +0200)]
add script to install koha on a fresh debian.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/
Joshua Ferraro [Fri, 30 May 2008 16:36:04 +0000 (11:36 -0500)]
nomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/

16 years agoAdding branchcode to opac-full-serial-issues
Henri-Damien LAURENT [Mon, 26 May 2008 14:37:07 +0000 (16:37 +0200)]
Adding branchcode to opac-full-serial-issues

Suggestion : We may add some jquery ordering on those tables
Can we owen ?

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDB Revision 087
Joshua Ferraro [Fri, 30 May 2008 16:17:21 +0000 (11:17 -0500)]
DB Revision 087

16 years agoadding default 'account details' notice.
Mason James [Thu, 22 May 2008 09:23:43 +0000 (21:23 +1200)]
adding default 'account details' notice.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug-2149, var fix - changing borr.cardnumber to borr.userid.
Mason James [Thu, 22 May 2008 09:23:36 +0000 (21:23 +1200)]
bug-2149, var fix - changing borr.cardnumber to borr.userid.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug-2149, added 'AutoEmailOpacUser' and 'AutoEmailPrimaryAddress' sysprefs
Mason James [Thu, 22 May 2008 09:23:24 +0000 (21:23 +1200)]
bug-2149, added 'AutoEmailOpacUser' and 'AutoEmailPrimaryAddress' sysprefs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug-2149, added new block to C4::Letters::SendAlerts() to email 'account creation...
Mason James [Thu, 22 May 2008 09:23:14 +0000 (21:23 +1200)]
bug-2149, added new block to C4::Letters::SendAlerts() to email 'account creation' notice, and new block in memberentry.pl to call SendAlerts().

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRepair Labels code to accomodate patroncards. Purged EXPR.
Joe Atzberger [Thu, 29 May 2008 18:15:23 +0000 (13:15 -0500)]
Repair Labels code to accomodate patroncards. Purged EXPR.

Major FIXME's still remain, like the use of GET instead of POST.
The code is also a bit too INCLUDE-happy to net good performance.
The entire mechanism of adding to a batch should probably be proper
AJAX instead of the GET-centric opener.location approach.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing some typos, including, I believe, Bug 2174 ("spelling error in web installer")
Owen Leonard [Thu, 29 May 2008 14:59:35 +0000 (09:59 -0500)]
Fixing some typos, including, I believe, Bug 2174 ("spelling error in web installer")

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agominor cleanup, remove $sth->finish's. No documentation impact.
Joe Atzberger [Thu, 29 May 2008 13:59:25 +0000 (08:59 -0500)]
minor cleanup, remove $sth->finish's. No documentation impact.

For details: see http://search.cpan.org/~timb/DBI-1.14/DBI.pm
"There's no need to call finish if you're about to destroy or re-execute the statement handle."
In all these cases the sth is falling out of scope, about to be destroyed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agois_ajax function added. pagination_bar now intelligent: it has
Joe Atzberger [Thu, 29 May 2008 13:59:24 +0000 (08:59 -0500)]
is_ajax function added. pagination_bar now intelligent: it has

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving dbh line altogether as discussed on koha-patches
Joshua Ferraro [Thu, 29 May 2008 12:17:59 +0000 (07:17 -0500)]
Removing dbh line altogether as discussed on koha-patches

16 years agoBug Fix : Creating a new authority type would fail on creating subfield_structure
Henri-Damien LAURENT [Tue, 20 May 2008 15:40:24 +0000 (17:40 +0200)]
Bug Fix : Creating a new authority type would fail on creating subfield_structure

removing "link" field which has been removed from table auth_subfield_structure
Removing a $dbh->disconnect

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2164 - display of guarantor relationship
Galen Charlton [Wed, 28 May 2008 17:08:47 +0000 (12:08 -0500)]
kohabug 2164 - display of guarantor relationship

When editing a child or professional patron, display
the drop-down of relationship types only if at least
one relationship type is defined by the borrowerRelationship
syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTags AJAX integration on OPAC details page, so it behaves like results.
Joe Atzberger [Thu, 29 May 2008 01:31:28 +0000 (20:31 -0500)]
Tags AJAX integration on OPAC details page, so it behaves like results.

Also, prevent duplicate tags (same user, biblio and term).  Strip
leading/trailing whitespace from term.  Block whitespace terms.
The CSS for details could be enhanced to emphasize tagstatus more.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMake printslip and printpage buttons use popup.
Joe Atzberger [Wed, 28 May 2008 20:33:07 +0000 (15:33 -0500)]
Make printslip and printpage buttons use popup.

This bug was reported by existing users.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrect typo "printslilp" to "printslip"
Joe Atzberger [Wed, 28 May 2008 20:33:06 +0000 (15:33 -0500)]
Correct typo "printslilp" to "printslip"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFines repair. Make fines2.pl work, give feedback, improve comments and perldoc.
Joe Atzberger [Tue, 27 May 2008 23:06:01 +0000 (18:06 -0500)]
Fines repair. Make fines2.pl work, give feedback, improve comments and perldoc.

Remove $dbh->disconnect statements as counterproductive.
Prevent description field from begining with whitespace.
Added robust debug elements.  Test script behavior with:
    perl misc/cronjobs/fines2.pl -v
and:
mysql> select * from accountlines;

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding basic get_filters to Tags, centralizing "counts" code for Terms Summary.
Joe Atzberger [Tue, 27 May 2008 23:06:00 +0000 (18:06 -0500)]
Adding basic get_filters to Tags, centralizing "counts" code for Terms Summary.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemove string processing (redundant to new pagination_bar)
Joe Atzberger [Tue, 27 May 2008 23:05:59 +0000 (18:05 -0500)]
Remove string processing (redundant to new pagination_bar)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSingle FIXME comment inserted.
Joe Atzberger [Tue, 27 May 2008 23:05:58 +0000 (18:05 -0500)]
Single FIXME comment inserted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCommented out fixaccounts (not used anywhere). Also improved getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:05:57 +0000 (18:05 -0500)]
Commented out fixaccounts (not used anywhere). Also improved getnextacctno.

You can test getnextacctno like:
perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table.  Get that number like:
mysql> select borrowernumber,accountno from accountlines LIMIT 100;

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrect number of args to getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:04:13 +0000 (18:04 -0500)]
Correct number of args to getnextacctno.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrected wrong number of arguments to getnextacctno.
Joe Atzberger [Tue, 27 May 2008 23:04:12 +0000 (18:04 -0500)]
Corrected wrong number of arguments to getnextacctno.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Joe Atzberger [Thu, 22 May 2008 20:10:22 +0000 (15:10 -0500)]
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.

Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix 1978 - if invalid duedate specified, return error, do not issue.
Joe Atzberger [Thu, 22 May 2008 15:24:09 +0000 (10:24 -0500)]
Bugfix 1978 - if invalid duedate specified, return error, do not issue.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed session cookie name in opac-logout.pl
Michael Hafen [Tue, 27 May 2008 18:11:21 +0000 (12:11 -0600)]
fixed session cookie name in opac-logout.pl

Session Cookie name is CGISESSID in Auth.pm

Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUnescape Comment, now that we trust Scrubber to block bad markup.
Joe Atzberger [Fri, 23 May 2008 07:40:49 +0000 (02:40 -0500)]
Unescape Comment, now that we trust Scrubber to block bad markup.

Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
br b i em big small strong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTags AJAX and JSON for OPAC side.
Joe Atzberger [Wed, 21 May 2008 06:36:05 +0000 (01:36 -0500)]
Tags AJAX and JSON for OPAC side.

Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples.  The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>