]> git.koha-community.org Git - koha.git/log
koha.git
10 years agoBug 11392: (follow-up) fix syntax error in template
Galen Charlton [Fri, 23 May 2014 15:02:27 +0000 (15:02 +0000)]
Bug 11392: (follow-up) fix syntax error in template

In the two FOREACH loops introduced by the patch, wrap
the module and action names with quotes.  This fixes a
problem where parsing the template crashes with the following
error:

  Template process failed: file error - parse error - .../viewlog.tt line 83: unexpected token (RETURN)
    [% FOREACH actx IN [ ADD DELETE MODIFY ISSUE RETURN CREATE ] %] at .../C4/Templates.pm line 132.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11392: Allow translating the viewlog module and action names
Pasi Kallinen [Fri, 9 May 2014 10:40:14 +0000 (13:40 +0300)]
Bug 11392: Allow translating the viewlog module and action names

When viewing the logs, the user can see module and action,
such as "SYSTEMPREFERENCE", "MEMBERS" or "CREATE", "MODIFY", etc.
These texts are not translatable.

This patch allows translating those. It also adds the missing "CREATE"
action to the pulldown.

To test:

1) Go browse the system logs. Note the contents of the "Action" and
"Module" -pulldowns, and the contents of those columns in the log table.
2) Apply patch
3) Go browse the system logs again. The pull-downs should work, and
show the same values as before (plus "Create" for Action), and the
Action and Module -columns in the log table should not be in ALL CAPS.
4) cd misc/translator
5) perl translate update xx-YY
6) Check that the po/xx-YY-i-staff-t-prog-v-3006000.po contains the
values for the pull-downs in it. (Look for eg. "System prefs")

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11365: (follow-up) trim whitespace in the translate_card_element block
Galen Charlton [Fri, 23 May 2014 14:46:54 +0000 (14:46 +0000)]
Bug 11365: (follow-up) trim whitespace in the translate_card_element block

Trim leading and trailing whitespace in the text generated
by the translate_card_element block to avoid generating
unescaped multi-line strings, which breaks the JavaScript

To test:

[1] Test actions in the patron card creator that generate
    JavaScript alerts, such as hitting the delete button
    without first selecting a batch or profile.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11365: make label card element title texts translatable
Pasi Kallinen [Tue, 6 May 2014 08:49:39 +0000 (11:49 +0300)]
Bug 11365: make label card element title texts translatable

To test:

1) cd misc/translator
2) perl translate update xx-YY
3) check that there's no msgid that contains the patron card label
   element title texts in po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
   msgid. (search for "BLOCK translate_card_element")

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. Tested updating po file, translating and installing
language, checked on tools page.
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11856: Add confirm option to POD in advance_notices.pl
Marcel de Rooy [Thu, 17 Apr 2014 09:59:55 +0000 (11:59 +0200)]
Bug 11856: Add confirm option to POD in advance_notices.pl

Also removes a commented line that changed the value of $confirm.
If it would default to 1, we do not need it at all.
I am not saying that we need it, but just documenting that we have it.

Signed-off-by: Marc Véron <veron@veron.ch>
Small change in documentation.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12165: (follow-up) display record title
Jonathan Druart [Thu, 8 May 2014 14:55:49 +0000 (16:55 +0200)]
Bug 12165: (follow-up) display record title

The code introduced by bug 2546 uses an undefined variable (line.title).
It should be ACCOUNT_LINE.title.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme
Katrin Fischer [Wed, 30 Apr 2014 19:14:50 +0000 (21:14 +0200)]
Bug 12165: Add descriptions of charges (bug 2546) to Bootstrap Opac theme

1) Create an account with lots of different charges, fines, fees, etc.
2) Look at the accounts tab in the prog OPAC theme
3) Compare the page to bootstrap theme
4) Verify display is now the same

In my tests I found some things that could still be improved,
but for the goal is to make all OPAC themes behave the same.

Signed-off-by: Marc Véron <veron@veron.ch>
Tested by changing accounttype in table accountlines to all possible
values like Pay, Pay00, Pay01 etc.  Both themes display the same values,
e.g. "Payment, thanks (cash via SIP2)" for Pay00

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12147: Convert action links on invoices pages to a menu
Owen Leonard [Mon, 12 May 2014 08:25:38 +0000 (10:25 +0200)]
Bug 12147: Convert action links on invoices pages to a menu

Prior to this patch, the column for displaying the action links
was too narrow, leading to an ugly display.  This patch groups
"action" links into a menu as was done with Bug 11763.

This patch also converts the date column sorting configuration to use
header class instead of an index.

This patch also corrects a couple of HTML markup errors: An
improperly-closed <input> and an improperly closed <option>.

To test, view the invoices page and confirm that the "Actions" menu
button works corectly. Test the functionality of each menu options:
Details, Close, Reopen, and Delete. Confirm that sorting by billing date
still works correctly.

Much nicer user interface. Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10330: DBRev 3.17.00.001
Galen Charlton [Fri, 23 May 2014 13:29:39 +0000 (13:29 +0000)]
Bug 10330: DBRev 3.17.00.001

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10330: (follow-up) fix missed case of authoritysep
Mark Tompsett [Thu, 10 Apr 2014 04:13:29 +0000 (00:13 -0400)]
Bug 10330: (follow-up) fix missed case of authoritysep

$ git grep authoritysep
This showed:
1) the updatedatabase.pl script, as expected,
2) lots of po files,
3) a test file that was missed.

TEST PLAN
---------
1) prove -v t/db_dependent/Search.t
2) Run koha QA test tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work (both patches). Test pass. No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10330 - Rename system preference authoritysep to AuthoritySeperator
Kyle M Hall [Fri, 24 May 2013 11:54:42 +0000 (07:54 -0400)]
Bug 10330 - Rename system preference authoritysep to AuthoritySeperator

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) View some records with authorities
4) Note your previously set authority separator should still be in use

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12023: (follow-up) fix redirect to step 3
Jonathan Druart [Thu, 22 May 2014 11:00:07 +0000 (13:00 +0200)]
Bug 12023: (follow-up) fix redirect to step 3

This patch fixes the redirection to step 3.

If you go on installer/install.pl and Koha is already installed,
you should be redirected to the step 3. Without this patch, the
script raised an internal error (500).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12023 - move InstallAuth.pm to be in C4
Robin Sheat [Wed, 2 Apr 2014 04:20:08 +0000 (17:20 +1300)]
Bug 12023 - move InstallAuth.pm to be in C4

InstallAuth was in the installer directory, which meant that Plack was
unable to find it, and so running the webinstaller would fail. This
moves it into C4,

Test plan:
* Make sure the web installer runs under plack
* Make sure the web installer runs under non-plack

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12190: fold the "Creators" system preference tab into "Tools"
Galen Charlton [Tue, 6 May 2014 20:24:52 +0000 (20:24 +0000)]
Bug 12190: fold the "Creators" system preference tab into "Tools"

The "Creators" tab in the system preferences editor had only one
preference.  In order to consolidate the display as well as to
address the issue that "creators" doesn't have much of a connection
to "patron cards", the ImageLimit system preference is moved to
the Tools tab by this patch.

To test:

[1] Verify that the ImageLimit preference now shows up in the
    Tools tab in the system preference editor (along with an
    existing Tools preference, MaxItemsForBatch.
[2] Verify that the sysprefs editor no longer has a "Creators"
    tab.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10936: (prog theme) remove duplicate 'Standard number' option in Advanced search
Marc Véron [Thu, 10 Apr 2014 06:42:46 +0000 (08:42 +0200)]
Bug 10936: (prog theme) remove duplicate 'Standard number' option in Advanced search

TEST PLAN
---------
1) Set opacthemes system preference to prog
2) In OPAC, click 'Advanced search'
3) Click 'More options'
4) Check the Keywords dropdown for duplicate 'Standard number'
5) Apply patch
6) Refresh page, and make sure 'More options' is clicked still
7) Check the Keywords dropdown for duplicate 'Standard number'
   -- it's not this time

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described on prog theme, no more duplicate.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10936: remove duplicate 'Standard number' option in Advanced search
Jesse Maseto [Fri, 28 Mar 2014 15:02:18 +0000 (11:02 -0400)]
Bug 10936: remove duplicate 'Standard number' option in Advanced search

This patch removes the duplicate 'Standard number' option
under the more options of the OPAC advanced search correctly
following updates from Katrin.

TEST PLAN
---------
1) Set opacthemes system preference to bootstrap
2) In OPAC, click 'Advanced search'
3) Click 'More options'
4) Check the Keywords dropdown for duplicate 'Standard number'
5) Apply patch
6) Refresh page, and make sure 'More options' is clicked still
7) Check the Keywords dropdown for duplicate 'Standard number'
   -- it's not this time.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12211: fix wrong home link in bootstrap public catalog login page
Fridolin Somers [Wed, 7 May 2014 15:58:45 +0000 (17:58 +0200)]
Bug 12211: fix wrong home link in bootstrap public catalog login page

In bootstrap opac-auth.tt, the link to "Home" in breadcrumbs leads
to #, it should lead to opac-main.pl like in all other pages.

Test plan :
 - Use boostrap opac theme
 - Go to cgi-bin/koha/opac-user.pl when not logged
=> without patch, clicking on Home does not change the page
=> with patch, clicking on Home leads to opac-main.pl

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Link ok, no errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12106: fix capitalization: "Patron Attributes" on tools/patron import
Owen Leonard [Fri, 2 May 2014 18:33:54 +0000 (14:33 -0400)]
Bug 12106: fix capitalization: "Patron Attributes" on tools/patron import

There are three instances of incorrectly-capitalized "Patron Attributes"
on the patron import page. This patch corrects them.

To test, view the patron import page (Tools -> Import patrons). Confirm
that instances of the phrase "patron attributes" in the bottom-most
fieldset are correctly capitalized.

Followed test plan, works
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12184: fix typo "retricted" on checkin page
Galen Charlton [Tue, 6 May 2014 17:52:35 +0000 (17:52 +0000)]
Bug 12184: fix typo "retricted" on checkin page

To test:

[1] Check an item that belongs to a restricted patron and
    specify a non-default return date.
[2] Verify that the warning message contains "restricted"
    rather than "retricted".

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
Patch applies and makes sense. (I have not checked the actual UI,
but that should not be necessary for such a simple typo correction.)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoDBRev 3.17.00.000: ever onward
Galen Charlton [Thu, 22 May 2014 21:08:20 +0000 (21:08 +0000)]
DBRev 3.17.00.000: ever onward

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agostamp Koha 3.16.0 v3.16.00
Galen Charlton [Thu, 22 May 2014 20:28:23 +0000 (20:28 +0000)]
stamp Koha 3.16.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoupdate release notes for 3.16.0 (human)
Galen Charlton [Thu, 22 May 2014 20:16:25 +0000 (20:16 +0000)]
update release notes for 3.16.0 (human)

Manual edit of the release notes to hopefully make
them more useful.  Also added reminder about the
deprecation of the prog and CCSR public catalog
themes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoupdate of release notes for 3.16.0 (automatic)
Galen Charlton [Thu, 22 May 2014 17:11:19 +0000 (17:11 +0000)]
update of release notes for 3.16.0 (automatic)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12292: ensure that patrons are not displayed as restricted even when the last...
Jonathan Druart [Tue, 20 May 2014 14:07:17 +0000 (16:07 +0200)]
Bug 12292: ensure that patrons are not displayed as restricted even when the last restriction has expired

This is the same issue as bug 12134, but for the patron deatils page.

Test Plan:
1) Add a manual restriction to a patron and wait until the
   expiration date of the restriction has passed.  This can be
   simulated by modifying borrowers.debarred for a borrower and
   setting the date in the past.
2) Go on the detail page for a patron (members/moremember.pl)
3) Note the warning message
    "Patron is restricted until XX/XX/XXXX View restrictions"
4) Apply this patch
5) Repeat step 2
6) Note the warning message does not appear anymore

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no errors.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoTranslation updates for 3.16.00 final release
Bernardo Gonzalez Kriegel [Thu, 22 May 2014 12:39:57 +0000 (09:39 -0300)]
Translation updates for 3.16.00 final release

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12274: Invoice detail: don't crash on certain billing dates
Jonathan Druart [Tue, 20 May 2014 11:39:26 +0000 (13:39 +0200)]
Bug 12274: Invoice detail: don't crash on certain billing dates

Bug 10613 sent the billingdate as a string. The template wants a DateTime
object.

To reproduce:
1/ Go on a invoice detail page
2/ Select a billing date
3/ Boom without the patch
[Tue May 20 13:39:18 2014] invoice.pl: Template process failed: undef
error - The 'day' parameter ("2014") to DateTime::new did not pass the
'an integer which is a possible valid day of month' callback.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Not all dates will make it go 'boom' but 31/07/2014 did.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12274: handle closed invoices properly on invoice details page
Jacek Ablewicz [Sat, 17 May 2014 08:30:15 +0000 (10:30 +0200)]
Bug 12274: handle closed invoices properly on invoice details page

Trivial fix for small regression (closed invoices are displayed as
"Open" on details page, and it's not possible to reopen the closed
invoice using "Save" button) introduced by bug 10613.

Test plan:

1) Create and close some invoices
2) Note that closed invoices are erroneously displayed as "Open"
on individual invoice[s] details page
3) Apply patch
4) Check previously closed invoices; their status on details page
should now be properly displayed as "Closed on ..." (and an option
for reopening would reappear as well)
5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button
do work as expected for individual open / closed invoices respectivelly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12282: fix RESERVESLIP in German sample notices
Katrin Fischer [Sun, 18 May 2014 22:28:25 +0000 (00:28 +0200)]
Bug 12282: fix RESERVESLIP in German sample notices

Accidentally the ISSUESLIP got copied to the RESERVESLIP.
This adds the correct text and formatting to the RESERVESLIP.

To test:
- Run the German web installer on an empty database
- Check that the ISSUESLIP and RESERVESLIP notices are different
  and display correctly

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested using webinstaller, all optionals, all ok.
ISSUESLIP(Ausleihquittung) longer than RESERVESLIP(Vormerkung)
No errors

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoDBRev 3.15.00.052: mark Koha 3.16 RC v3.16.00-rc
Galen Charlton [Mon, 19 May 2014 23:16:06 +0000 (23:16 +0000)]
DBRev 3.15.00.052: mark Koha 3.16 RC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoupdate release notes for Koha 3.16.0-rc
Galen Charlton [Mon, 19 May 2014 23:14:31 +0000 (23:14 +0000)]
update release notes for Koha 3.16.0-rc

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10964: Update German default bibliographic and authority frameworks
Katrin Fischer [Sat, 17 May 2014 13:35:42 +0000 (15:35 +0200)]
Bug 10964: Update German default bibliographic and authority frameworks

This updates the German default frameworks for bibliographic records
and authorities using the files created from the po files on Pootle.

To test:
- Run the web installer, make sure all mandatory data is selected
- Verify there are no SQL errors
- Check cataloguing behaves normally
- Check adding authorities behaves normally

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested using webinstaller.
No errors

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 10964: Update German simple and fast add frameworks
Katrin Fischer [Sun, 18 May 2014 07:58:48 +0000 (09:58 +0200)]
Bug 10964: Update German simple and fast add frameworks

This updates the German simple and fast add frameworks
using the files created from the po files on Pootle.

To test:
- Run the web installer, make sure all mandatory data is selected
- Verify there are no SQL errors
- Check cataloguing behaves normally
- Check adding authorities behaves normally

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested using webinstaller
Checked
No errors

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12113: Update German web installer for 3.16
Katrin Fischer [Sat, 17 May 2014 10:36:07 +0000 (12:36 +0200)]
Bug 12113: Update German web installer for 3.16

Changes:
- Translates new notices SHARE_ACCEPT und SHARE_INVITE
- Copies subtag_registry.sql from en as after applying patch
  from bug 12275 - so 'Laotisch' will show up correctly
- Rephrases and corrects spelling for user permissions
- Translates new authorized value SIP_MEDIA_TYPE
- Improves translations of creator sample data
- Improves translations of sample patron categories
  - translations in po files were changed accordingly

To test:
- Run the web installer, install all mandatory and optional
  sample data
- Check everything is installed without errors
- Verify changes listed above in the interface

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Installer works ok, values ok
No errors

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12275: Small corrections to English web installer
Katrin Fischer [Sat, 17 May 2014 10:23:53 +0000 (12:23 +0200)]
Bug 12275: Small corrections to English web installer

- Corrects the German translation for 'Laotisch'
- Adds an icon to the reference item type
- Corrects capitalization for user permissions

To test:
- Run English web installer, make sure to select
  the sample item types and all mandatory data
- Check user permissions appear correctly
- Check icon for REF itemtype is shown correctly
- Check that languages in Advanced Search appear
  as normal
- Install German and check in language list on
  advanced search 'Laotisch' now appears

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works well following test plan.
No errors

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12168: (follow-up) correct typos in test descriptions
Galen Charlton [Mon, 19 May 2014 22:04:45 +0000 (22:04 +0000)]
Bug 12168: (follow-up) correct typos in test descriptions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12168: Add unit tests for GetBudgetHierarchySpent & GetBudgetHierarchyOrdered
Jonathan Druart [Thu, 1 May 2014 12:23:51 +0000 (14:23 +0200)]
Bug 12168: Add unit tests for GetBudgetHierarchySpent & GetBudgetHierarchyOrdered

Test plan:
prove t/db_dependent/Budgets.t

Note: This addition may sound overkill but I found this bug developing
bug 12164 and I will reuse all of that.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12168: fix spent and ordered budget values are wrong when depth >= 2
Jonathan Druart [Thu, 1 May 2014 12:12:18 +0000 (14:12 +0200)]
Bug 12168: fix spent and ordered budget values are wrong when depth >= 2

A really weird (and old) code process the calculation for the spent and
ordered sublevel funds.

It only takes into account the direct children.

So if you have:
fund1 (spent=100) parent of fund11 (spent=10) parent of fund111 (spent=1),
you get:

fund     | base-level | total spent
fund1    | 100        | 110
fund11   | 10         | 11
fund111  | 1          | 1

which is wrong, it should be

fund     | base-level | total spent
fund1    | 100        | 111
fund11   | 10         | 11
fund111  | 1          | 1

Test plan:
- Create 1 budget and 3 funds with the same structure as above.
- Create some orders and receive them (not all).
- Go on the fund list view and verify the values are correct.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11404: (follow-up) only ask user if there are instances needing upgrading
Robin Sheat [Tue, 13 May 2014 01:39:04 +0000 (13:39 +1200)]
Bug 11404: (follow-up) only ask user if there are instances needing upgrading

There's no point asking the user if they want their Apache Koha
configuration updated if there's no configuration needing updated.

This also fixes a case where the updating would have failed when running
on Apache 2.4.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I agree with adding that checks, and the conditions rewrite seems cleaner
than my first approach. So, I sign it.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11404: Make the install process aware of the changes
Tomas Cohen Arazi [Tue, 6 May 2014 18:13:19 +0000 (15:13 -0300)]
Bug 11404: Make the install process aware of the changes

This patch makes the install scripts take care of the new file
and prompt for user confirmation on the apache file renaming step.

Both prompt and the renaming actions depend on the fact that there
are instances with their files missing the .conf appendix.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11404: koha-functions.sh introduced for reuse
Tomas Cohen Arazi [Mon, 5 May 2014 14:50:55 +0000 (11:50 -0300)]
Bug 11404: koha-functions.sh introduced for reuse

As asked by Robin, a bash lib of functions is introduced with the common
functions to be reused. Most of the scripts are modified (reduced) to
include this file and the repeated functions cleaned.

No noticeable change in behaviour should be noticed.

As I've been todl in #debian-mentors, it is used that files for inclusion
should be installed at the apps directory (i.e. /usr/share/koha/) so this
patch makes the install script put the file in the bin/ directory.

All koha-* scripts assume the file is there already (and fail otherwise).

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11404: add support for Apache 2.4's config file convention
Tomas Cohen Arazi [Mon, 16 Dec 2013 17:32:40 +0000 (14:32 -0300)]
Bug 11404: add support for Apache 2.4's config file convention

Apache 2.4 expects the sites definition files use the sufix '.conf'

To reproduce:
- Install the 'koha-common' package on Debian 7 or Ubuntu 13.10+
  (both known to include Apache 2.4).
- Create an instance (for example testlibrary) using the supplied
  commands:
 $ koha-create --create-db testlibrary
> FAIL: apache reports an error like this:
"ERROR: Site testlibrary does not exist!"

This patch adds a test on the Apache version and appends the ".conf"
sufix if needed.

To test:

1st step: koha-create gets fixed:

-- The hard way --
- Apply the patch, and build the koha-common package on top of this
  commit.
- Install the built package on an Apache 2.4 Debian-based distro (Debian 7
  or Ubuntu 13.10 will work)
- Create a test instance:
 $ koha-create --create-db testlibrary
> SUCCESS: no more apache sites related error.

-- The easy way --
- Apply the patch, and copy the koha-create into an Apache 2.4
  Debian-based distro
- Create a test instance using the koha-create script you just
  copied:
 $ ./koha-create --create-db testlibrary
> SUCCESS: no more apache sites related error.

2nd step: the rest of the touched scripts keep working as usual

koha-disable
koha-dump
koha-enable
koha-list
koha-remove
koha-restart-zebra
koha-stop-zebra
koha-start-zebra

They should all keep working. Can be tested "the easy way" too.

Note: there might be another issues regarding Apache 2.4 deployments
like the need for

 $ a2enmod access_compat

and perhaps some directory permissions tweak, which I think should be
properly documented on the install instructions.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12288: (follow-up) test for defined values
Galen Charlton [Mon, 19 May 2014 19:56:14 +0000 (19:56 +0000)]
Bug 12288: (follow-up) test for defined values

This patch adjusts the test so that if an "ISBN" is not
defined (because the source string did not specify a valid
ISBN), it doesn't result in a warning once the warnings
stricture is enabled in C4::Koha.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12288: fix search errors with AggressiveMatchOnISBN turned on
Kyle M Hall [Mon, 19 May 2014 12:37:28 +0000 (08:37 -0400)]
Bug 12288: fix search errors with AggressiveMatchOnISBN turned on

This patch fixes a problem where search errors like this in the logs when
running a stage import with the AggressiveMatchOnISBN syspref turned on:

search failed (isbn,phr=978-0-7517-9745-9 or isbn,phr=0-7517-9745-6 or
isbn,phr=978-0-7517-9745-9 or isbn,phr=0751797456 or
isbn,phr=9780751797459 or isbn,phr=978-0-7517-9759-6 or
isbn,phr=0-7517-9759-6 or isbn,phr=978-0-7517-9759-6 or
isbn,phr=0751797596 or isbn,phr=9780751797596 or isbn,phr= or
isbn,phr= or isbn,phr= or isbn,phr= or isbn,phr=) CCL parsing
error (10014) Search word expected ZOOM at
/usr/share/koha/lib/C4/Matcher.pm line 688.

This is most easily seen when running the script from command line
/misc/stage_file.pl.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12288: add regression test
Galen Charlton [Mon, 19 May 2014 19:29:44 +0000 (19:29 +0000)]
Bug 12288: add regression test

To test:

[1] Run prove -v t/Koha.t.  The last test should fail.
[2] Apply the main patch for this bug.
[3] Run prove -v t/Koha.t again.  This time, all tests should pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoTranslation update for 3.16.00 release
Bernardo Gonzalez Kriegel [Mon, 19 May 2014 18:40:50 +0000 (15:40 -0300)]
Translation update for 3.16.00 release

New languages:

Belarusian be-BY
Faroese fo-FO
Rwandan rw-RW
Swahili sw-KE

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - followup to fix tabs
Bernardo Gonzalez Kriegel [Tue, 13 May 2014 22:47:02 +0000 (19:47 -0300)]
Bug 12244 - followup to fix tabs

Only tab removing

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update Acq Help for 3.16
Nicole C. Engard [Tue, 13 May 2014 13:48:52 +0000 (08:48 -0500)]
Bug 12244 - Update Acq Help for 3.16

This updates the basket help.

To test:

* Open a basket
* Click help and confirm it's right and there

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Help ok

Final comment: koha-qa complains about tabs, removed in followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update Admin Help for 3.16
Nicole C. Engard [Tue, 13 May 2014 13:37:17 +0000 (08:37 -0500)]
Bug 12244 - Update Admin Help for 3.16

This patch updates 3 help files.

To test:

* Visit Administration > Patron Categories
* Click help
* Confirm it's there and right
* Visit Administration > Currencies
* Click help
* Confirm it's there and right
* Visit Administration > Circ Rules
* Click help
* Confirm it's there and right

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Help ok. One comment: on circ rules, I think that "you're" can
be correct, but I prefer "you are"

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update authorized values help for 3.16
Nicole C. Engard [Tue, 13 May 2014 13:27:17 +0000 (08:27 -0500)]
Bug 12244 - Update authorized values help for 3.16

This patch adds a few new values to the authorized values help

To test:

* Visit Administration > Authorized Values
* Click help
* Confirm help is there and correct

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
New values ok

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update Notices Help Files
Nicole C. Engard [Tue, 13 May 2014 13:19:56 +0000 (08:19 -0500)]
Bug 12244 - Update Notices Help Files

Updates the 2 notices help files with new info.

To test:

* Visit Tools > Notices & Slips
* Click help and confirm it's there and right
* Visit Tools > Overdue notices/status triggers
* Click help and confirm it's there and right

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Long help ok

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update Search Help for 3.16
Nicole C. Engard [Tue, 13 May 2014 12:52:48 +0000 (07:52 -0500)]
Bug 12244 - Update Search Help for 3.16

This patch updates the search help file.

To test:

* Visit Search
* Click help
* Confirm help is there and correct

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Help ok

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update cataloging help for 3.16
Nicole C. Engard [Tue, 13 May 2014 12:46:29 +0000 (07:46 -0500)]
Bug 12244 - Update cataloging help for 3.16

This patch adds a bit to the addbiblio help file.

To test:

* Go to Cataloging
* Click add new
* Click help
* Confirm help is there and correct

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Help is ok

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Update Patron help files for 3.16
Nicole C. Engard [Tue, 13 May 2014 12:38:18 +0000 (07:38 -0500)]
Bug 12244 - Update Patron help files for 3.16

This updates the patron help file and adds a missing help file.

To test:

* Go to a patron record
* Click help and confirm text is correct
* Go to patron's purchase suggestions
* Click help and confirm that help file is there and correct

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Both text are correct, link still points to 3.14 manual, but depends
on a value that must change with new release.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12244 - Koha 3.16 Circ Help Updates
Nicole C. Engard [Tue, 13 May 2014 12:24:17 +0000 (07:24 -0500)]
Bug 12244 - Koha 3.16 Circ Help Updates

This patch updates the check in help (the only change for 3.16).

To test:
* Visit Circulation > Check in
* Click Help
* Confirm that help text is right

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Help is right

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 9612: (follow-up) restore elementSetName in Context.pm
Marcel de Rooy [Wed, 7 May 2014 12:21:33 +0000 (14:21 +0200)]
Bug 9612: (follow-up) restore elementSetName in Context.pm

Restore elementSetName to marcxml for DOM indexing in Zconn (Context.pm).
This prevents the need of rebuilding the index after restarting Zebra
server.

Removes the now incorrect reference to marcxml as 'superfluous' in four
dom config files.

Test plan:
[1] Do not yet apply this patch.
[2] Rebuild zebra index with the zebra config of commit
    036f2a50e11dab97ef8509f2f585c4cc407ea728.
[3] (Go back to master.) Restart your zebra server (no config change).
    You will have results without details.
    Apply this patch: you see details.
    Reset to master: no details again.
[4] Install new zebra config from master.
    Search again: you still see no details.
    Restart zebra server. Search: you see details.
    Apply this patch. Search: still details.
    Restart zebra server. Search: still details.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested in a non-package environment (manual dev install).
The package environment should work now too (results in step 4c might differ).
Progress on bug 12012 would be appropriate to sync all changes.
Tested the response of the SRU server too.

Signed-off-by: Marc Veron <veron@veron.ch>
I tested starting on a VM with Koha 3.15.00.019 installed.
Did git pull -> Koha 3.15.00.051
Result: No details in search results.
Applied patch.
Result: Search results display fine.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 7841: quell warnings in C4::Languages
Mark Tompsett [Thu, 15 May 2014 03:51:20 +0000 (23:51 -0400)]
Bug 7841: quell warnings in C4::Languages

This patch removes some sources of warning messages thrown by
C4::Languages, particular getTranslatedLanguages() when running
Koha's web installer.

TEST PLAN
---------
1) Apply first patch
2) prove -v t/db_dependent/Languages.t
   -- There will be uninitialized string messages, etc.
3) Apply second patch (this one)
4) prove -v t/db_dependent/Languages.t
   -- Only one carp message will remain.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Test pass, no warnings, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 7841: add a direct regression test
Galen Charlton [Mon, 19 May 2014 16:40:23 +0000 (16:40 +0000)]
Bug 7841: add a direct regression test

This patch adds a direct regression test for verifying that
no warnings are generated when getTranslatedLanguages() is called
without a defined current language, as might happen during
installation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 7841: add unit tests to detect no functional changes to getTranslatedLanguages()
Mark Tompsett [Thu, 15 May 2014 03:38:12 +0000 (23:38 -0400)]
Bug 7841: add unit tests to detect no functional changes to getTranslatedLanguages()

When called with undef, floody messages appear in the error
logs. Less floody messages appear when using 'en' as the
language.  This patch adds tests to verify that the behavior of
getTranslatedLanguages() doesn't change when a subsequent
patch updates it to not generate the warnings.

TEST PLAN
---------
1) apply the patch
2) prove -v t/db_dependent/Languages.t
   -- All the tests should pass, including the last two which
      a) check that when undef is used no language is marked
          as current.
      b) check that when 'en' is used there is a language marked
          as current.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Test pass, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12271: (follow-up) fix minor errors in Bootstrap theme
Galen Charlton [Mon, 19 May 2014 16:25:53 +0000 (16:25 +0000)]
Bug 12271: (follow-up) fix minor errors in Bootstrap theme

To test:

[1] Verify that prove -v xt/author/valid-templates.t passes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12271: (follow-up) teach valid-templates.t how to include specified templates
Galen Charlton [Mon, 19 May 2014 16:14:28 +0000 (16:14 +0000)]
Bug 12271: (follow-up) teach valid-templates.t how to include specified templates

Two of the template includes in the Bootstrap theme cannot be tested
all by themselves because they require that the template that includes
them define BLOCKs.  This patch ensures that they are excluded
from individual testing; they will get exercised sufficiently by being
including by all of the other Bootstrap templates.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12271: add Bootstrap templates to valid-templates.t tests
Fridolin Somers [Fri, 16 May 2014 09:25:19 +0000 (11:25 +0200)]
Bug 12271: add Bootstrap templates to valid-templates.t tests

valid-templates.t actually tests the templates and includes of only
the "prog" theme at opac and intranet.  It does not test the opac
templates and includes of bootstrap theme, nor ccsr.  This is critical
since this test is used for patch integrations in release maintenance.

This patch adds the test of bootstrap opac theme.
I did not manage to add the ccsr theme since it is not a real theme,
meaning it has no templates and not all includes.

Test by runnning perl xt/author/valid-templates.t and looking at the
logs.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Now there are 902 lines, bootstrap tested (1 error detected!)
No koha-qa errors

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12243: ensure that records with invalid ISBNs do not cause searches to fail
Kyle M Hall [Tue, 13 May 2014 11:20:39 +0000 (07:20 -0400)]
Bug 12243: ensure that records with invalid ISBNs do not cause searches to fail

Some types of invalid ISBNs, when run through C4::Koha::NormalizeISBN
can produce ISBN objects that contain invalid ISBNs. This can be
reproduced with an ISBN that has an invalid prefix, group code or
publisher code. An example ISBN would be "0788893777 (2 DVD 45th ed)".

When attempting to look up a record with such an ISBN, you will get an
error along the lines of: Can't call method "as_string" on an undefined
value

Instead of checking for the BAD_ISBN state, we should be checking for
the GOOD_ISBN state via the method is_valid.

Test Plan:
1) Edit a record, add the following ISBN to your record:
   0788893777 (2 DVD 45th ed)
2) When Koha redirects to the record, you should see the error message
   described
3) Apply this patch
4) Reload the page, you should now see your record

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12243: add regression test
Galen Charlton [Mon, 19 May 2014 15:37:34 +0000 (15:37 +0000)]
Bug 12243: add regression test

This patch adds a regression test for C4::Koha::NormalizeISBN
throwing an exception when trying to parse an invalid ISBN.

To test:

[1] Run prove -v t/Koha.t.  The last test should fail.
[2] Apply the main patch for this bug.
[3] Run prove -v t/Koha.t again.  This time, the test
    should pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12240 - update of Italian SQL files (non-MARC setup)
Koha SAB CINECA [Wed, 14 May 2014 10:39:42 +0000 (12:39 +0200)]
Bug 12240 - update of Italian SQL files (non-MARC setup)

To test:
- Apply this patch.
- Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you
  prefer)
- Install it-IT templates on command line
- Run the webinstaller using it-IT
- Follow the steps and choose all under 'necessari'
=> SUCCESS: no errors
=> Extra: see the italian installation and control the translation

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested doing it-IT install, all files selected, all load ok.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Ran the Italian web installer, no errors.
Checked some of the changed data, like the translated notices,
in the interface. No problems found.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11241: update the Italian MARC21 setup for 3.16
Koha SAB CINECA [Wed, 14 May 2014 15:57:50 +0000 (17:57 +0200)]
Bug 11241: update the Italian MARC21 setup for 3.16

To test:
- Apply this patch.
- Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you
  prefer)
- Install it-IT templates on command line
- Run the webinstaller using it-IT
- Follow the steps and choose all under 'opzionali'
=> SUCCESS: no errors
=> Sign this
=> Extra: see the cataloguing frameworks and check if you like the
   translation

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All files load ok, no errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Web installer loads all files without errors.
Verified 3 bibliographic frameworks and 5 authority types
appear to be translated correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12259 - fix version numbers in dependencies
Robin Sheat [Wed, 14 May 2014 22:39:26 +0000 (10:39 +1200)]
Bug 12259 - fix version numbers in dependencies

This sets the version numbers of the modules added by bug 12234 to more
sensible values (in this case, the versions included in Debian Squeeze.)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12251: fix error in sample_notices.sql (ru-RU)
Jonathan Druart [Wed, 14 May 2014 07:11:57 +0000 (09:11 +0200)]
Bug 12251: fix error in sample_notices.sql (ru-RU)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12251: fix error in sample_notices.sql (fr-FR)
Jonathan Druart [Wed, 14 May 2014 07:11:38 +0000 (09:11 +0200)]
Bug 12251: fix error in sample_notices.sql (fr-FR)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12251: fix error in sample_notices.sql (es-ES)
Tomas Cohen Arazi [Tue, 13 May 2014 21:50:27 +0000 (18:50 -0300)]
Bug 12251: fix error in sample_notices.sql (es-ES)

On bug 10845 some lines from sample_notices.sql were ommited when
adding the trailing parameter. This produces some errors when
installing using 'es-ES' sample data; and, in some conditions I
couldn't reproduce right now, occasional C4/NewsChannel.pm errors
due to mandatory message transport data incompletely loaded.

To reproduce:
- Make sure your setup has the es-ES translations installed and
  up-to-date (translation should raise lots of warnings)
- With a cleaned (DROP DATABASE ... ; CREATE DATABASE ...;) run the
  webinstaller
- Choose es-ES for the webinstaller.
- Follow the steps and choose all the sample data.
=> Errors related to sample_notices.sql and
   sample_notices_message_transports.sql show.

To fix:
- Apply this patch.
- Reset your DB (DROP DATABASE, CREATE DATABASE -- whatever method you prefer)
- Run the webinstaller using es-ES
- Follow the steps and choose all sample data.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12209 - Fix currency symbol for NOK
Magnus Enger [Thu, 15 May 2014 06:38:47 +0000 (08:38 +0200)]
Bug 12209 - Fix currency symbol for NOK

Dunno why, but the currency symbol for NOK was given as "$", when
it should be "kr".

To test:
- Empty the "currency" table in the DB:
    DELETE FROM currency;
- Load in the file changed by this patch:
    sudo koha-mysql <instance> < installer/data/mysql/nb-NO/2-Valgfritt/parameters.sql
    (if you are testing on a (gitified) package install)
- Check that "kr" is displayed on /cgi-bin/koha/admin/currency.pl
- Add a budget and a fund, and check that "kr" is displayed in the list
  of funds (currency symbols seem to be missing from the list of budgets)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
file loads ok, kr currency active, no errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12234 - build script version update
Robin Sheat [Tue, 13 May 2014 03:34:38 +0000 (15:34 +1200)]
Bug 12234 - build script version update

Make the script build 3.16 packages. To be updated to 3.17 once master
splits off again.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12234 - changelog updates from 3.14 series
Robin Sheat [Mon, 30 Dec 2013 02:04:26 +0000 (15:04 +1300)]
Bug 12234 - changelog updates from 3.14 series

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12234 - dependency changes to allow master to build
Robin Sheat [Mon, 12 May 2014 23:12:53 +0000 (11:12 +1200)]
Bug 12234 - dependency changes to allow master to build

A run of update-control, adding bash-completion as a build-time
dependency, allowing update-control to ignore anything that doesn't
have a package but isn't marked as "required" by Koha, added
dependencies that we don't use but is needed by something we do use.
All fairly mundane.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12206: fix HTML in other holdings list in staff search results page
Galen Charlton [Wed, 7 May 2014 17:43:25 +0000 (17:43 +0000)]
Bug 12206: fix HTML in other holdings list in staff search results page

To test:

[1] View, in the staff interface, a record with alternate holdings
    (as controlled by the AlternateHoldingsField system preference).
[2] Verify that the HTML list is closed correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 9724: ensure hourly loans show time due in SCO
Owen Leonard [Thu, 24 Apr 2014 19:21:59 +0000 (15:21 -0400)]
Bug 9724: ensure hourly loans show time due in SCO

Due dates in the self checkout module don't display the time items are
due, and thus items which are on hourly loans don't display an accurate
due date and time. This patch corrects this by adding the "as_due_date
=> 1" parameter added by Bug 9723.

To test, apply the patch for Bug 9723 if necessary. Enable an hourly
loan period for an itemtype in your collection. Log into the
self-checkout system and check out an item which circulates by the hour.
The due date and time should be displayed correctly.

Check out an item which does not circulate hourly. The due date should
be displayed as a date only.

Test in both prog and Bootstrap themes.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12065: use encode_qp consistently when sending basket/shelf
Marcel de Rooy [Thu, 10 Apr 2014 12:40:01 +0000 (14:40 +0200)]
Bug 12065: use encode_qp consistently when sending basket/shelf

QP-encode both mail header and mail body when sending baskets or
shelves.  There is no need to Encode qp-encoded strings.

Note that this does not solve all possible encoding problems in the mail
sent. This is related to decoding CGI parameters and use of TT. That
problem is addressed in bug 11944.

Test plan:
Verify if sending a basket from opac and staff still works.
Check if sending a shelf (list) from opac and staff still functions as
expected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cart/List sent form opac/staff works
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12214: (follow-up) Clean up reports-toolbar.inc, show Edit link when SQL has...
Kyle M Hall [Fri, 9 May 2014 13:35:03 +0000 (09:35 -0400)]
Bug 12214: (follow-up) Clean up reports-toolbar.inc, show Edit link when SQL has errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query()
Galen Charlton [Thu, 8 May 2014 16:12:32 +0000 (16:12 +0000)]
Bug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query()

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12214: display SQL errors in reports to users
Pasi Kallinen [Thu, 8 May 2014 07:11:29 +0000 (10:11 +0300)]
Bug 12214: display SQL errors in reports to users

When a user runs a report containing an SQL error, no
error is shown to the user.  This patch fixes this.

To test:
1) Run a report with known good SQL.
2) No error is shown.
3) Run a report with bad SQL (eg. a typo in field name)
4) No error is shown.
5) Apply patch
6) Repeat 1-4. For the bad SQL report, the database error
   should be shown.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12214: add regression test for reporting error when running report with SQL error
Galen Charlton [Thu, 8 May 2014 16:09:07 +0000 (16:09 +0000)]
Bug 12214: add regression test for reporting error when running report with SQL error

To test:

[1] Run prove -v t/db_dependent/Reports_Guided.t. Last test should
    fail.
[2] Apply the main patch.
[3] Run step 1 again.  This time, all tests should pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge()
Galen Charlton [Thu, 8 May 2014 15:13:15 +0000 (15:13 +0000)]
Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge()

This patch consolidates the code for constructing the parameters for
GetBorrowersToExpunge() into a subroutine.  As a side-effect, this
fixes a regression introduced by the main patch where no patrons would
be deleted when filtering by expiration date.

To test:

[1] Follow the test plan in the main patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11975: improve the batch patron deletion code
Jonathan Druart [Thu, 20 Mar 2014 15:41:29 +0000 (16:41 +0100)]
Bug 11975: improve the batch patron deletion code

This patch tries to improve the code for the cleanborrowers.pl tool.

- use KohaDates plugin and Koha::DateUtils for date management,
  removing a dependency on C4::Dates
- replace variables step1, step2 and step3 with step
- add a JavaScript check if no action if checked

Test plan:
- Backup your DB
- Play with the Patron deletion/anonymisation tool and try to find
  something inconsistent.
If you don't find something different, it works!

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t
Julian Maurice [Wed, 7 May 2014 08:40:58 +0000 (10:40 +0200)]
Bug 11843: (follow-up) fix unit test in t/db_dependent/Serials.t

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11843: prevent manual history from being overwritten if subscription switched...
Julian Maurice [Mon, 28 Apr 2014 09:50:04 +0000 (11:50 +0200)]
Bug 11843: prevent manual history from being overwritten if subscription switched to automatic history

Test plan:
1/ Create a new subscription, with manual history enabled
2/ Edit history by clicking on "Edit history" under Planning tab (add
   some text)
3/ Receive some serials, see that received and missing issues are not
   updated in Summary tab
4/ Edit subscription and disable manual history
5/ Receive some serials, see that received and missing issues are
   updated, but your notes have been kept.
6/ Edit serials and change status from/to missing or not available.
   Check that missing issues are updated correctly.
7/ Edit serials and change status from/to arrived. Check that received
   issues are updated correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 9723: display time due for hourly loans in the public catalog
Owen Leonard [Thu, 24 Apr 2014 16:41:29 +0000 (12:41 -0400)]
Bug 9723: display time due for hourly loans in the public catalog

Due dates in the OPAC don't display the time items are due, and thus
items which are on hourly loans don't display an accurate due date and
time. This patch corrects this by adding (and using) a new "as_due_date"
option to the KohaDates plugin made possible by Bug 11148.

Thanks to Galen for providing the changes to KohaDates.pm.

To test, enable an hourly loan period for an itemtype in your
collection. View the display of date due on the following pages:

- Patron details (opac-user.pl) - Log into the OPAC as a user who has
  something checked out which circulates by the hour.

- Bibliographic details (opac-detail.pl) - View the details for an item
  which is circulates by the hour and is checked out.

- Course reserves details (opac-course-details.pl) - View the contents
  of a course reserve, one of which should be an item which circulates
  by the hour and is checked out.

Due dates for hourly items should show both date and time and be
formatted correctly. Due dates for non-hourly loans should show only the
date. Test in both prog and Bootstrap themes.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 4068: (follow-up) use URI::Escape
Galen Charlton [Thu, 8 May 2014 16:36:10 +0000 (16:36 +0000)]
Bug 4068: (follow-up) use URI::Escape

This allows for suggestions that contain characters such
as the ampersand to have their status changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 4068: ensure accepting a suggestion does not hide the 'pending' tab
Kyle M Hall [Tue, 6 May 2014 12:49:15 +0000 (08:49 -0400)]
Bug 4068: ensure accepting a suggestion does not hide the 'pending' tab

Prior to this patch:

1) Moving a suggestion from status 'pending' to 'accepted
   - After saving only tab 'accepted' is shown.
2) Moving a suggestion back from 'accepted' to 'pending'
   - After saving only tab 'pending' is shown.

Test Plan:
1) Verify the bug by taking the actions listed above
2) Apply this patch
3) Verify the bug no longer exists

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
It is not very elegant but I have nothing else to suggest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12195 - Remove duplicated plugin jquery.dataTables.min.js
Owen Leonard [Tue, 6 May 2014 15:02:48 +0000 (11:02 -0400)]
Bug 12195 - Remove duplicated plugin jquery.dataTables.min.js

All templates in the staff client now load the DataTables jquery plugin
through a single include file, datatables.inc, which points to a copy of
the plugin in intranet-tmpl/lib/jquery/plugins. This patch removes the
unused copy of the plugin found in intranet-tmpl/prog/en/lib/jquery/plugins.

To test, search the Koha source for references to
jquery.dataTables.min.js. There should be no files which point to the
redundant file.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12196 - Remove unused jquery.qtip.js plugin
Owen Leonard [Tue, 6 May 2014 15:20:58 +0000 (11:20 -0400)]
Bug 12196 - Remove unused jquery.qtip.js plugin

The qTip jQuery plugin is not longer used anywhere in Koha. This patch
removes it.

To test, apply the patch and search the Koha source for references to
the plugin. There should be none.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12198: (follow-up) fix warning when opening guarantor search form
Galen Charlton [Tue, 6 May 2014 20:08:17 +0000 (20:08 +0000)]
Bug 12198: (follow-up) fix warning when opening guarantor search form

To test:

[1] Verify that act of running a guarantor search does not result in
    the following warning message in the Apache log:

"guarantor_search.pl: Use of uninitialized value $member in string ne
 at guarantor_search.pl line 63"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12198: (code cleanup) remove unused variables, tidy code
Kyle M Hall [Tue, 6 May 2014 16:36:30 +0000 (12:36 -0400)]
Bug 12198: (code cleanup) remove unused variables, tidy code

To test:

[1] Perform searches for guarantors and verify that there
    are no regressions.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search
Kyle M Hall [Tue, 6 May 2014 16:26:49 +0000 (12:26 -0400)]
Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search

The script members/guarantor_search.pl made the following call:
my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'});

Not only does this call always fail because borrowerid is not a valid
key, but the results are never even used in the template!

Test Plan:
1) Apply this patch
2) Verify the gurantor search works as before,
   No changes in behavior should be noted

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 9048 - fix quote editor under Plack
Robin Sheat [Wed, 30 Apr 2014 03:33:44 +0000 (15:33 +1200)]
Bug 9048 - fix quote editor under Plack

The ajax responder for the quote editor was using the wrong error codes.
These have been fixed. Also, a small fixup to get rid of some annoying
warnings.

To test:
* Under plack,
* Add/edit/delete a quote.
* Make sure that things don't crash.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12212: fix error that prevented sysprefs.sql from loading
Kyle M Hall [Wed, 7 May 2014 16:04:48 +0000 (12:04 -0400)]
Bug 12212: fix error that prevented sysprefs.sql from loading

The line for inserting AggressiveMatchOnISBN didn't have the right
number of columns.

Test Plan:
1) Attempt to run the web installer OR try to import the sysprefs.sql
into your db
2) Apply this patch
3) Try again, no errors should be reported this time

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 11433: (code cleanup) remove unused 'attachbasket' op value in basket.pl
Mathieu Saby [Fri, 20 Dec 2013 22:21:32 +0000 (23:21 +0100)]
Bug 11433: (code cleanup) remove unused 'attachbasket' op value in basket.pl

This patch cleans code in basket.pl

In basket.pl, some code is supposed to be executed if
$op eq 'attachbasket'. But it is never the case
(grep attachbasket * -r), so this condition can be removed.

No functional change expected.

Regression test only :
* Make a complete acquisition process, from the creation of a basket
 to the closure of a basketgroup, and check everything is OK
* On a basket page, try to change the basketgroup it belongs to, and
  check everything is OK
* On a basketgroup page, try to edit the content of a basketgroup (put
  a new basket in it, change the deliverybranch...), and check everything
  is OK
* On a basketgroup page, try to reopen a closed basketgroup, and close an
  open basketgroup, and check everything is OK

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 8375: (follow-up) final adjustment to t/Creators.t
Galen Charlton [Wed, 7 May 2014 01:00:34 +0000 (01:00 +0000)]
Bug 8375: (follow-up) final adjustment to t/Creators.t

This patch adjusts the test so that it can pass successfully
without a valid context (in which case C4::Creators::PDF defaults
to the built-in fonts) or with one (in which case it uses the
TrueType fonts).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 8375: (follow-up) adjust another test case for change in fonts
Galen Charlton [Tue, 6 May 2014 21:24:40 +0000 (21:24 +0000)]
Bug 8375: (follow-up) adjust another test case for change in fonts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 8375: (follow-up) adjust StrWidth to account for TTF fonts
Galen Charlton [Tue, 6 May 2014 18:52:12 +0000 (18:52 +0000)]
Bug 8375: (follow-up) adjust StrWidth to account for TTF fonts

This patch fixes an issue caught by the test case where StrWidth()
based its calculations on the internal Adobe font rather than a
TrueType font in use.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12163 - fix adding new quotes
Robin Sheat [Wed, 30 Apr 2014 04:28:21 +0000 (16:28 +1200)]
Bug 12163 - fix adding new quotes

Something changed somewhere (maybe a new jQuery or datatables version)
and the javascript that redrew the table row after a new quote was saved
stopped working. This fixes the call to the datatables function so that
it matches the API.

Note that although the new quote didn't appear to be added, reloading
the page shows that it had been.

To test:
* Go and add a quote.
* Note that when you press enter after finishing the quote, the line
  stops being an editor, and becomes just a display, like it should.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoBug 12161: fix regression on serials receiving
Matthias Meusburger [Tue, 29 Apr 2014 12:22:48 +0000 (14:22 +0200)]
Bug 12161: fix regression on serials receiving

Serial receiving was broken when "create an item record when receiving
this serial" is used for the subscription.  This bug was introduced by
the patch for bug 12138.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>