]> git.koha-community.org Git - koha.git/log
koha.git
6 years agoBug 13692: series link is taking you to just 800a instead of whole 800
Owen Leonard [Fri, 3 Aug 2018 15:13:57 +0000 (15:13 +0000)]
Bug 13692: series link is taking you to just 800a instead of whole 800

This patch modifies the OPAC and staff client's XSL template for the
detail page so that series links based on a traced 490 tag use both
author and series title from the 800 tag.

To test you should have multiple titles in the same series with matching
490 and 800 tags in each record. Apply the patch and restart Plack if
necessary.

View the detail page for one of the series' titles. The "Series:" link
should link to a search which uses both series title and author.
Clicking the link should return the correct results.

Test both the OPAC and staff client.

Signed-off-by: John Sterbenz <jsterben@umich.edu>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21347: Escaped fields that should be in addorderiso2709
Chris Cormack [Fri, 14 Sep 2018 22:48:23 +0000 (22:48 +0000)]
Bug 21347: Escaped fields that should be in addorderiso2709

Test plan
1/ Stage a MARC file (if you have none staged)
2/ Create a basket in aquisitions
3/ Add an order via staged file
4/ Look at the item information tab, notice there is escaped html
5/ Apply patch
6/ Refresh page, notice it is fixed

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20217: Compiled CSS
Nick Clemens [Sun, 16 Sep 2018 00:28:30 +0000 (00:28 +0000)]
Bug 20217: Compiled CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20217: Make header's catalog search menu into a split button
Owen Leonard [Fri, 10 Aug 2018 13:37:49 +0000 (13:37 +0000)]
Bug 20217: Make header's catalog search menu into a split button

This patch modifies the markup for the staff client header's catalog
search menu so that it mimics the behavior of a Bootstrap split button
(As seen on the cataloging home page's 'New from Z39.50' button).

To test, apply the patch, run 'yarn build' to regenerate the staff
client's CSS, and clear your browser cache.

- View any page in the staff client.
- Hover your mouse over the "Search" link in the header. It should
  trigger a hover affect on the adjacent menu link.
- Clicking the "Search" link should take you directly to the advanced
  search page.
- Clicking the adjacent menu link should display a menu containing links
  to advanced search and item search.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: (follow-up) Remove local help files + edit help feature
Jonathan Druart [Sun, 16 Sep 2018 17:25:37 +0000 (10:25 -0700)]
Bug 19817: (follow-up) Remove local help files + edit help feature

I have no idea what happened but RM did not rebase that one correctly
before pushing it ;)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21305: Update two-column templates with Bootstrap grid: Patron clubs
Owen Leonard [Wed, 2 May 2018 16:08:29 +0000 (16:08 +0000)]
Bug 21305: Update two-column templates with Bootstrap grid: Patron clubs

This patch modifies patron clubs templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Patron clubs
   - View club enrollments

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21306: Update two-column templates with Bootstrap grid: Tags
Owen Leonard [Mon, 7 May 2018 14:45:25 +0000 (14:45 +0000)]
Bug 21306: Update two-column templates with Bootstrap grid: Tags

This patch modifies the tags management templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Tags
   - View list of tags
   - Click tag to view the list of titles tagged with that term

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21356: Add Missing space in parcel.tt
Caroline Cyr La Rose [Sat, 15 Sep 2018 20:10:22 +0000 (16:10 -0400)]
Bug 21356: Add Missing space in parcel.tt

This patch adds a space between the user's name and 'On:'
in parcel.tt.

To test:

1) Go to Acquisitions
2) Search for a vendor
3) Create a new basket
4) Add an order to the basket
5) Close the basket
6) Receive the order
7) In the page title 'Receipt summary' notice there is no space
between the 'Received by' user name and 'On:'
8) Apply the patch
9) Refresh the page, there should now be a space

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21262: Do not format numbers for editing if too big
Nick Clemens [Thu, 23 Aug 2018 14:44:31 +0000 (14:44 +0000)]
Bug 21262: Do not format numbers for editing if too big

This patch copies the code from bug 15770 to the format_for_editing
sub.

It also corrects schema issue, listing the purpose for two acq columns
instead of claing unused

To test:
1 - Edit a fund
2 - Set warning at amount to: 100000000000000
3 - Save budget
4 - Try to edit - internal server error
5 - Apply patch
6 - Should be able to edit budget
7 - Number should appear unformatted

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2 quick notes:
1. Code must be moved to a subroutine if reused later
2. It would have prefered to have the comment of the 2 DB columns on a separate patch
(even separate bug report). As it's minor and that the patch will certainly backported
I will not block it.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21360: Prevent IssueSlip.t to fail when run at 23:59
Jonathan Druart [Sun, 16 Sep 2018 16:49:46 +0000 (09:49 -0700)]
Bug 21360: Prevent IssueSlip.t to fail when run at 23:59

Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if
launched after 23:00) but we should have tested with 23:59, not 23:50...

koha_1       |     # Looks like you planned 3 tests but ran 2.
koha_1       |
koha_1       | #   Failed test 'Issue slip'
koha_1       | #   at t/db_dependent/Members/IssueSlip.t line 294.
koha_1       | Label not found for "last SKIP" at /usr/share/perl5/Test/More.pm line 1370.
koha_1       | # Looks like your test exited with 255 just after 1.
koha_1       | [23:59:10] t/db_dependent/Members/IssueSlip.t
koha_1       | Dubious, test returned 255 (wstat 65280, 0xff00)
koha_1       | Failed 3/3 subtests

Test plan:
0/ Don't apply this patch
1/ sudo date -s "2018-09-15 23:59:00";prove t/db_dependent/Members/IssueSlip.t
=> You should get the error
2/ Apply this patch and repeat 1.
=> Tests should pass now!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20777: DBRev 18.06.00.030
Nick Clemens [Sat, 15 Sep 2018 21:52:47 +0000 (21:52 +0000)]
Bug 20777: DBRev 18.06.00.030

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint
Tomas Cohen Arazi [Fri, 14 Sep 2018 16:10:50 +0000 (09:10 -0700)]
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20777: DBIC update
Tomas Cohen Arazi [Thu, 17 May 2018 13:55:26 +0000 (10:55 -0300)]
Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20777: Remove unused accountlines.dispute field
Tomas Cohen Arazi [Thu, 17 May 2018 13:53:55 +0000 (10:53 -0300)]
Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21288: DBRev 18.06.00.029
Nick Clemens [Sat, 15 Sep 2018 21:44:05 +0000 (21:44 +0000)]
Bug 21288: DBRev 18.06.00.029

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21288: Slowness in acquisition caused by GetInvoices
Pasi Kallinen [Thu, 30 Aug 2018 08:29:54 +0000 (11:29 +0300)]
Bug 21288: Slowness in acquisition caused by GetInvoices

The SQL query done by GetInvoices is quite slow on our production server,
taking about a minute.

In the query, there's this join:

  LEFT JOIN subscription ON biblio.biblionumber = subscription.biblionumber

but there's no index on subscription.biblionumber. Adding the index speeds
up the query so it only takes up about 3 seconds.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20765: Fix search for items by acqdate in label batch
Fridolin Somers [Mon, 14 May 2018 14:18:29 +0000 (16:18 +0200)]
Bug 20765: Fix search for items by acqdate in label batch

In Tools >  Label creator, when creating a batch you can add items using a search.

This search has filters on acquisition date.
Actually those filters does not work.
The create a search using CCL syntaxe to query Zebra search engine.

The cause is that operator "ge" or "le" must be before "st-date-normalized" in CCL query.
Looks like it is because of "st-date-normalized" uses "r=o" in ccl.properties.

Test plan :
1) Check in advance search you have indexed acquisition date
2) Go to Tools > Label creator
3) Click on New > Label batch
4) Click on Add item(s)
5) Enter a relevent date in "Added on or after date" and in "Added on or before date"
6) Click on "Search"
=> SUCCESS: You get results
7) Apply the patch
8) Retry the 'Add item(s)' step
=> SUCCESS: Patch doesn't change behaviour for old Zebra
9) Get rid of the patch on your working branch
10) Use the latest Zebra:
- /etc/apt/sources.list.d/indexdata.list:
deb http://ftp.indexdata.dk/debian jessie main
- Add the repo key:
  $ wget http://ftp.indexdata.dk/debian/indexdata.asc -O- | sudo apt-key add -
- Upgrade:
  $ sudo apt update; sudo apt dist-upgrade
  $ sudo koha-rebuild-zebra -f -a -b -v kohadev
  $ restart_all
11) Retry the 'Add item(s)' step
=> FAIL: No results!
9) Apply the patch, retry
=> SUCCESS: Search results!
- Sign off :-D

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
It doesn't break with 2.0.59-1 (stretch/jessie), and fixes the problem
for 2.1.X.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21355: Prevent GetDailyQuote.t to fail when run after 23:00
Jonathan Druart [Sat, 15 Sep 2018 18:24:32 +0000 (11:24 -0700)]
Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00

Tests will fail (Jenkins run #554) if run after 23:00

 #   Failed test 'Id is correct'
 #   at t/db_dependent/Koha/GetDailyQuote.t line 72.
 #          got: 6
 #     expected: 8

 #   Failed test 'Timestamp 2018-09-15 00:44:46 is correct'
 #   at t/db_dependent/Koha/GetDailyQuote.t line 74.
 #          got: '2018-09-14 23:44:46'
 #     expected: '2018-09-15 00:44:46'
 # Looks like you failed 2 tests of 12.
 [23:44:46] t/db_dependent/Koha/GetDailyQuote.t
 Dubious, test returned 2 (wstat 512, 0x200)

Adding only 1 second will hugely reduce the risk of failure here.

It also updates a useless test (column 'quote' does not exist)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tested:
- Run:
  $ sudo date -s 2018-09-15T23:10:00
  $ kshell
 k$ prove t/db_dependent/Koha/GetDailyQuote.t
=> FAIL: Tests fail as patch author mentions
- Apply the patch
 k$ prove t/db_dependent/Koha/GetDailyQuote.t
=> SUCCESS: Tests pass!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21233: (follow-up) POD fix
Tomas Cohen Arazi [Fri, 14 Sep 2018 23:23:58 +0000 (16:23 -0700)]
Bug 21233: (follow-up) POD fix

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21334: Add bibliographic content type definitions
Tomas Cohen Arazi [Tue, 11 Sep 2018 17:48:15 +0000 (10:48 -0700)]
Bug 21334: Add bibliographic content type definitions

This patch adds the following content type definitions, to be used by
endpoint authors implementing MARC-related endpoints:

--------------------------------------
| Content-type             | Alias   |
|--------------------------|---------|
| application/marcxml+xml  | marcxml |
| application/marc-in-json | mij     |
| application/marc         | marc    |
--------------------------------------

Code using this aliases will use them like this:
- Suppose you want to output data in MARCXML format:

my $record = cool_method_that_returns_MARC_RECORD();
return $c->render( status => 200, format => 'marcxml', text => $record->as_xml_record );

Note: 'text' by defaults encodes output as UTF-8. If the encoding is not
UTF-8 you should encode the data on your own.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/V1.t
=> SUCCESS: Test pass!
- Sign off :-D

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21334: Unit tests
Tomas Cohen Arazi [Tue, 11 Sep 2018 17:43:32 +0000 (10:43 -0700)]
Bug 21334: Unit tests

This patch adds unit tests for the new content types being added.
It also adds tests for the 'json' overloading that already takes place
in V1.pm.

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19179: (QA follow-up) Replace second E-mail
Marcel de Rooy [Fri, 14 Sep 2018 09:53:37 +0000 (11:53 +0200)]
Bug 19179: (QA follow-up) Replace second E-mail

Better write here exactly what we need to type in the pref text box.
Since E-mail will not work and Email will :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19179: Email option for SMSSendDriver is not documented
Charlotte Cordwell [Fri, 7 Sep 2018 03:35:36 +0000 (03:35 +0000)]
Bug 19179: Email option for SMSSendDriver is not documented

'Email' is not documented as a valid setting.

1) Apply patch.
2) Go to Administration --> search SMSSendDriver
3) Check if SMSSendDriver has this message is at the end of the box:
   "If you would prefer to receive SMS via E-mail set SMSSendDriver to Email"

Signed-off-by: Michal Denar <black23@gmail.coml>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21293: Remove another misplaced html filter on housebound.tt
Jonathan Druart [Fri, 31 Aug 2018 16:51:18 +0000 (13:51 -0300)]
Bug 21293: Remove another misplaced html filter on housebound.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21293: Display of housebound delivery information broken by Bug 13618
Owen Leonard [Thu, 30 Aug 2018 16:43:09 +0000 (16:43 +0000)]
Bug 21293: Display of housebound delivery information broken by Bug 13618

This patch corrects the patron housebound details template. A stray
"html" filter broke display of delivery information.

To test, apply the patch and enable the HouseboundModule system
preference.

 - Open a patron record and select the "Housebound" tab in the left-hand
   navigation menu.
 - Click "Add a new deliver" and save some delivery details.
 - Upon saving you should be directed back to the housebound details
   page. All the details of the delivery you saved should appear
   correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21233: (QA follow-up) It is not only trailing whitespace characters
Tomas Cohen Arazi [Fri, 14 Sep 2018 19:27:36 +0000 (12:27 -0700)]
Bug 21233: (QA follow-up) It is not only trailing whitespace characters

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21233: (QA follow-up) We do not like the plural form of whitespace
Marcel de Rooy [Fri, 24 Aug 2018 09:06:14 +0000 (11:06 +0200)]
Bug 21233: (QA follow-up) We do not like the plural form of whitespace

The word "whitespace" is usually uncountable.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21233: Unit tests
Tomas Cohen Arazi [Thu, 16 Aug 2018 09:54:53 +0000 (06:54 -0300)]
Bug 21233: Unit tests

This patch adds tests for the required password-related exceptions. The
tests verify the stringified version of the exceptions.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> FAIL: Exceptions not implemented, tests fail!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21233: Add Koha::Exceptions::Password
Tomas Cohen Arazi [Thu, 16 Aug 2018 09:56:30 +0000 (06:56 -0300)]
Bug 21233: Add Koha::Exceptions::Password

This patch adds some exceptions that we need. To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off! :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: DBRev 18.06.028
Nick Clemens [Fri, 14 Sep 2018 17:46:58 +0000 (17:46 +0000)]
Bug 19469: DBRev 18.06.028

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: (QA follow-up) Disable priority pulldowns when using split holds queue
Kyle M Hall [Fri, 7 Sep 2018 18:28:31 +0000 (14:28 -0400)]
Bug 19469: (QA follow-up) Disable priority pulldowns when using split holds queue

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: (RM follow-up) Add filters and fix variable name
Nick Clemens [Fri, 7 Sep 2018 15:02:25 +0000 (15:02 +0000)]
Bug 19469: (RM follow-up) Add filters and fix variable name

https://bugs.koha-community.org/show_bug.cgi?id=19469

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: (QA follow-up) When altering priorities, use the existing priority numbers...
Kyle M Hall [Fri, 27 Apr 2018 09:21:28 +0000 (09:21 +0000)]
Bug 19469: (QA follow-up) When altering priorities, use the existing priority numbers of the given table

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: (QA follow-up) Use hold item's itemtype if available, fix priority changing
Kyle M Hall [Tue, 17 Apr 2018 14:29:27 +0000 (14:29 +0000)]
Bug 19469: (QA follow-up) Use hold item's itemtype if available, fix priority changing

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: Remove use of Dumper on request.tt
Kyle M Hall [Wed, 7 Mar 2018 12:05:11 +0000 (07:05 -0500)]
Bug 19469: Remove use of Dumper on request.tt

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: (follow-up) Use patron-title.inc as proposed by bug 18403
Tomas Cohen Arazi [Mon, 5 Mar 2018 19:10:25 +0000 (16:10 -0300)]
Bug 19469: (follow-up) Use patron-title.inc as proposed by bug 18403

This patch makes the new template include file use the patron-title.inc
include to render the patron name.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: Add ability to split view of holds view on record by pickup library and...
Kyle M Hall [Sat, 30 Sep 2017 12:02:57 +0000 (08:02 -0400)]
Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype.
To make it easier to understand which holds will be trapped in a given circumstance,
it would be nice if we could optionally group holds by pickup library and/or itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold fieldset

Sponsored-by: Stockholm University Library
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19469: Clean up template whitespace
Kyle M Hall [Sat, 30 Sep 2017 12:03:30 +0000 (08:03 -0400)]
Bug 19469: Clean up template whitespace

Sponsored-by: Stockholm University Library
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed QA test tool
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21127: Remove jqTransform jQuery plugin from the OPAC
Owen Leonard [Fri, 27 Jul 2018 12:43:50 +0000 (12:43 +0000)]
Bug 21127: Remove jqTransform jQuery plugin from the OPAC

This patch removes the jqTransform jQuery plugin from the OPAC. It was
added for the CCSR theme, which no longer exists.

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c7c2e9efbde273f2b77786316b7502a8847072bd

There will be no visible changes to the OPAC after applying the patch.
Search the Koha codebase for references to jqTransform and confirm that
none exist.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21248: Fix COinS carp in MARC details page on unknown record
Pasi Kallinen [Mon, 20 Aug 2018 04:30:45 +0000 (07:30 +0300)]
Bug 21248: Fix COinS carp in MARC details page on unknown record

Looking up a nonexistent record in the MARC details -page causes
the COinS to carp. The fix is trivial, just move the COinS call
couple lines, after the record existence check.

TEST PLAN
---------
1) reset_all for kohadevbox
2) log in to staff client - admin/admin
3) search catalogue for green
4) tweak the top URL to have a bad biblionumber (eg. 9999)
5) cat /var/log/koha/kohadev/plack-err.log
   -- floody! with errors.
6) echo | sudo tee /var/log/koha/kohadev/plack-err.log
7) restart_all
8) repeat steps 2 through 5.
   -- just nice starting messages, not floody.
9) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl
Marcel de Rooy [Fri, 7 Sep 2018 07:50:40 +0000 (09:50 +0200)]
Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl

Script offline_circ/download.pl does not use the return values of
checkauth. So should not assign them to bad chosen variables that do
not correspond with checkauth but with get_template_and_user.

Test plan:
Look for $template, $loggedinuser, $cookie, $flags in the code.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 13779: sessionID declared twice in C4::Auth::checkauth()
David Cook [Thu, 19 Jul 2018 06:57:22 +0000 (16:57 +1000)]
Bug 13779: sessionID declared twice in C4::Auth::checkauth()

The bug is that $sessionID is declared twice in C4::Auth::checkauth().
At the moment, this doesn't actually create a problem, because no
one seems to be using the $sessionID which is returned by checkauth(),
except in the case of opac/external/overdrive/auth.pl which skips
the second declartion as it doesn't require auth.

This patch removes the redefining of the $sessionID variable.

In terms of testing, try logging in with a username and password
and see if it works. The only risk this patch would pose is breaking
auth I would think, since nothing is actually using the return value
from checkauth() for $sessionID.

NOTE:
It was initially defined near the top of the function (~line 791).
I believe the scoping would mean the correct version of $sessionID
would be used in the latter lines for the unset'ing.
I have skimmed code to see if the sessionID return value is used.
I did not test overdrive, as I do not know how. However, this is
the only area, I think this could possibly break. This change makes
sense to me.

QA: Please test overdrive.
opac/external/overdrive/auth.pl only checks if the value is set, so
   this patch might fix/break something there?
opac/svc/overdrive same kind of check.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This is a (tiny) code improvement. Now we consistently return the session
id that is also stored in the returned cookie. (Which can be an 'anon'
session.)
Fact is that Koha almost everywhere ignores the returned session id and
sometimes gets the session from the cookie (obviously). The session id is
also passed to the template by get_template_and_user but never used in
templates.
As mentioned, the two overdrive scripts are the exception. But since both
test on both $user && $sessionID, they will not choke on an anynonomous
session id without userid. So theoretically fine, but not tested.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21324: Fix column defs and spans
Nick Clemens [Fri, 7 Sep 2018 11:33:44 +0000 (11:33 +0000)]
Bug 21324: Fix column defs and spans

TO test:
1 - Open a bastket in acquisitions
2 - Order some items
3 - Close the basket
4 - Receive some items
5 - Note the columns are out of alingment on parcel.pl
6 - Note a JS error breaking datatable on 'Already received'
7 - Apply patch
8 - Things should be better

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21285: Add missing select2x2.png file
Tomas Cohen Arazi [Wed, 29 Aug 2018 16:46:39 +0000 (13:46 -0300)]
Bug 21285: Add missing select2x2.png file

This file is part of the Select2 jquery plugin, but wasn't added when
the use of the plugin was introduced in Koha.

To test:
- On a high DPI screen (retina mac?) on Chrome or Safari
- Edit an item
=> FAIL: dropdowns using Select2 (like 'Shelving location') don't display the icons (down arrow and cross) and a default value is wrongly selected
=> FAIL: the inspector says the requested select2x2.png file returned a 400 error.
- Apply this patch
- Reload the edit page
=> SUCCESS: Things display correctly! Dropdowns without selected values
by default!
=> SUCCESS: No errors fetching select2x2.png
- Sign off :-D

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21116: Add API routes through plugins
Tomas Cohen Arazi [Mon, 23 Jul 2018 14:14:47 +0000 (11:14 -0300)]
Bug 21116: Add API routes through plugins

This patch adds plugins the capability of injecting new routes on the
API.

The plugins should provide the following methods to be considered valid API-generating plugins:

- 'api_routes': returning the 'path' component of the OpenAPI specification corresponding to the routes served by the plugin
- 'api_namespace': it should return a namespace to be used for grouping the endpoints provided by the plugin

otherwise, they will be just skipped.

All plugin-generated routes will be added the 'contrib' namespace, and
will end up placed inside /contrib/<namespace>, where <namespace> is what the 'api_namespace' returns.

A sample endpoint will be added to the Kitchen Sink plugin, and tests
are being written.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> SUCCESS: Tests pass!
- Install the (latest) KitchenSink plugin
- Point your browser to the API like this:
  http://koha-intra.myDNSname.org:8081/api/v1/.html
=> SUCCESS: The /contrib/kitchensink/patrons/:patron_id/bother endpoint
implemented by the plugin has been merged!
- Sign off! :-D

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21116: Unit tests
Tomas Cohen Arazi [Mon, 27 Aug 2018 19:24:09 +0000 (16:24 -0300)]
Bug 21116: Unit tests

This path implements unit tests for the route-from-plugin development.
It adds the required methods to the Koha::Plugin::Test plugin
distributed along with the tests. A second plugin implementing invalid
OpenAPI specs is added (Koha::Plugin::BadAPIRoute).

Edit: I made terminology changes to make it less rude.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: (QA follow-up) Use Koha.Preference template plugin to fetch the pref's...
Jonathan Druart [Mon, 10 Sep 2018 20:45:32 +0000 (13:45 -0700)]
Bug 7534: (QA follow-up) Use Koha.Preference template plugin to fetch the pref's value

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19550: (QA follow-up) Add missing [% USE %]
Julian Maurice [Fri, 7 Sep 2018 15:06:38 +0000 (17:06 +0200)]
Bug 19550: (QA follow-up) Add missing [% USE %]

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19550: (RM follow-up) Add filters
Nick Clemens [Thu, 6 Sep 2018 14:34:03 +0000 (14:34 +0000)]
Bug 19550: (RM follow-up) Add filters

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19550: Add links to related authorities for UNIMARC
Julian Maurice [Tue, 31 Oct 2017 12:25:17 +0000 (12:25 +0000)]
Bug 19550: Add links to related authorities for UNIMARC

Links exist in search results for MARC21 but not for UNIMARC.
This patch fixes that.

Test plan:
1. Create an authority with a field 550 that links to another authority
   e.g. 550 $a Foo $9 42
2. Reindex this authority
3. Search for this authority
4. See that you now have a link "Foo" to authorities/detail.pl?authid=42
   in the summary

Signed-off-by: delaye <stephane.delaye@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21235: DBRev 18.06.00.027
Nick Clemens [Fri, 7 Sep 2018 15:53:24 +0000 (15:53 +0000)]
Bug 21235: DBRev 18.06.00.027

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21235: (QA follow-up) Remove table services_throttle
Martin Renvoize [Fri, 7 Sep 2018 15:28:22 +0000 (16:28 +0100)]
Bug 21235: (QA follow-up) Remove table services_throttle

Add the missing db update to nuke the services throttle from high orbit

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21235: Remove table services_throttle
Jonathan Druart [Wed, 15 Aug 2018 15:01:56 +0000 (12:01 -0300)]
Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 21319: Remove highlight and tooltip on Koha Team version
Owen Leonard [Thu, 6 Sep 2018 11:56:41 +0000 (11:56 +0000)]
Bug 21319: Remove highlight and tooltip on Koha Team version

This patch modifies the about page to remove a <span> on the Koha
version number which explained the version numbering change.

To test, apply the patch and view the "Koha team" tab on the about page.
The "Koha 18.05 release team" header should not have the number
highlighted.

Signed-off-by: pierre-marc <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20776: Add Selenium::Remote::Driver to the dependency list
Tomas Cohen Arazi [Thu, 17 May 2018 13:33:32 +0000 (10:33 -0300)]
Bug 20776: Add Selenium::Remote::Driver to the dependency list

This dependency is missing from the PerlDependencies.pm file.
This patch adds it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: DBRev 18.06.00.025
Nick Clemens [Fri, 7 Sep 2018 13:32:31 +0000 (13:32 +0000)]
Bug 17530: DBRev 18.06.00.025

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: (QA follow-up) Fix caching error
Marcel de Rooy [Fri, 7 Sep 2018 05:50:13 +0000 (07:50 +0200)]
Bug 17530: (QA follow-up) Fix caching error

The fourth patch made this change:
-    $last_article_requestable_guesses->{$key} = $res;
+    $cache->set_in_cache(GUESSED_ITEMTYPES_KEY, $res);

This removed the category level in the cached hash. Adding it back here.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested by verifying cached values, running opac-search with anonymous
session as well as user context.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl
Marcel de Rooy [Mon, 3 Sep 2018 09:49:08 +0000 (11:49 +0200)]
Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl

As requested by RM on Bugzilla comment53.

This pref allows you to always display the link on search results.
Which is the previous behavior ;) It will raise false positives, whereas
the algorithm may result in false positives or negatives (depending on
default item type and circulation rules).

When upgrading the pref is set to always (current behavior), new installs
get the new calc value using the algorithm in may_article_request.

Test plan:
Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
Run t/db_dependent/ArticleRequests.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: (QA follow-up) Move may_article_request to ItemType
Marcel de Rooy [Mon, 4 Jun 2018 08:03:40 +0000 (10:03 +0200)]
Bug 17530: (QA follow-up) Move may_article_request to ItemType

As requested by QA, we should move may_article_request out of Biblio.

For reasons of performance removed the wrapper layer of may_article_request
in opac-search. No need to look up all item types. For readability kept
the routine in the detail scripts.

Note for running ArticleRequests.t: A possible failure on the subtest
'search_limited' is addressed on bug 20866. So you can ignore that one.
As long as the subtest for may_article_request passes.

Test plan:
See previous patches.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: (QA follow-up) Replace class_or_self variables
Marcel de Rooy [Thu, 31 May 2018 07:53:00 +0000 (09:53 +0200)]
Bug 17530: (QA follow-up) Replace class_or_self variables

See comment23. Requested by QA.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: (QA follow-up) Replace our variable by cached value
Marcel de Rooy [Thu, 15 Mar 2018 11:04:30 +0000 (12:04 +0100)]
Bug 17530: (QA follow-up) Replace our variable by cached value

Instead of saving the state locally in a variable during Plack lifetime,
we move the saved hash to the cache. We clear the key when we enter
smart-rules.pl. This makes a change in circ rules immediately effective.

Test plan:
Run the modified tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: Use can_article_request to control sidebar link
Marcel de Rooy [Thu, 1 Mar 2018 14:38:48 +0000 (15:38 +0100)]
Bug 17530: Use can_article_request to control sidebar link

Before this patch, the 'Request article' link is displayed whenever the
pref is enabled. In many cases this might be useless. Instead of a guess
as in opac-search, we now call can_article_request to know for sure.
Note: at least this is the case when a user has logged in.

Update sidebar template with template variable artreqpossible.
Add code in opac-detail, MARCdetail and ISBDdetail to fill it.

Test plan:
[1] Look for two biblios with items: one that should allow article requests
    and one that should not (respecting branch, patron, item type).
[2] Verify on detail, ISBD and MARC that the link is displayed for
    the first biblio and hidden for the second biblio.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: Use may_article_request method in opac-search
Marcel de Rooy [Thu, 1 Mar 2018 14:25:44 +0000 (15:25 +0100)]
Bug 17530: Use may_article_request method in opac-search

If you enable pref ArticleRequests, until now all search results got the
'Request article' link. This patch tries to improve the situation by
using the new sub with the itemtype of the search result.

In most cases the number of links will drastically decrease. It may still
be possible sometimes that a link is shown while it effectively is not
possible, but we do not get the performance burden of determining that and
going through all items.

Test plan:
[1] Look for two borrowers P1 and P2 within categories C1 resp. C2.
[2] Look for two biblios B1 and B2 with default item types I1 resp. I2.
    (See 942c in case of MARC21.)
[3] Make sure that no circ rules allow article requests. Enable the pref.
[4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes.
    Log out. Search for B1 and B2, verify that only B1 has AR link.
    Log in as P1. Verify that only B1 has AR link.
    Log in as P2. Verify that no biblio has AR link.
[5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only.
    Log out. Search for B1 and B2, verify that both have AR links.
    Log in as P1. Verify that only B1 has AR link.
    Log in as P2. Verify that only B2 has AR link.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes
Marcel de Rooy [Thu, 1 Mar 2018 13:29:01 +0000 (14:29 +0100)]
Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes

This routine looks at the issuingrules and makes a fast 'intelligent
guess' if article requests may be allowed for item types while
branch code and patron category may not be available.

We also add Koha::Biblio->may_article_request using the routine based
on default item type or parameter. Implemented as both class and instance
method. Added a few tests.

Test plan:
[1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
[2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: (RM follow-up) Fix TT syntax
Nick Clemens [Thu, 6 Sep 2018 19:04:45 +0000 (19:04 +0000)]
Bug 7534: (RM follow-up) Fix TT syntax

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 13618: Do not use html filters with KohaSpan
Jonathan Druart [Tue, 4 Sep 2018 19:11:15 +0000 (16:11 -0300)]
Bug 13618: Do not use html filters with KohaSpan

To recreate the issue:
Go to Home › Administration › Library groups
Create a new group
 "Group <span class='name'>xxx</span> created."

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: DBRev 18.06.00.025
Nick Clemens [Fri, 7 Sep 2018 13:09:42 +0000 (13:09 +0000)]
Bug 19817: DBRev 18.06.00.025

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: (QA follow-up) Add German manual and fix system preference help files
Katrin Fischer [Mon, 13 Aug 2018 02:04:29 +0000 (02:04 +0000)]
Bug 19817: (QA follow-up) Add German manual and fix system preference help files

- German language manuals were added since this patch was started
- The structure of the manual was changed slightly, system
  preferences were moved into their own chapter

To test:
- Test help files display correctly for system preferences display correctly
  Note: Local use uses a different page than the other tabs
- Test German shows up as option in KohaManualLanguage and links
  correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Remove numbering from chapter file names
Jonathan Druart [Thu, 16 Aug 2018 14:59:36 +0000 (11:59 -0300)]
Bug 19817: Remove numbering from chapter file names

See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8
    Remove numbering from chapter file names
from koha-manual

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: use https instead of http
Jonathan Druart [Tue, 10 Apr 2018 14:07:03 +0000 (11:07 -0300)]
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Use the language from the interface if valid
Jonathan Druart [Mon, 9 Apr 2018 14:30:01 +0000 (11:30 -0300)]
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Open the manual in a new window, not a popup
Jonathan Druart [Wed, 4 Apr 2018 16:35:35 +0000 (13:35 -0300)]
Bug 19817: Open the manual in a new window, not a popup

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Add pref KohaManualLanguage
Jonathan Druart [Wed, 4 Apr 2018 16:30:04 +0000 (13:30 -0300)]
Bug 19817: Add pref KohaManualLanguage

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Move code to Koha::Manual to make it testable and reusable
Jonathan Druart [Mon, 18 Dec 2017 21:23:29 +0000 (18:23 -0300)]
Bug 19817: Move code to Koha::Manual to make it testable and reusable

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Make the location of the manual configurable - KohaManualBaseURL
Jonathan Druart [Mon, 18 Dec 2017 19:21:25 +0000 (16:21 -0300)]
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Remove local help files + edit help feature
Jonathan Druart [Thu, 14 Dec 2017 18:11:36 +0000 (15:11 -0300)]
Bug 19817: Remove local help files + edit help feature

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 19817: Redirect to the online manual
Jonathan Druart [Thu, 14 Dec 2017 18:03:44 +0000 (15:03 -0300)]
Bug 19817: Redirect to the online manual

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: DBRev 18.06.00.024
Nick Clemens [Thu, 6 Sep 2018 16:52:59 +0000 (16:52 +0000)]
Bug 7534: DBRev 18.06.00.024

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: (QA follow-up) Don't do pickup branch checking for determining holdability...
Kyle M Hall [Thu, 6 Sep 2018 13:50:04 +0000 (09:50 -0400)]
Bug 7534: (QA follow-up) Don't do pickup branch checking for determining holdability in the OPAC

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: (RM follow-up) Fix tests and adjust after bug 15524
Nick Clemens [Sat, 25 Aug 2018 19:06:21 +0000 (19:06 +0000)]
Bug 7534: (RM follow-up) Fix tests and adjust after bug 15524

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Disambiguate branchcode parameter, make it match between subroutines
Kyle M Hall [Wed, 15 Aug 2018 17:51:10 +0000 (13:51 -0400)]
Bug 7534: Disambiguate branchcode parameter, make it match between subroutines

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Fix number of tests for Holds.t
Kyle M Hall [Wed, 15 Aug 2018 17:46:14 +0000 (13:46 -0400)]
Bug 7534: Fix number of tests for Holds.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Check hold availability to desired pickup location in opac-reserve.pl
Lari Taskula [Tue, 7 Feb 2017 15:53:52 +0000 (17:53 +0200)]
Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl

To test:
-1. Have access to your browser's developer tools in order to modify <select>
    dropdown values
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No". Remember the
   branchcode of this library!
3. Go place a hold in OPAC
4. See the provided "Pick up location" list
5. Observe the library that you configured is not present in the list
6. You should see another library selected by default. Right click that and
   in Firefox/Chrome click "Inspect element"
7. You should see a list of <option value="xxxx">blabla</option> elements
8. Double click between value (xxxx in above example) and replace the value
   with the branchcode you remember from step 2.
9. Place the hold
10. Observe that you are taken to cgi-bin/koha/opac-user.pl but your hold
    was not successful.
11. Go back to place a hold and this time do not modify any values.
12. Observe that a hold is now placed.

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Validate pickup location in CanBook/ItemBeReserved
Lari Taskula [Tue, 7 Feb 2017 15:51:18 +0000 (17:51 +0200)]
Bug 7534: Validate pickup location in CanBook/ItemBeReserved

This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold.

To test:
1. prove t/db_dependent/Holds.t

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: (QA follow-up) Default pickup location to Yes when adding a new library
Lari Taskula [Tue, 7 Mar 2017 15:38:28 +0000 (17:38 +0200)]
Bug 7534: (QA follow-up) Default pickup location to Yes when adding a new library

To test:
1. Apply the patches before this one
2. Go to /cgi-bin/koha/admin/branches.pl
3. Press New library button
4. Scroll down the page and observe Pickup location defaults to No
5. Apply this patch
6. Go to /cgi-bin/koha/admin/branches.pl
7. Press New library button
8. Scroll down the page and observe Pickup location now defaults to Yes

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Display pickup locations instead of all libraries in opac-reserve.pl
Lari Taskula [Tue, 7 Feb 2017 17:42:22 +0000 (19:42 +0200)]
Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl

This patch sets opac-reserve.tt to use the list of pickup libraries instead
of every library in the system.

To test:
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No"
3. Go to OPAC and place a hold
4. See the provided Pickup location list
5. Observe the library that you configured is not present in the list

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Display pickup locations instead of all libraries in request.pl
Lari Taskula [Wed, 8 Feb 2017 14:45:23 +0000 (16:45 +0200)]
Bug 7534: Display pickup locations instead of all libraries in request.pl

This patch sets request.tt to use the list of pickup libraries instead
of every library in the system.

To test:
1. Go to cgi-bin/koha/admin/branches.pl
2. Configure one of your libraries to "Pickup location" => "No"
3. Go place a hold in intranet
4. See the provided "Pickup at" list
5. Observe the library that you configured is not present in the list
6. Place the hold
7. See list of existing holds on that biblio
8. See "Pickup library" column and observe your configured library is
   not included in the list

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Add configuration to admin/branches.pl
Lari Taskula [Tue, 7 Feb 2017 17:52:15 +0000 (19:52 +0200)]
Bug 7534: Add configuration to admin/branches.pl

This patch adds a configuration option for pickup locations.

To test:
1. Apply patch
2. Go to cgi-bin/koha/admin/branches.pl
3. Observe there is a new column "Pickup location"
4. Click "Edit" for any library
5. Scroll to bottom of the page and select "No"
6. Click "Submit"
7. Observe your library in Libraries-table, notice the value of "Pickup location"
   has changed to "No"

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Use search parameters for Koha::Template::Plugin::Branches->all
Lari Taskula [Tue, 7 Feb 2017 17:40:38 +0000 (19:40 +0200)]
Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all

This lets us query libraries with additional search parameters and is useful
for this particular Bug by allowing us to select pickup locations.

Unit tests included.

To test:
1. prove t/db_dependent/Template/Plugin/Branches.t

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 7534: Add new column "pickup_location" to branches
Lari Taskula [Tue, 7 Feb 2017 17:02:57 +0000 (19:02 +0200)]
Bug 7534: Add new column "pickup_location" to branches

This patch adds a new column "pickup_location" for each library. This value
defines whether a library can be used as a pickup location or not.

For extended configurability, this flag could perhaps be considered as a part
of issuing rules, but as of now, this patch only offers a simple flag into
each library. This method also allows easy way for REST API to determine valid
pickup locations by querying the /libraries endpoint.

To test:
1. perl installer/data/mysql/updatedatabase.pl
2. Observe
DEV atomic update: bug_7534.perl
Upgrade to XXX done (Bug 7534 - Let libraries have configuration for pickup locations)

https://bugs.koha-community.org/show_bug.cgi?id=7354

Signed-off-by: Koha Team AMU <axelle.clarisse@univ-amu.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15287: Add generated CSS
Nick Clemens [Thu, 6 Sep 2018 16:22:24 +0000 (16:22 +0000)]
Bug 15287: Add generated CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15287: (follow-up) QA fix for position of user icon
Owen Leonard [Fri, 31 Aug 2018 14:47:18 +0000 (14:47 +0000)]
Bug 15287: (follow-up) QA fix for position of user icon

This patch corrects the CSS for the user icon which appears when the
browser width is very narrow.

To test, apply the patch, rebuild CSS, and clear your browser cache if
necessary. View the OPAC with and without a user logged in and confirm
that the user icon at the top of the page looks correct at narrow
browser widths.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 15287: Use font-awesome on the OPAC
Owen Leonard [Fri, 10 Aug 2018 16:09:56 +0000 (16:09 +0000)]
Bug 15287: Use font-awesome on the OPAC

This patch replaces Bootstrap's glyphicons with Font Awesome icons.

To test, apply the patch and clear your browser cache and regenerate the
OPAC CSS from the LESS file if necessary. Check these icons and confirm
they look correct:

- Cart and Lists icons in the OPAC header
- User icon in the header when the browser window is narrow
- Languages menu when multiple languages are installed and
  the OpacLangSelectorMode system preference is "top" or "both top and
  footer."
- Set the  SuspendHoldsOpac system preference to "allow" and log in to
  the OPAC as a user who has one or more holds.
  - Check the appearance of the "suspend" and "resume" buttons both in
    the table of holds and at the bottom.
- With one or more clubs defined, log in to the OPAC and check the
  "Clubs" tab on the user summary page. The "Enroll" and "Cancel
  enrollment" buttons should look correct.
- On the "your messaging" tab in the OPAC, the "Digests only"
  information icon should look correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20898: (RM follow-up) Add missing filters
Nick Clemens [Thu, 6 Sep 2018 17:26:47 +0000 (17:26 +0000)]
Bug 20898: (RM follow-up) Add missing filters

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20898: Add generated CSS
Nick Clemens [Thu, 6 Sep 2018 16:21:47 +0000 (16:21 +0000)]
Bug 20898: Add generated CSS

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20898: Replace OPAC detail's results browser with non-JavaScript version
Owen Leonard [Fri, 31 Aug 2018 14:09:01 +0000 (14:09 +0000)]
Bug 20898: Replace OPAC detail's results browser with non-JavaScript version

This patch moves generation of the OPAC detail page's results browser
from JavaScript to the template. This makes the template easier to
understand and easier to debug. It also makes it possible for the widget
to be completely non-dependent on JavaScript.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - Enable the OpacBrowseResults system preference and perform a search
   in the OPAC which will return multiple results.
 - Click on any title in the first page of search results.
 - On the bibliographic detail page there should be a "Browse results"
   link in the right-hand sidebar just as before.
   - Test that the "Previous," "Back to results," and "Next" links work
     correctly.
   - Click the "Browse results" link. A list of the first 20 search
     results should appear. An arrow should indicate the title you're
     viewing.
   - Click any title in the results browser. The page should correctly
     load that record.
   - Clicking the numbered links at the top of the results browser
     should do the same.

Signed-off-by: Cab Vinton <bibliwho@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20743: Update two-column templates with Bootstrap grid: Administration part 7
Owen Leonard [Wed, 2 May 2018 13:12:33 +0000 (13:12 +0000)]
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Navigate directly to /cgi-bin/koha/admin/printers.pl
   - View and edit printers
 - Administration -> Search engine configuration (or navigate directly
   to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
 - Administration -> Circulation and fines rules
 - Administration -> SMS cellular providers (enable SMSSendDriver or
   navigate directly to /cgi-bin/koha/admin/sms_providers.pl)
 - Administration -> Z39.50/SRU servers -> New SRU server -> Modify SRU
   search fields mapping
 - Administration -> System preferences -> Local use
   - View and edit local use preferences
 - Administration -> Transport cost matrix
 - With  UsageStats enabled, go to Administration -> Share your usage
   statistics.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20742: (RM follow-up) Fix menu include
Nick Clemens [Thu, 6 Sep 2018 16:53:02 +0000 (16:53 +0000)]
Bug 20742: (RM follow-up) Fix menu include

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20742: Update two-column templates with Bootstrap grid: Administration part 6
Owen Leonard [Wed, 2 May 2018 12:26:43 +0000 (12:26 +0000)]
Bug 20742: Update two-column templates with Bootstrap grid: Administration part 6

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> MARC frameworks -> MARC structure -> Subfields
   - View and edit subfields
 - Administration -> Record matching rules
   - View and edit record matching rules
 - Administration -> OAI sets configuration
   - View and edit OAI sets
     - Define mappings for an OAI set
 - Administration -> Patron attribute types
   - View and edit patron attribute types
 - Administration -> System preferences
 - Administration -> Z39.50/SRU servers
   - View and edit servers

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
6 years agoBug 20741: (RM follow-up) adjust selenium tests
Nick Clemens [Thu, 6 Sep 2018 12:43:06 +0000 (12:43 +0000)]
Bug 20741: (RM follow-up) adjust selenium tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>